From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#17272: bug#19064: bug#17272: bug#19064: bug#17272: bug#19064: 25.0.50; `message' overwrites `y-or-n-p' prompt, so user misses it Date: Thu, 21 Nov 2019 23:39:42 +0200 Organization: LINKOV.NET Message-ID: <878so8lxyx.fsf@mail.linkov.net> References: <8ea0a3fa-5169-4493-bd54-3ebe47836a35@default> <871rugbqmy.fsf@mail.linkov.net> <87d0dxyh7z.fsf@gnus.org> <53c55db5-d623-4946-af2e-d141e7bc7acd@default> <87sgmrpir5.fsf@web.de> <87mucya2a7.fsf@web.de> <87mucy4cb2.fsf@web.de> <621b98dc-0fe9-4eef-9e11-7580fb446e97@default> <87k1822ocn.fsf@web.de> <87lfsfmtk0.fsf@mail.linkov.net> <874kz3gibu.fsf@gnus.org> <87bltaw3xz.fsf@mail.linkov.net> <87r224x54p.fsf@mail.linkov.net> <87v9rgnv0o.fsf@gnus.org> <877e3vqx9r.fsf@mail.linkov.net> <87v9reqk6o.fsf@mail.linkov.net> <878soacdur.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="51311"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Michael Heerdegen , 17272@debbugs.gnu.org, Lars Ingebrigtsen , 19064@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 22 00:04:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXvUj-000DAM-A0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 00:04:13 +0100 Original-Received: from localhost ([::1]:46406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXvUh-000346-Il for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 18:04:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60503) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXvUZ-00033W-Vz for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:04:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXvUY-0002z0-SI for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44655) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXvUY-0002ys-Ov for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXvUY-0005kq-Ia for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2019 23:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 17272-submit@debbugs.gnu.org id=B17272.157437742422049 (code B ref 17272); Thu, 21 Nov 2019 23:04:02 +0000 Original-Received: (at 17272) by debbugs.gnu.org; 21 Nov 2019 23:03:44 +0000 Original-Received: from localhost ([127.0.0.1]:53467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvUD-0005jW-Ql for submit@debbugs.gnu.org; Thu, 21 Nov 2019 18:03:42 -0500 Original-Received: from black.elm.relay.mailchannels.net ([23.83.212.19]:29658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvUA-0005jH-6E; Thu, 21 Nov 2019 18:03:39 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EE0BA6A0D78; Thu, 21 Nov 2019 23:03:36 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a7.g.dreamhost.com (100-96-87-246.trex.outbound.svc.cluster.local [100.96.87.246]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5B8AD6A20E3; Thu, 21 Nov 2019 23:03:36 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a7.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Thu, 21 Nov 2019 23:03:36 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Daffy-Exultant: 4deb5770673f4e19_1574377416631_2981569835 X-MC-Loop-Signature: 1574377416631:3777984559 X-MC-Ingress-Time: 1574377416631 Original-Received: from pdx1-sub0-mail-a7.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a7.g.dreamhost.com (Postfix) with ESMTP id DE25182B18; Thu, 21 Nov 2019 15:03:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=3sGb7GtlIxXzN0zmifqvjTQnhK0=; b= AIPDCtA8bjakP4hmTscq0HLVm6qaJvQMpBbiSDZU6mbgSQud2LngGbfpv3c0zd81 /S4tfQwxwiy8DJ03uVdD0ccSjHjCGEt5TQhDxCFG72WBD4TR+Da04RvnEfI6dYbR r6l1IgOCuQHR0+t5fO1RWGT1qbGmijt3o3ZYu0jCd1Q= Original-Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a7.g.dreamhost.com (Postfix) with ESMTPSA id D853282ACF; Thu, 21 Nov 2019 15:03:27 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a7 In-Reply-To: <878soacdur.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 20 Nov 2019 23:44:28 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172172 Archived-At: >> It's tempting to do nothing :-), but since the problem is >> already present with yes-or-no-p too, it should be fixed >> because it's a general problem affecting other commands too. > > I tend to agree, but it's a longstanding thing in Emacs, so I would be > very wary of touching it (at least until we get some more opinions). Many other important minibuffer-reading functions already let-bind enable-recursive-minibuffers to t: custom-variable-prompt find-function-read describe-function describe-variable describe-symbol read-input-method-name read-char-by-name read-passwd and many other. So yes-or-no-p could do the same because it's important for users to be able to answer yes/no questions regardless of whether they activated the minibuffer intentionally or by mistake. >> The nil value of enable-recursive-minibuffers by default was intended >> to avoid confusion for beginners unadvisedly typing such sequences as >> M-x M-x M-x M-x M-x ... to get out from which is not easy. > > That may be true, but are you sure there aren't other problems being > avoided by it? > > Let me give you and example: in icomplete-mode, there is a > post-command-hook that displays some overlays in the minibuffer. Now, > if we take your patch, indeed icomplete-mode doesn't have to worry about > enable-recursive-minibuffers in the example I gave you. This is good, > no more error message. However, that also means that instead of an > annoying error message, you get another confusing bug where the > post-command-hook will prevail in the recursive minibuffer, which just > doesn't make sense when answering just yes-or-no. > > In this particular case, I additionally protected the code against this, > but what I'm saying is that other bugs may be uncovered by your patch > that are today hidden behind the annoying-but-reasonable error message. All experienced Emacs users have enable-recursive-minibuffers enabled, so everything should work regardless of the value of enable-recursive-minibuffers.