From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#32676: [PATCH] Add option to highlight the 'next-error' error message Date: Sat, 29 Feb 2020 16:40:01 +0100 Message-ID: <878skl767i.fsf@stefankangas.se> References: <20180910050802.25922-1-erjoalgo@gmail.com> <83a7ollcq2.fsf@gnu.org> <874let1o3k.fsf@gmail.com> <831s9xl54b.fsf@gnu.org> <874leq1hw4.fsf@mail.linkov.net> <87worlgh0k.fsf@mail.linkov.net> <878swkxqo1.fsf_-_@mail.linkov.net> <83wok37mqd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="99308"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: erjoalgo@gmail.com, rpluim@gmail.com, Juri Linkov , 32676@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 29 16:41:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j84Es-000PjH-5Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Feb 2020 16:41:14 +0100 Original-Received: from localhost ([::1]:33294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j84Er-0007HL-04 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Feb 2020 10:41:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49604) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j84Ej-0007FU-FN for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 10:41:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j84Eg-0005ru-2O for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 10:41:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57507) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j84Ef-0005rm-VQ for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 10:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j84Ef-00064N-S1 for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 10:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Feb 2020 15:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32676-submit@debbugs.gnu.org id=B32676.158299081323239 (code B ref 32676); Sat, 29 Feb 2020 15:41:01 +0000 Original-Received: (at 32676) by debbugs.gnu.org; 29 Feb 2020 15:40:13 +0000 Original-Received: from localhost ([127.0.0.1]:35244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j84Dt-00062k-Kb for submit@debbugs.gnu.org; Sat, 29 Feb 2020 10:40:13 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:40526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j84Dr-00062N-Hn for 32676@debbugs.gnu.org; Sat, 29 Feb 2020 10:40:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aNEjYtSSKB9VDu3d5FE+n+K9Ohc4pY6Jh92KDpwASOE=; b=iGcyWf9UKUws6f2l8aObzJVnj4 11oSYWvA5kVBBD2er/LHl3YIrkr8rsIBl/SO3evNjKIQ7JfZSOx8zTq0X2aXBAuykVZBG4bneh2GZ zIPGsKlweGQNUMvGmS235DdldVogU9hf82kkUslCx2BVhkdNfLR8iswsZybLsh62eVPaBwPcxLndG oZQv1y60FnkaAY7B3ulPjTg05HTIN3D2yX1VJTyCK+03Za8SCISnk8KhZIMkux1Ar//xRofqmgvj2 0WTcwN3wcSg3swiJ7bSnkgwqcqpkv4XbWDXeX37czNurNdH2jxUIDCISwpZMRS55cG6cdPUXV6s6b 0B2o4m1A==; Original-Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:59414 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1j84Dj-001rV2-Lo; Sat, 29 Feb 2020 10:40:03 -0500 In-Reply-To: <83wok37mqd.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Apr 2019 08:48:26 +0300") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176676 Archived-At: Hi Ernesto, To accept your contribution to Emacs, we need to you to assign copyright to the FSF. You can read more about the reasons why here: https://www.gnu.org/licenses/why-assign.html Before we can make any progress with this patch, I think we need to clarify that point. Would you be willing to sign such paperwork? Thanks in advance. Best regards, Stefan Kangas Eli Zaretskii writes: >> From: Juri Linkov >> Cc: Eli Zaretskii , Robert Pluim , 32676@debbugs.gnu.org >> Date: Mon, 08 Apr 2019 22:36:38 +0300 >> >> > I'd like to know if this patch is still being considered? >> >> Why not? Your patch provides a helpful feature. I see only 2 problems >> with its latest version: >> >> 1. compilation-current-error should be generalized not to be too >> compilation-specific; >> >> 2. next-error-hook should not be used for core features, >> you could call next-error-message-highlight directly >> from next-error-found. > > 3. A contribution this size needs legal paperwork for us to be able to > accept it. Ernesto, would you like to start the paperwork now? > > Thanks.