From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41821: 28.0.50; read-directory-name in vc commands should provide defaults from projects Date: Tue, 23 Jun 2020 02:45:55 +0300 Organization: LINKOV.NET Message-ID: <878sge7jls.fsf@mail.linkov.net> References: <87r1ulxk48.fsf@mail.linkov.net> <7164426e-8c37-8839-64da-563cfa829b53@yandex.ru> <87mu50j5cu.fsf@mail.linkov.net> <87y2oh8fdv.fsf@mail.linkov.net> <87366ohw5z.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="98547"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41821@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 23 02:16:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnWbl-000Pab-Gy for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jun 2020 02:16:13 +0200 Original-Received: from localhost ([::1]:33944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnWbk-000774-Hf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Jun 2020 20:16:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnWba-00074y-PJ for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnWba-00032W-Df for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnWba-00071Z-97 for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jun 2020 00:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41821 X-GNU-PR-Package: emacs Original-Received: via spool by 41821-submit@debbugs.gnu.org id=B41821.159287133126932 (code B ref 41821); Tue, 23 Jun 2020 00:16:02 +0000 Original-Received: (at 41821) by debbugs.gnu.org; 23 Jun 2020 00:15:31 +0000 Original-Received: from localhost ([127.0.0.1]:34953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWb5-00070K-6m for submit@debbugs.gnu.org; Mon, 22 Jun 2020 20:15:31 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:60429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWb2-0006zs-J7 for 41821@debbugs.gnu.org; Mon, 22 Jun 2020 20:15:29 -0400 X-Originating-IP: 91.129.108.6 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 75BB2C0004; Tue, 23 Jun 2020 00:15:20 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Mon, 22 Jun 2020 03:08:36 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182298 Archived-At: --=-=-= Content-Type: text/plain >> But it would be nice to share these directories between project.el and vc.el. > > Perhaps there could be a public function in project.el called > project-known-roots. Like this? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=project-known-roots.patch diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 2f213dab8b..f489145e92 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -935,6 +935,12 @@ project-prompt-project-dir (read-directory-name "Select directory: " default-directory nil t) pr-dir))) +;;;###autoload +(defun project-known-roots () + "Return a list of known roots." + (project--ensure-read-project-list) + (mapcar #'project-try-vc (mapcar #'car project--list))) + ;;; Project switching diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 9b12d44978..cc83d9a7a1 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2547,7 +2555,10 @@ vc-print-root-log rootdir) (if backend (setq rootdir (vc-call-backend backend 'root default-directory)) - (setq rootdir (read-directory-name "Directory for VC revision log: ")) + (setq rootdir (read-directory-name "Directory for VC revision log: " nil + (mapcan (lambda (r) (when (eq (car r) 'vc) + (list (cdr r)))) + (project-known-roots)))) (setq backend (vc-responsible-backend rootdir)) (unless backend (error "Directory is not version controlled"))) --=-=-=--