From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#40863: [PATCH] Improve the display-time-world UI Date: Fri, 07 Aug 2020 18:51:35 +0100 Message-ID: <878seqgx94.fsf@tcd.ie> References: <874kt4y1rc.fsf@tcd.ie> <87k11u48t0.fsf@stefankangas.se> <87y2pircll.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33274"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40863@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 07 19:52:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k46XJ-0008XG-S0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Aug 2020 19:52:09 +0200 Original-Received: from localhost ([::1]:56056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k46XI-0005bo-Up for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Aug 2020 13:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k46XC-0005bV-1h for bug-gnu-emacs@gnu.org; Fri, 07 Aug 2020 13:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k46XB-0002y8-OJ for bug-gnu-emacs@gnu.org; Fri, 07 Aug 2020 13:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k46XB-0003JF-Kn for bug-gnu-emacs@gnu.org; Fri, 07 Aug 2020 13:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Aug 2020 17:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40863 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40863-submit@debbugs.gnu.org id=B40863.159682270512700 (code B ref 40863); Fri, 07 Aug 2020 17:52:01 +0000 Original-Received: (at 40863) by debbugs.gnu.org; 7 Aug 2020 17:51:45 +0000 Original-Received: from localhost ([127.0.0.1]:57509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k46Wv-0003Il-8u for submit@debbugs.gnu.org; Fri, 07 Aug 2020 13:51:45 -0400 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:37609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k46Wt-0003IY-4W for 40863@debbugs.gnu.org; Fri, 07 Aug 2020 13:51:43 -0400 Original-Received: by mail-wm1-f44.google.com with SMTP id k8so2642794wma.2 for <40863@debbugs.gnu.org>; Fri, 07 Aug 2020 10:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2Fz3sHzJXQANt84NNMVccB1AvK4rgt2P9hlSvImWFHw=; b=LZmITsRb5saAeR4QlzanWqlvVum/crHtT+zV+GmaXcB/sOS7Nf/j42wYDBZkzOqcul TZcXeVnRwz1D/dflabdFl0avdqpl2HZ5zq+6JZm18zMpCnCyHFBluQf2UC/zlBJlrJ+F 4tHthVxGVJ4dS29eD6TMYKo2KdKgG9vQbKndbG/T6c8VMJJsi3mrNh3OxCA/s1XcXFP9 L9R2Pn//5vrkc0Ove1GOwZrEGGOlzBpA6VAT+2+n9mNE+flzfITFattklbK7oCw5Jlt7 Plru37oqCdZXo9NpLIqCQAd3n+hYS7oUStxZ5K1lTXKZLujyOG1h/QLDTzzQ34BMgZlY /9Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2Fz3sHzJXQANt84NNMVccB1AvK4rgt2P9hlSvImWFHw=; b=qU14VHuJSMFXBLCNVPhZCdSHLdYtYEg91QmZAY0D9FhlPZpZXQcSR1tsYNOdd1ISoO MjvPtWXx2gxQXepOc3vYWQBr2D4IuX0e9IqNvVoHEpuPt2P/Tsx2tFqAwNhTSZCm+nwC kUmPBxheDbR/rJV+rutvh8A7kzoeK8VYrXSxDONe7qVsmEQiwhl3iB4ByqRwbMDV9TGi YhKDrv7ZWs3MPInE8990mJ6O6SB4rvvKhwEcGD3dUzeYn8gElNikaN4LuBzsBFr5ehoz 4W305OOUCgezEbQVBz72II0s0r/XHdhyfhyfouO16VJmv47LBqwPc9nH31wJerH1bD5y nzjA== X-Gm-Message-State: AOAM531ROrlCW6jERE61tvy0MTQZQFV7xcvorFFl4jo7Z5oapAyXvQEy N041nvShxW1NR7HqlP6KiuwbSFEmfCk= X-Google-Smtp-Source: ABdhPJxeszQoBeXamBAkoflD7toOG/HupRCHssGO9l+F6qkrE7k+lslmQpkU6XpeR2CqaNMHitbGhQ== X-Received: by 2002:a1c:4104:: with SMTP id o4mr13653861wma.101.1596822696972; Fri, 07 Aug 2020 10:51:36 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id 8sm11643983wrl.7.2020.08.07.10.51.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 10:51:36 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Fri, 7 Aug 2020 10:23:01 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184289 Archived-At: Stefan Kangas writes: > Thank you for the detailed review! I believe I have fixed all your > comments in the attached patches. (Note that I squashed patch 2 and 3 > into one patch.) > > Please let me know if there are any further comments. Thanks, we're close. ;) See below. > Subject: [PATCH 1/3] Improve display-time-world UI (Bug#40863) [...] > (define-derived-mode display-time-world-mode special-mode "World clock" > "Major mode for buffer that displays times in various time zones. > See `display-time-world'." > + (setq revert-buffer-function 'display-time-world-timer) ^ Nit: #' More importantly, doesn't revert-buffer-function need two parameters? [...] > Subject: [PATCH 3/3] Rearrange and clean up code in time.el (Bug#40863) > > * lisp/time.el (world-clock, zoneinfo-style-world-list) > (legacy-style-world-list, world-clock-list) > (time--display-world-list, world-clock-time-format) > (world-clock-timer-enable, world-clock-timer-second): Move definitions > closer to 'world-clock' code. Unless I'm misreading it, the patch you attached seems to be adding duplicate definitions rather than moving them. -- Basil