From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34476: fluffy whitespace in the mode-line, despite it running off the screen Date: Fri, 07 Aug 2020 13:41:15 +0200 Message-ID: <878seq8yzo.fsf@gnus.org> References: <87lg2icx3u.fsf@jidanni.org> <87ftnfrwef.fsf@mouse.gnus.org> <87r26z0wdy.fsf@tcd.ie> <87eeoi7un0.fsf@gnus.org> <87a6z67t7p.fsf@gnus.org> <83364y8ze0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27590"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: contovob@tcd.ie, 34476@debbugs.gnu.org, jidanni@jidanni.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 07 13:42:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k40lF-00074q-Je for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Aug 2020 13:42:09 +0200 Original-Received: from localhost ([::1]:41228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k40lE-0002Wf-KJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Aug 2020 07:42:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k40l8-0002WZ-LM for bug-gnu-emacs@gnu.org; Fri, 07 Aug 2020 07:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44434) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k40l8-0002JO-Bx for bug-gnu-emacs@gnu.org; Fri, 07 Aug 2020 07:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k40l8-0005bq-9Q; Fri, 07 Aug 2020 07:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 07 Aug 2020 11:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34476 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 34476-submit@debbugs.gnu.org id=B34476.159680048821523 (code B ref 34476); Fri, 07 Aug 2020 11:42:02 +0000 Original-Received: (at 34476) by debbugs.gnu.org; 7 Aug 2020 11:41:28 +0000 Original-Received: from localhost ([127.0.0.1]:55980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k40ka-0005b4-9P for submit@debbugs.gnu.org; Fri, 07 Aug 2020 07:41:28 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k40kX-0005aq-G7 for 34476@debbugs.gnu.org; Fri, 07 Aug 2020 07:41:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=g+KRvyysiQsCF72A8JnJSucvF2HzNB/BeW03ENGbCcI=; b=h/2uJOA7YRN1pVaLy7IerrdKlV 1mDuxbYgnEkgR/1/Qtl0Iw+v1fQ04InGijDBypBmBgRkY9DofMw4HCz0F2aQ3X/7OxyvttzT4mdru JzpXDsAY3vJfHvbKhhi6GzN+mlU14TXBLcIgPsE+/i4iFmoQMVx/h78zzOZNLRJ3I+s4=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k40kP-0006ZI-4j; Fri, 07 Aug 2020 13:41:19 +0200 In-Reply-To: <83364y8ze0.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 07 Aug 2020 14:32:39 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184264 Archived-At: Eli Zaretskii writes: >> + char c = ostring[i]; >> + if (!(c == ' ' && prev == ' ')) >> + { >> + *s++ = c; >> + prev = c; >> + } [...] > Ouch! This is Lisp converted into C, yes? If that looks like Lisp to you... :-) > And it formats the mode-line twice: once in format-mode-line, then > again in display_string, right? No, display_string just displays the string, I think? > You don't need all this inelegance. After display_mode_element > returns, you have all the glyphs it produced in it.glyph_row, so you > can simply remove the unneeded space glyphs from the glyph row (and > adjust the metrics accordingly). Let me know if you need more > detailed help in how to do that. That seems like a lot more work, I think? And I don't see how that could be more efficient than just removing the characters from the C string? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no