From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#22118: 23.2; Hitting ^W in a search selects the wrong word. Date: Thu, 13 Aug 2020 02:58:18 +0300 Organization: LINKOV.NET Message-ID: <878sejgxwp.fsf@mail.linkov.net> References: <20151210092550.6224.qmail@mail.muc.de> <56694D83.3080902@codersco.com> <20151210121027.GA3978@acm.fritz.box> <56697909.9040306@codersco.com> <87k2okbnpk.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4033"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Alan Mackenzie , 22118@debbugs.gnu.org, Jan-Mark To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 13 03:09:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k61k0-0000pl-If for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 03:09:12 +0200 Original-Received: from localhost ([::1]:60622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k61jz-0003pu-3l for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 21:09:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k61jq-0003oO-UO for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 21:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k61jq-0004qO-LD for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 21:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k61jq-00045F-G5 for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 21:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Aug 2020 01:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22118 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22118-submit@debbugs.gnu.org id=B22118.159728092415667 (code B ref 22118); Thu, 13 Aug 2020 01:09:02 +0000 Original-Received: (at 22118) by debbugs.gnu.org; 13 Aug 2020 01:08:44 +0000 Original-Received: from localhost ([127.0.0.1]:46194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k61jX-00044d-RA for submit@debbugs.gnu.org; Wed, 12 Aug 2020 21:08:43 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:35511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k61jV-000445-H2 for 22118@debbugs.gnu.org; Wed, 12 Aug 2020 21:08:42 -0400 X-Originating-IP: 91.129.102.47 Original-Received: from mail.gandi.net (m91-129-102-47.cust.tele2.ee [91.129.102.47]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 6C5D61C0007; Thu, 13 Aug 2020 01:08:32 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Tue, 11 Aug 2020 20:33:41 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184915 Archived-At: > Is the below patch still relevant? I don't know. My patch tried to make the behavior in case of error slightly more useful, but now I see nothing useful in it because after a failure it makes no sense to type C-w C-w C-w ... I don't recommend making code in isearch.el more complicated to handle useless cases. So I won't complain if you'll close this report. :-) >>> I would say, either update the text window too or disallow using ^W >>> after a failure. >> >> I agree that the current behavior is not ideal. The problem is that >> it's difficult to make it more intuitive to work with different >> workflows such as when failing not at the end of the buffer >> but due to a non-existent string, e.g. typing ‘zzz C-w C-w C-w’. >> Please try this patch that takes into account such possible scenarios. >> >> However, I don't agree this is a bug, I think it just provides a more >> useful behavior, so perhaps it shouldn't be installed to emacs-25.