From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14422: 24.3; Eager Macro Expansion Date: Tue, 25 Aug 2020 13:05:43 +0200 Message-ID: <878se3asu0.fsf@gnus.org> References: <87hahz82rh.fsf@Rainer.invalid> <87mwrcjqlu.fsf@Rainer.invalid> <87ehcojm1e.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40224"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Achim Gratz , 14422@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 25 13:06:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAWmO-000ANW-I6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Aug 2020 13:06:16 +0200 Original-Received: from localhost ([::1]:39190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAWmN-0003BL-JR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Aug 2020 07:06:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAWmA-0003AG-79 for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 07:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAWm9-0003Oh-Ur for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 07:06:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAWm9-0007QM-Qf for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 07:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Aug 2020 11:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14422 X-GNU-PR-Package: emacs Original-Received: via spool by 14422-submit@debbugs.gnu.org id=B14422.159835355528515 (code B ref 14422); Tue, 25 Aug 2020 11:06:01 +0000 Original-Received: (at 14422) by debbugs.gnu.org; 25 Aug 2020 11:05:55 +0000 Original-Received: from localhost ([127.0.0.1]:60504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAWm3-0007Pq-83 for submit@debbugs.gnu.org; Tue, 25 Aug 2020 07:05:55 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:40304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAWm1-0007Pb-T2 for 14422@debbugs.gnu.org; Tue, 25 Aug 2020 07:05:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T5QmUtHQbpKVlkbgabXrUOGtn8WnoZnIFa32PTeo2Nw=; b=fEjCUoBthibWhKsELgujbI9RBj Ah2wdF0vUr+c9T+zUxLWXmvokxY6O2ZKeuLCAT0eySgdJg9dkz2odS759/0KCvqO9P/feVh8H30tO h8zyPmWnuMwT8K4oP3nxLiN2Jxm5rEhjzEbbSHsIokt3cdwUhZkTqK11ie2yhaUmsCzk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAWlt-0004jc-1Z; Tue, 25 Aug 2020 13:05:47 +0200 X-Now-Playing: Coil's _The Sound Of Musick_: "Untitled" In-Reply-To: (Stefan Monnier's message of "Mon, 03 Jun 2013 11:29:30 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186262 Archived-At: Stefan Monnier writes: >> The behavior is still different in a few other cases (where eager macro >> expansion is not performed, typically M-C-x and things like that), but >> I hope to reduce/eliminate them at some point. > > It just occurred to me that the patch below which I just installed > covers several of those cases. > > Stefan > > --- lisp/emacs-lisp/lisp-mode.el 2013-05-29 14:14:16 +0000 > +++ lisp/emacs-lisp/lisp-mode.el 2013-06-03 14:23:31 +0000 > @@ -809,6 +809,7 @@ > (defun eval-sexp-add-defvars (exp &optional pos) > "Prepend EXP with all the `defvar's that precede it in the buffer. > POS specifies the starting position where EXP was found and defaults to point." > + (setq exp (macroexpand-all exp)) ;Eager macro-expansion. > (if (not lexical-binding) > exp > (save-excursion It's unclear whether this fixes the reported bug? I tried the final test case, and I didn't get any errors (but I'm not sure I'm testing that the right way). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no