From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#43103: 28.0.50; Default ElDoc composition strategy in Elisp mode (eldoc-documentation-strategy) Date: Sun, 30 Aug 2020 16:15:21 +0100 Message-ID: <878sdwi2ra.fsf@gmail.com> References: <87h7sla2gc.fsf@gmail.com> <83wo1hxx4c.fsf@gnu.org> <87r1rpigff.fsf@gmail.com> <83tuwlxqow.fsf@gnu.org> <87k0xhi51w.fsf@gmail.com> <83blisxl9o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21428"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43103@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 30 17:16:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCP41-0005SY-Si for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Aug 2020 17:16:13 +0200 Original-Received: from localhost ([::1]:58224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCP40-0004uy-Kp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Aug 2020 11:16:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCP3q-0004uf-SU for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 11:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCP3q-0004c9-J2 for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 11:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCP3q-0005Vz-FH for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Aug 2020 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43103 X-GNU-PR-Package: emacs Original-Received: via spool by 43103-submit@debbugs.gnu.org id=B43103.159880053121154 (code B ref 43103); Sun, 30 Aug 2020 15:16:02 +0000 Original-Received: (at 43103) by debbugs.gnu.org; 30 Aug 2020 15:15:31 +0000 Original-Received: from localhost ([127.0.0.1]:50558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCP3L-0005V7-DJ for submit@debbugs.gnu.org; Sun, 30 Aug 2020 11:15:31 -0400 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:40336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCP3J-0005Uu-G9 for 43103@debbugs.gnu.org; Sun, 30 Aug 2020 11:15:30 -0400 Original-Received: by mail-wm1-f53.google.com with SMTP id v4so2422395wmj.5 for <43103@debbugs.gnu.org>; Sun, 30 Aug 2020 08:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7rcKUZnxG+dmxJuycrUxWklY3Fzd0O5J2hDpX3oFwUs=; b=fmDTu6DqlJild7+e9F49q/R6CLOOPNUkv5LBvMMrkPVjyuVbYsvGBOVM7dzvCeyN13 zm8rg0kRUXUKdB9rUdBIBp7MUL4Aq4Gqgz0uIvz/3nz8L2nGuwT42pe6eSRwgoA7Smme 0bxJdb0StfU0JmYBMt7/3vLbEO+UcZ6bjvephwfrFBJBhl2JwMW6YfTto36TfdhOSn7/ Ro+sim0YfjK0mGmwy/vkWdTm5YwvYLDTGI3DdxXWESwiDPmDFf86sISw2vdVVqFEeMvo DPWsCqijCjGLtOE61RwuA30S0+fL7d2nUO8fh0lCS6zTbi40XOziZpjpTaGA82PWXqyB qFXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=7rcKUZnxG+dmxJuycrUxWklY3Fzd0O5J2hDpX3oFwUs=; b=ShoIX9YmWF70EAQzaXL+BJYcMAo1i8CTeP42E+Wzh1jYvT18dN7T3G+q7DcxXyGDFB 3aFHSnKCMh5sSaMZmVW21+qV4KQCwFkxYb0IckXDsPXRbUHhnsiu17MCviXE+VJJyhZK aiCT1dIMZSVOTCXwsQmTet9KjpvasdVwIvmQLcEjtd7hEFICu9vUdqaetG7FWfrQwjQ6 C34qgnI/vTFXYcAepvOVzex0cPzeRTXJ0CyqbhEUwyTIHxRck913JZCMKWndYFmv91jk kErL4dCXz1rE2md9hqmivMqHn/UTFbr0Ii0WyReycUcwlVXKdPcSJsMc4NZyrDe4jQhl t6JQ== X-Gm-Message-State: AOAM532iXcgRND0TmRWnPpSxUgQw0QTIEFZOjwYxjfKWc109TGilW0dF IbrKbpbMUOL4wH/tSt+vRsU= X-Google-Smtp-Source: ABdhPJyRACt8/4duSQg02/01EGlISKoGo0b6izG0cARUDHG/KZ8rV3NxiqSCHNPYOnPmOMEA9D13rQ== X-Received: by 2002:a1c:f30f:: with SMTP id q15mr7240253wmq.60.1598800523520; Sun, 30 Aug 2020 08:15:23 -0700 (PDT) Original-Received: from krug ([89.180.151.132]) by smtp.gmail.com with ESMTPSA id q6sm7546761wma.22.2020.08.30.08.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2020 08:15:22 -0700 (PDT) In-Reply-To: <83blisxl9o.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 Aug 2020 17:26:27 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186706 Archived-At: Eli Zaretskii writes: >> From: Jo=C3=A3o T=C3=A1vora >> Cc: 43103@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca >> Date: Sat, 29 Aug 2020 21:13:31 +0100 >>=20 >> I will agree with you that displaying the transient error >> on those situations is alarmist and not very useful, but it's better >> fixed by adjusting 'flymake-no-changes-timeout' > > If we are okay with a large timeout (like 1 sec at least), then maybe > it's fine. I'm okay with a 1 sec timeout for flymake-no-changes-timeout, though before changing that default I'd first pay attention to the feedback of Flymake+ElDoc users (as you know, Flymake isn't on by default). Personally, as a Flymake user, I'm not very bothered by the alarmist messages. They're very similar to what until very recently happened with the "add a quote" situation (the one that `jit-lock-antiblink-grace` fixed). Other modes (and other editors, IIRC) will visually annotate the transient erroneous state as the user is typing "new code". Though, granted, we shouldn't compare ourselves with those inferior kind. >> Anyway, from your statement, it seems you'd be OK (or at least find less >> problematic) that the two Flymake-unrelated lines: >>=20 >> eldoc-idle-delay: Number of seconds of idle time to wait before prin= ting. >> run-with-idle-timer: (SECS REPEAT FUNCTION &rest ARGS) [SECS is bol= dface] >>=20 >> Being shown when point hovers on the second atom of the form >>=20 >> (run-with-idle-timer eldoc-idle-delay nil ...) >>=20 >> ? > > Expect annoying users due to resizing of mini-window. Yes, and this is why I mentioned eldoc-echo-area-use-multiline-p in my original message. It is the current way to control this (at least before I propose a overhaul of the ElDoc display system). Its default and original value is `truncate-sym-name-if-fit`, which (but for one detail) basically amounts to `t` or "yes, do use multiple lines". So we could 1. greet these annoyed users with this fact and tell them to set eldoc-echo-area-use-multiline-p to nil or 1 2. set it to such a value by default in emacs-lisp-mode 3. wait for the aforementioned overhaul to somehow give us better perspective before doing the work of this bug report (i.e. switch to eldoc-documentation-compose in emacs-lisp-mode). At any rate, as I wrote earlier: - the Flymake Eldoc source is last in the list, so it will be the one edited out if eldoc-echo-area-use-multiline-p is set to nil. In practice this would amount to no immediately visible change in behaviour; - even if eldoc-echo-area-use-multiline-p is set to nil, users can still get to all the info collecte by ElDoc with the new `eldoc-documentation-compose` strategy by pressing M-x eldoc-doc-buffer Hope this clarifies things, Jo=C3=A3o