From: "João Távora" <joaotavora@gmail.com>
To: 43164-done@debbugs.gnu.org
Cc: Philipp Stephani <p.stephani2@gmail.com>
Subject: bug#43164: 26.3.50; project.el still broken under Emacs 26.3
Date: Thu, 03 Sep 2020 13:48:01 +0100 [thread overview]
Message-ID: <878sdrowla.fsf@gmail.com> (raw)
In-Reply-To: <87mu28pp54.fsf@gmail.com> ("João Távora"'s message of "Wed, 02 Sep 2020 09:19:03 +0100")
João Távora <joaotavora@gmail.com> writes:
> João Távora <joaotavora@gmail.com> writes:
>
>> This is breaking Eglot for Emacs 26.3 users:
>> https://github.com/joaotavora/eglot/issues/530
>
> Over there, Andrii Kolomoiets has identified the culprit commit:
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b63c5a7efc89c23230f53a346e29e72a9b4faafc
I fixed this in 5142149758333cfddc25c8c696e0e6f322e37d62, by not adding
the keybinding to a non-existing keymap. I tested merely by loading the
project.el file in Emacs 26.3 and checking it loaded OK. I bumped the
version to 0.5.2 and it should be in GNU ELPA soon.
Directly calling M-x project-other-tab-command in Emacs 26.3 will still
fail, but that's not a show-stopping bug as this one was.
In the future, we must make sure to honour the advice in the file's
header:
;; Package-Requires: ((emacs "26.3") (xref "1.0.2"))
;; This is a GNU ELPA :core package. Avoid using functionality that
;; not compatible with the version of Emacs recorded above.
João
next prev parent reply other threads:[~2020-09-03 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 23:13 bug#43164: 26.3.50; project.el still broken under Emacs 26.3 Philipp Stephani
2020-09-02 8:11 ` João Távora
2020-09-02 8:19 ` João Távora
2020-09-03 12:48 ` João Távora [this message]
2020-09-03 19:04 ` Dmitry Gutov
2020-09-03 19:07 ` Dmitry Gutov
2020-09-13 9:48 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sdrowla.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=43164-done@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).