From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#5773: 23.1; vc-diff save buffer when re-diffing (or save whole fileset) Date: Mon, 14 Sep 2020 15:42:46 +0200 Message-ID: <878sdca2zt.fsf@gnus.org> References: <87pr2sja5c.fsf@blah.blah> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11664"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 5773@debbugs.gnu.org To: Kevin Ryde Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 14 15:46:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHool-0002wd-6u for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Sep 2020 15:46:51 +0200 Original-Received: from localhost ([::1]:37066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHook-0000mN-6p for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Sep 2020 09:46:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHom2-0005VW-Oe for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 09:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41761) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHom2-0003Fr-ER for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 09:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHom2-0007r9-Bp for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 09:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2020 13:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5773 X-GNU-PR-Package: emacs Original-Received: via spool by 5773-submit@debbugs.gnu.org id=B5773.160009101230153 (code B ref 5773); Mon, 14 Sep 2020 13:44:02 +0000 Original-Received: (at 5773) by debbugs.gnu.org; 14 Sep 2020 13:43:32 +0000 Original-Received: from localhost ([127.0.0.1]:53307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHolU-0007qD-HL for submit@debbugs.gnu.org; Mon, 14 Sep 2020 09:43:32 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:59466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHolO-0007pp-Jh for 5773@debbugs.gnu.org; Mon, 14 Sep 2020 09:43:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2goQtCzui4sy31a+pv77cY2cmrcbqVyfkyD0O5y7/W0=; b=YChN8xQm6wCOYGgSmojM+FjdBu Qb/Es7j61EtXnC5FdxcjyWGUYNe5tXYVvBG+MJtyo2XThtgkR2WRpJ0dK5wL0GFPB9BeL9lnRntrX bT7k8dVFxnWrPQ01Cu7zwDdsMFa6XGmS4L1DvJhTrszQego7MLmAlcbyMS8QkhQJyWks=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHokp-0002A1-Jo; Mon, 14 Sep 2020 15:42:53 +0200 X-Now-Playing: Jay Glass Dubs's _Epitaph_: "Animal Estate" In-Reply-To: <87pr2sja5c.fsf@blah.blah> (Kevin Ryde's message of "Fri, 26 Mar 2010 09:42:39 +1100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188049 Archived-At: Kevin Ryde writes: > If you re-run M-x vc-diff from a *vc-diff* buffer, it doesn't ask you to > save the buffer being diffed the way that it does when operating from > that buffer itself > > C-x C-f /some/file/under/vc/control > C-x v = > C-x o > # edit the file's buffer a bit > C-x o # back to the *vc-diff* > C-x v = > > => doesn't ask about saving the edits This bug is still present in Emacs 28, and the ten year old patch amazingly still applies, and fixes the issue, so I've applied it to the trunk (with minor stylistic changes). There was then some discussion about whether other functions could also do with a similar change, which is true, but that shouldn't preclude us from fixing this bug. If somebody sees similar issues in other buffers that they think should be changed, then they can open new bug reports. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no