From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Thu, 01 Oct 2020 03:34:15 +0200 Message-ID: <878scqwwyw.fsf@gnus.org> References: <87d02318fl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5712"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43725@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 03:35:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNnV6-0001N4-L1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 03:35:16 +0200 Original-Received: from localhost ([::1]:45654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNnV5-0007vW-88 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 21:35:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNnUs-0007vN-6b for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 21:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNnUr-0000it-T0 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 21:35:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNnUr-0005m0-Qe for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 21:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 01:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.160151606922150 (code B ref 43725); Thu, 01 Oct 2020 01:35:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 1 Oct 2020 01:34:29 +0000 Original-Received: from localhost ([127.0.0.1]:33458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNnUL-0005lC-1F for submit@debbugs.gnu.org; Wed, 30 Sep 2020 21:34:29 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNnUI-0005kz-1y for 43725@debbugs.gnu.org; Wed, 30 Sep 2020 21:34:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iK2JK5B1136773bNtthPCy2K1T+h1x+SWv8kbl8gNeY=; b=Cvs7O7R5P+zYl2bIPj58l5dX18 kdovxj+suPQ1GfcsaiMl8YC359CTaFKmIXY2lrjPL4v2njGkAykoIaksDMzLdnblV/Hktcul0987O PzyHw0CenWRlaPH+F7tXDer7nvkvUnfb8OD5jb+S4siJSkhU2TEfHTeITQ23nIYaXm68=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNnU9-0000Em-9B; Thu, 01 Oct 2020 03:34:19 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEU0OUQnKjNCSlZr eIQYGiD///9of+7CAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QKAQEVOzRx6fcAAAG+SURBVDjLbVSB jdwwDJODDiA+NECQjtAFToD2n6mk5Nzl0PqAQ2BaJEUrsQX4df3+s9d1ma3kphm07Nori6sBQI/1 M/sn7kUggaj0g9vnqnuZG9mC5VS6bACRGHxVRjMDC7X4DP6ZnRtIE1kGQZdGrhjSpMODZm3hEH+S cKjERQDSIKLNG4h8Gd0sCwL1AAppZ1QgSDtHK0fI7STTL1FtYEpWqpP/AEYAFVF+CMiMGAxUZg8Z fimOF7jfWboauA62d1gfqA6SFXDdwHITFVL7pOsWleX5QyBopfo8KLYBpzhzlDYhqEP0vQzVS8K6 tI7rAcwNMqjJ8egLNns4aioBl+zyTr0BmQ62yLE4TQCGPtU7AQ0BpIFuQqNSyhirZ4eLVnNXocad ctFN8sfz1OnWF1PBAG1rnE0Fx0iAksqW/wAqEUliT7CKsWV27TfgtoFwAW3Xa9vdTt8D1A7/BWhX wPIeUWUxGrI95zU+tyOpxP0Exv4APk9l9b0QUfc7uFd8n2DwfFUktio+kWwHndl6RqI3/66wd0EO cL65GIlFt4ueXvEoAV+MOTCTijuUx5fio/EE3t8dAeuJhKq48xdILZi4Di/3IgAAACV0RVh0ZGF0 ZTpjcmVhdGUAMjAyMC0xMC0wMVQwMToyMTo1OSswMDowMHDTjOgAAAAldEVYdGRhdGU6bW9kaWZ5 ADIwMjAtMTAtMDFUMDE6MjE6NTkrMDA6MDABjjRUAAAAAElFTkSuQmCC X-Now-Playing: The Breeders's _Off You_: "The She" In-Reply-To: (Andrea Corallo's message of "Wed, 30 Sep 2020 22:37:28 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189448 Archived-At: Andrea Corallo writes: >> Was the patch against the trunk supposed to be included here? > > Hi Lars, no it wasn't :) > > In the sense that I'm not sure how do we prefer to proceed with the > review and I'm open for inputs on that. Right. :-) > I didn't know if every time I update the branch is worth posting here a > 10K+ LOC patch, so I waited. Also assuming the review will take some > time to go through I'm not really sure how this is practical. > > OTOH as the branch is already in emacs.git should be trivial for > reviewers at any point in time to produce the diff and quote the parts > they like to discuss. Sure, that's fine. That would be git diff origin/feature/native-comp..origin/master ? > Slightly different but related: I wanted to mention that I think would > be really good if possible to retain the current history. That is going > for a merge instead of applying a single patch. I believe this would be > of great help for me to maintain the code in the future. Sure, sounds good. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no