From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#43543: 28.0.50; Supress truncate notice in eldoc Date: Mon, 05 Oct 2020 10:21:24 +0100 Message-ID: <878sclgh9n.fsf@gmail.com> References: <5B68C681-36E8-419D-B395-E5C798696387@gmail.com> <871rivqpzp.fsf@gnus.org> <836F59AA-C67D-4A73-A0D8-C4E5C8F838C1@gmail.com> <22F4D0C4-3075-47BD-A073-F0D0E98E8F59@gmail.com> <87h7rpj3km.fsf@gnus.org> <87sgaugs0r.fsf@gmail.com> <87r1qerstf.fsf@gnus.org> <87lfglh9j2.fsf@gmail.com> <87lfglqgru.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13011"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43543@debbugs.gnu.org, Yuan Fu , felician.nemeth@gmail.com, andreyk.mad@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 05 11:22:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPMh9-0003Gf-VU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Oct 2020 11:22:11 +0200 Original-Received: from localhost ([::1]:35504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPMh9-0007YN-1k for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Oct 2020 05:22:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPMh0-0007X8-Uu for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 05:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPMh0-0006om-LW for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 05:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPMh0-0001sE-Hg for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 05:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Oct 2020 09:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 43543-submit@debbugs.gnu.org id=B43543.16018896937165 (code B ref 43543); Mon, 05 Oct 2020 09:22:02 +0000 Original-Received: (at 43543) by debbugs.gnu.org; 5 Oct 2020 09:21:33 +0000 Original-Received: from localhost ([127.0.0.1]:47904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPMgX-0001rV-M9 for submit@debbugs.gnu.org; Mon, 05 Oct 2020 05:21:33 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:37510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPMgW-0001rI-9b for 43543@debbugs.gnu.org; Mon, 05 Oct 2020 05:21:32 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id j136so8006774wmj.2 for <43543@debbugs.gnu.org>; Mon, 05 Oct 2020 02:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=VPBqdd4iFb7F0VxoW/8/dIlar35dF6Jja1i6NBXnNPE=; b=JQanI2NsrsFdV7zJ0fME885K+4O37CcvpC9a1jurinPbevt5s4PIQXlIjJ+ohxZnr/ /p7xJ0OAV3O0QteIKb2iEnHXvdQYZV9t2KXTmVzswrO/G7KEvKnEB3psqNi/PWmyt5h/ zkkBflo/PGvshhhWDuyrnQHk14UNsl8blEzz/kQa8FVuYN23BT66M1h7g1PY8QMHpILA NrRxPVb7pAr5XfZwparKiv0KYnrMf5WQUokyGpK2rPSp7luRVeZ+vtHCgm6ucq371yHi yzSZ1evMeshlirFb4u1wI7AOOe7b+45Vexw0One9WUYIuabRu+9QmegV8xEeXJX6E/iV XQvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=VPBqdd4iFb7F0VxoW/8/dIlar35dF6Jja1i6NBXnNPE=; b=TiJeHqy2XWpnUj4M7BEf8n3UxLAEVNL8UJCX6KK+hbZzcrrL+DUBtrmUXYe0Pg3xSz aY+tKN5vUzZ62hYA4j26vFa4EeXxk8FAlQ6W9FgOm2hNqRE1/nyCMNYnmjXkqQyjyveO nczIQZgMHBAdokwEpBIawOUb+7apGW7YK99Bu8p3Z10fae7AqNzngVjLW36aPZhzcCrz AXKf7x9X/ITBcWJ8CmGR3b5b/g8EgDonE596mBQHevpF+bzWXFhoD86na0IO78VoPDCv 7A7v6+n4mBC4muZgnNh49THI9f/RZlk3I/UwbVrBpo2jkE1uVtiGxeeYpW68+S+P2DOH ibAQ== X-Gm-Message-State: AOAM531KQ0x4kagPUuGSYYz0tWaFW57QrzXmQ9j6xdPKulnuPGzaJkDa nsG2BfbLIvHWU1E8ZjgNats= X-Google-Smtp-Source: ABdhPJyXQx1eFT07+f995TLEq5LxfXX0+V6pjWhRGkjTY9nvgfFijMYap2qq1BwhPATSU2fw1psczQ== X-Received: by 2002:a1c:4d05:: with SMTP id o5mr2699757wmh.94.1601889686377; Mon, 05 Oct 2020 02:21:26 -0700 (PDT) Original-Received: from krug ([89.180.147.115]) by smtp.gmail.com with ESMTPSA id c16sm12848736wrx.31.2020.10.05.02.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 02:21:25 -0700 (PDT) In-Reply-To: <87lfglqgru.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 05 Oct 2020 09:21:57 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189811 Archived-At: Lars Ingebrigtsen writes: > Hm... Logical lines is fine by me, but I wonder whether visual lines is > slightly more logical here? This is for display purposes, after all. This is what I thought initially too, and it is still arguable. But logical makes _more_ sense, because frequently you're usually truncating pieces of documentation that come packages in a line. So you'd normally want to use the separation between each piece as a cutting point. Additionally, the control over this dimension as visual lines is already offered by max-mini-window-height, so offering an ElDoc-specific option here seems like overkill (with added complexity and added bugs, as we saw). So the alternative to my current approach is that we find some other way to fix the bug introduced by eldoc-echo-area-display-truncation-message in the visual-lines implementation (which seems complicated) _and_ add a logical lines interface for users such as Andrii (whose request also makes a lot of sense). I think for now, it's better to skip this complexity and just make the logical lines interface: if someone is unsatisfied and can't use max-mini-window-height for some reason, we can attend to it later. Jo=C3=A3o