From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#32676: [PATCH] Add option to highlight the 'next-error' error message Date: Thu, 15 Oct 2020 09:19:25 +0200 Message-ID: <878sc8yn0i.fsf@gnus.org> References: <20180910050802.25922-1-erjoalgo@gmail.com> <83a7ollcq2.fsf@gnu.org> <874let1o3k.fsf@gmail.com> <831s9xl54b.fsf@gnu.org> <874leq1hw4.fsf@mail.linkov.net> <87worlgh0k.fsf@mail.linkov.net> <878swkxqo1.fsf_-_@mail.linkov.net> <874kmxz7e0.fsf@gnus.org> <874kmwy7k8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3439"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Ernesto Alfonso , Robert Pluim , 32676@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 15 09:20:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSxYX-0000lI-3C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 09:20:09 +0200 Original-Received: from localhost ([::1]:34334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSxYV-00088T-QK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 03:20:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSxYQ-00088M-FY for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 03:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42464) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSxYQ-0005Hz-4K for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 03:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSxYP-0004ia-U3 for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 03:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Oct 2020 07:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 32676-submit@debbugs.gnu.org id=B32676.160274637818101 (code B ref 32676); Thu, 15 Oct 2020 07:20:01 +0000 Original-Received: (at 32676) by debbugs.gnu.org; 15 Oct 2020 07:19:38 +0000 Original-Received: from localhost ([127.0.0.1]:54010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSxY2-0004ht-8V for submit@debbugs.gnu.org; Thu, 15 Oct 2020 03:19:38 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSxY0-0004he-Ue for 32676@debbugs.gnu.org; Thu, 15 Oct 2020 03:19:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zjTCF1rB+OD3yuaaMuLzWrHH/DIqGEqudtB+zdWETyc=; b=l7CAn1WB+CenpPoc44Y5MYjzDH vj2pjQJ0/ARR+4hFBwgmIqnK3K86fYTxNkAK9cIIwPBJxE4yTze330HP+M3UzivHIhTDUYtAoQwc/ CHW/gXy0ilblmxBKnJfXNa1xuloO0jd6Sx+SV21PVYsv/k7TW1rR/8N5cUZC2GtSy5LY=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSxXr-0000cG-CE; Thu, 15 Oct 2020 09:19:30 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEU3MzBXU1C2tbP/ //95ocZ/AAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QKDwYsGH0CdIkAAAFgSURBVCjPLdA9buQwDAXg J0DcWgbILXKEPYUEWE0qCSCbnCCZU6WYGWR8yjzZW8jQJ4o/MqSUil6/XsftgVRU0OrbcdxeSE7U Yc/j8YC5SKsjy/G8Q5TYS/57PF/oQbhCj9sdfYoNN4x/x31FrDBS/xyfZyQYQfr4giSzWRfePyGi WlCI/oOcVSsqMb6h2X0/USu2MkZOINJA3+bkJoMTIs/WgKzIialdvGaWU95NYhwMA4WYZtsoTK6Z zdQC4wSwq3odwkYM+Bg91f8o3KdqxJpiziLg1KgJqU02t8ZaCa3XLDmCEHTCLhjEKqsvFEIu7BeG OBHszGvbhf1EhHMfwv/VI/ra87vQL4xQokXMk4oUrfHULTZH3VrriccyCWszEtMSSzsniEYMTu0Z vG9rBEXMqemEC0JXvq3qBBslzySfPtvqwdWtY8xtjeJcgWJs4n4Ozmo7c6de8M7TaetRv+wpcBEf kEYOAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTEwLTE1VDA2OjQ0OjI0KzAwOjAwO7lkqgAAACV0 RVh0ZGF0ZTptb2RpZnkAMjAyMC0xMC0xNVQwNjo0NDoyNCswMDowMErk3BYAAAAASUVORK5CYII= X-Now-Playing: Hookworms's _Hookworms_: "Deu" In-Reply-To: <874kmwy7k8.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 14 Oct 2020 22:30:55 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190546 Archived-At: Juri Linkov writes: >> Is there a different variable that should be used instead? > > I can't find another variable. Maybe a new variable should be created, > with a name like next-error-current. Re-reading the code, we don't really need the variable at all. The call to the highlighting function has been moved into the C-x ` command, after all, so we already know what buffer to use, and where point is. So I've now changed this to just highlight the current line in the "error buffer", which seems to work fine in the couple of use cases I tried. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no