unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 41624@debbugs.gnu.org
Subject: bug#41624: 28.0.50; wdired-change-to-wdired-mode sometimes infloops
Date: Fri, 23 Oct 2020 13:38:06 +0200	[thread overview]
Message-ID: <878sbxi34x.fsf@web.de> (raw)
In-Reply-To: <87imb1gpar.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 23 Oct 2020 13:22:20 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> > I can't answer that, but I can tell that when I manually delete the last
> > lines of text and whitespace in such a buffer (saying "find finished
> > ..."), it works as expected (though I'm getting a message saying that "1
> > rename actions failed").  But I'm definitely able to change permissions
> > with wdired then.  So it seems possible to make the feature work, the
> > infloop results from the unsuitable termination condition of the loop in
> > `wdired-preprocess-perms'.
>
> If even renaming doesn't work, then it does sound like this was never
> supposed to be a command that's applicable to dired-find buffers, I
> think?

I didn't say renaming doesn't work, I only got that inappropriate
message.  Maybe just because I had edited the buffer by hand to make the
loop terminate.

I'm not convinced that this is not an intended use case. - on the
contrary.  Everything works, basically, it just seems that some details
in the code are not prepared for some things that are slightly
different, e.g. the final line in those buffers.

Please don't just signal an error unless you are really sure that this
never worked and was never intended to work, and is not easy to fix.

Regards,

Michael.





  reply	other threads:[~2020-10-23 11:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31  4:47 bug#41624: 28.0.50; wdired-change-to-wdired-mode sometimes infloops Michael Heerdegen
2020-10-22 13:43 ` Lars Ingebrigtsen
2020-10-23 10:03   ` Michael Heerdegen
2020-10-23 11:22     ` Lars Ingebrigtsen
2020-10-23 11:38       ` Michael Heerdegen [this message]
2020-10-23 12:17         ` Michael Heerdegen
2020-10-23 13:18           ` Michael Heerdegen
2020-10-24 19:46           ` Lars Ingebrigtsen
2020-10-31 14:43             ` Michael Heerdegen
2020-10-23 11:15   ` Stefan Kangas
2020-10-23 11:22     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sbxi34x.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=41624@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).