From: haj@posteo.de (Harald Jörg)
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 19709@debbugs.gnu.org
Subject: bug#19709: [PATCH] Verify that indentation works with current cperl-mode
Date: Mon, 09 Nov 2020 17:06:06 +0100 [thread overview]
Message-ID: <878sbah5w1.fsf@hajtower> (raw)
In-Reply-To: <87d00mmwp3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 09 Nov 2020 15:28:08 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> [...]
> Thanks; applied to Emacs 28. One note:
>
>> + (while (null (eobp))
>> + (cperl-indent-command)
>> + (next-line))
>
> Is this on purpose to test `next-line'? If it is, this warning should
> probably be inhibited:
>
> lisp/progmodes/cperl-mode-tests.el:284:16: Warning: ‘next-line’ is for
> interactive use only; use ‘forward-line’ instead.
Nah - that's still me fighting with Emacs Lisp vocabulary. Sorry for
that. I'll replace it with (forward-line 1).
I should submit a patch anyway since I've found that the usage of
setq-local for a list of variables isn't available in Emacs 26, and I
want to run the tests in that version, too.
--
Thanks for reminding me,
haj
next prev parent reply other threads:[~2020-11-09 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 7:30 bug#19709: Problem with indentation for the closing parenthesis in cperl-mode version 6.1 Håkon Hægland
2019-07-05 20:14 ` Stefan Kangas
2020-11-04 20:01 ` bug#19709: [PATCH] Verify that indentation works with current cperl-mode Harald Jörg
2020-11-09 14:28 ` Lars Ingebrigtsen
2020-11-09 16:06 ` Harald Jörg [this message]
2020-11-10 13:56 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sbah5w1.fsf@hajtower \
--to=haj@posteo.de \
--cc=19709@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).