From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#44629: 28.0.50; Eglot noisy with gfm-view-mode and view-read-only Date: Thu, 03 Dec 2020 15:26:23 +0000 Message-ID: <878saeq5b4.fsf@tcd.ie> References: <875z68p5mr.fsf@tcd.ie> <87v9e8i3yz.fsf@tcd.ie> <838sb4w3i7.fsf@gnu.org> <87zh3ifjrq.fsf@mail.linkov.net> <87tutqi8yv.fsf@tcd.ie> <87pn4b68p1.fsf@tcd.ie> <871rgch2kv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13267"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 44629-done@debbugs.gnu.org, Juri Linkov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 03 16:27:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkqVk-0003LF-JE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Dec 2020 16:27:12 +0100 Original-Received: from localhost ([::1]:39328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkqVj-0000tY-KS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Dec 2020 10:27:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkqVb-0000tN-Oa for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 10:27:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58101) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kkqVb-0002GV-H7 for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 10:27:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kkqVb-0004bU-EE for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 10:27:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Dec 2020 15:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44629 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 44629-done@debbugs.gnu.org id=D44629.160700919617636 (code D ref 44629); Thu, 03 Dec 2020 15:27:03 +0000 Original-Received: (at 44629-done) by debbugs.gnu.org; 3 Dec 2020 15:26:36 +0000 Original-Received: from localhost ([127.0.0.1]:41409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkqVA-0004aO-9p for submit@debbugs.gnu.org; Thu, 03 Dec 2020 10:26:36 -0500 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:35934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkqV5-0004Zk-Qe for 44629-done@debbugs.gnu.org; Thu, 03 Dec 2020 10:26:32 -0500 Original-Received: by mail-wr1-f51.google.com with SMTP id z7so2278000wrn.3 for <44629-done@debbugs.gnu.org>; Thu, 03 Dec 2020 07:26:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/CwBqbAyngRywQrmqeZ6kl5Juu2jGeDT9aEQZUTOAs4=; b=Jmt6CjcilboC3firHrfUqojhdCJYhnU4X4JZMaA7UH6g83bg5o+CbybLYyQMjcFqby 0l/lI98FDnIt0a85HdWp1WD49WKV1Zuw8rrnIN+8NxanTI23opmOWNMNfvmSDnuwgs9b Crcue4ZomeRwURA7IDcS/Vui8c900Ev06t+mN+xnp/k4zZjt+fGsAdQpi1Dskg8xjrnW SdwYUI0ar4M03wJL8bACUiuxNEorW4xiT/nekmuu3A4oTF/JcCF5Gz3wG8KgsssxtD4A 6HNdpQ7Oq36f+6ZNDFNwT2NV34tza1a1YovB3my8euNWc0zuG1eHpJFl03Nddyoznf7A EF1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/CwBqbAyngRywQrmqeZ6kl5Juu2jGeDT9aEQZUTOAs4=; b=k8iWqBlNimISEtV4kf1gTXDtpknPshxxg/QuZ7PmV+jacvYl0Zwq1Uv2wG50IHuw2f qTkJTVPU9eVF3SqtA1170k0Y1quyBLCNDJu3GmiJqPWjpehRHO65mJpUHy3Ayj2CrTUH Bf3X4qsuaTHi1lrhPUmgw4GSbK2qOtNbP8/pkJcbIeDXO3TBjVdCK8JWCcU7UEvGHeI+ PxzdeCcJ2oU3SBkZXxD8schewY12aEimvtwnmtUOYbFK278zcthWCthgpZyeylf+h0qq ZoyU8K+6N7dxDw3eY8xX5XPsfSfHJb1yfQ9yZqXPQ8sqAdeT9axo7qDyiD/R86hXfdfJ iY2g== X-Gm-Message-State: AOAM533Ix5yR6YxzELzHyjJx2l8E83qIPE5UfyliP7h+YIrgZNya1Y0u iZue8MJkmzaJonvskoqaKR7GAg== X-Google-Smtp-Source: ABdhPJznVvAcAgdTjrWiSSixryl/5qlYus/2sMH/AF+9C+hDqQ0bXHBR7yd8JiSa0Yysmxct/zN3ng== X-Received: by 2002:adf:f110:: with SMTP id r16mr4323232wro.350.1607009185910; Thu, 03 Dec 2020 07:26:25 -0800 (PST) Original-Received: from localhost ([51.37.121.192]) by smtp.gmail.com with ESMTPSA id g78sm1871403wme.33.2020.12.03.07.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 07:26:24 -0800 (PST) In-Reply-To: <871rgch2kv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 29 Nov 2020 11:36:32 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194910 Archived-At: tags 44629 fixed close 44629 28.1 quit Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> How's the attached patch for view.el and jsonrpc.el? > > [...] > >> By default, entering view-mode echoes a usage message. This is >> particularly helpful with non-nil view-read-only, to notify the user >> that view-mode has been enabled. It is less useful and more spammy, >> however, if view-mode is (possibly inadvertently) entered from some >> non-interactive code running in the background, such as when a major >> mode is enabled in a temporary buffer for text formatting >> purposes (bug#44629). > > I've only skimmed the code, but this makes sense to me. Thanks, now pushed to master. Avoid spamming view-mode-enter help message 805d82197f 2020-12-03 15:22:00 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=805d82197f050d1aba8fb796e604c55ce3d6333a -- Basil