From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#46056: hardcoded ~/.emacs.d in elpa package excorporate Date: Sat, 23 Jan 2021 22:31:13 +0000 Message-ID: <878s8jz3ny.fsf@tcd.ie> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29124"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Thomas Fitzsimmons , 46056@debbugs.gnu.org To: Gunnar Horrigmo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 23 23:32:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3RS6-0007SL-Eg for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 23:32:18 +0100 Original-Received: from localhost ([::1]:43816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3RS4-0000aS-W5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 17:32:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3RRt-0000aJ-J0 for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 17:32:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52236) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3RRq-00081e-09 for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 17:32:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3RRp-0007dA-Sx for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 17:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jan 2021 22:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46056 X-GNU-PR-Package: emacs Original-Received: via spool by 46056-submit@debbugs.gnu.org id=B46056.161144108529258 (code B ref 46056); Sat, 23 Jan 2021 22:32:01 +0000 Original-Received: (at 46056) by debbugs.gnu.org; 23 Jan 2021 22:31:25 +0000 Original-Received: from localhost ([127.0.0.1]:35549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3RRE-0007bq-Ox for submit@debbugs.gnu.org; Sat, 23 Jan 2021 17:31:24 -0500 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:55061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3RRB-0007bb-P7 for 46056@debbugs.gnu.org; Sat, 23 Jan 2021 17:31:22 -0500 Original-Received: by mail-wm1-f46.google.com with SMTP id u14so708615wml.4 for <46056@debbugs.gnu.org>; Sat, 23 Jan 2021 14:31:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LnMUvOpKJ1RoV167HTDWM0feeIfL9Fo3ymjOmW4f2d0=; b=hTRzwdPLZ2frhXTXYZw8OLhLt4Pa9OtNJAVufN20kMpT1B+C+/W8KaFIr997Q8RiUn dvH4P4ptYnfo+tKiLEYhBZcIwmjvo7yfd6JOF18h7ekgsI/i/jZmYifRFQDbhcls+LTb mwJWyX0qMsT/vLG0LH3HpvmDELzRLTAhMlr9atjV9se8JiBt28zYwVpjP83AQBY2T5Fi Fonz91rxDn5rPkQlHkd1d9kgdAPru8m+BPpWyWtZ3yucCiYdsdGFkhNSIkPElbca0nn1 6Yp1Zx0+oGe3fJqxJi6kfaTBQXyXw5XL29UKDVgjVDezxQelQSfcqlA+UMYPWP2y7A99 wkZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LnMUvOpKJ1RoV167HTDWM0feeIfL9Fo3ymjOmW4f2d0=; b=PFPdqJJPjYN401rYmjLu0BLvobGdRCUBQJzIa2tOb5JrXLX0YjVuqXYU12HTfnk3pt c2iuR3D6a3kXGIHfskv9svTuyM+cHFN+TpwB/Kxg40FLl5vCdIvLzQtYWx5oBrrWguFB /vSEGRvM48SLlxBPHUA3q3ry+qwFeDR7BAEFZxIWYf8LRuLMt67tO8hiURSldBoPjXVc uwUuE5422rjkFm299d3s0FMtKgpfq5qN3ceCqPbc3M5qsaYtGcnDSPTX4FHk0vla+u/Q f4RiDIzXEoELCUkIClDiSlPpTfrkfwvZJZUVWewtRs20Ud5ad8220utyzhRhtOqm8Ylw yjsg== X-Gm-Message-State: AOAM530Rg1p5rfC25dyAa8+kRzUibFAULysvJalGJkupLn4NX8+c3P4C kmRM6R+FRPHCICZz2zlwiLZe8A== X-Google-Smtp-Source: ABdhPJxdFB2ZUEsLbSJC4AoxX5Rt5lxvuPbLoB3jkILSCqLfuVMJqiVYOYfXda8mxFjmbf81yyyMrA== X-Received: by 2002:a1c:a957:: with SMTP id s84mr75471wme.166.1611441075778; Sat, 23 Jan 2021 14:31:15 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id m11sm8985960wmc.15.2021.01.23.14.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jan 2021 14:31:14 -0800 (PST) In-Reply-To: (Gunnar Horrigmo's message of "Sat, 23 Jan 2021 19:13:44 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198479 Archived-At: Gunnar Horrigmo writes: > The `excorporate' package hardcodes its diary files to > ~/.emacs.d/excorporate, instead of honoring user-emacs-directory. Right. CCing Thomas, the package's maintainer. > I've included a small fix: > > === begin diff === > > diff --git a/excorporate-diary.el b/excorporate-diary.el > index 833df3017c..b147bed42d 100644 > --- a/excorporate-diary.el > +++ b/excorporate-diary.el > @@ -76,13 +76,17 @@ respectively." > #'exco-diary-icalendar--add-diary-entry-around)) > > (defvar excorporate-diary-today-file > - "~/.emacs.d/excorporate/diary-excorporate-today" > + (concat > + (file-name-as-directory user-emacs-directory) > + "excorporate/diary-excorporate-today") Rather than concatenating file names as strings, better to use locate-user-emacs-file in this case (or expand-file-name in general). See (info "(elisp) Standard File Names"). [...] > Am I submitting this the right way? Ideally the patch would include a ChangeLog-style commit message referencing this bug number; see the guidelines in the CONTRIBUTE file[1] at the top of the Emacs source tree. Otherwise looks fine :). [1]: https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE Thanks, -- Basil