From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#40948: 26.3; Docstring of substitute-env-vars Date: Thu, 28 Jan 2021 07:39:06 +0100 Message-ID: <878s8d36r9.fsf@gnus.org> References: <83lfmezgqk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2666"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , 40948@debbugs.gnu.org, Marcus Harnisch To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 28 07:51:42 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l519a-0000ac-Db for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jan 2021 07:51:42 +0100 Original-Received: from localhost ([::1]:48774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l519Z-000733-C1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jan 2021 01:51:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l50yL-0007HD-9Z for bug-gnu-emacs@gnu.org; Thu, 28 Jan 2021 01:40:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35344) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l50yI-0003y9-7W for bug-gnu-emacs@gnu.org; Thu, 28 Jan 2021 01:40:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l50yI-0002qh-4w for bug-gnu-emacs@gnu.org; Thu, 28 Jan 2021 01:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Jan 2021 06:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40948 X-GNU-PR-Package: emacs Original-Received: via spool by 40948-submit@debbugs.gnu.org id=B40948.161181595810880 (code B ref 40948); Thu, 28 Jan 2021 06:40:02 +0000 Original-Received: (at 40948) by debbugs.gnu.org; 28 Jan 2021 06:39:18 +0000 Original-Received: from localhost ([127.0.0.1]:46887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l50xa-0002pQ-3V for submit@debbugs.gnu.org; Thu, 28 Jan 2021 01:39:18 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:58814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l50xY-0002p9-8s for 40948@debbugs.gnu.org; Thu, 28 Jan 2021 01:39:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Rb1CoQ/7xhiKkVL7m7KnDqxyVZA7fLlNslGXDw/jvfE=; b=m3EXOaDYjxfC9ascY3YFUN+fFg S8umvZxzXefeJahn7Ss4d/kHSCI6oVTGjGLb8G6njkoGy4xit1zJMlShzov6okUGXtjeRtJSP4r8p 241m77AG5f/bcOri7GvF8VWUAc12YhtLbfsZK9NsBLMBbNzxhZ07xFeYBBU6bf6OG42g=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l50xP-0005CB-9C; Thu, 28 Jan 2021 07:39:09 +0100 X-Now-Playing: A Certain Ratio's _acr:box (1)_: "Kether Hot Knives (Mix in Special)" In-Reply-To: <83lfmezgqk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 Apr 2020 14:14:11 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198753 Archived-At: Eli Zaretskii writes: > I modified the doc string to match the argument name. (I'm not sure > how to judge which one is correct, because IMO neither WHEN-DEFINED > nor WHEN-UNDEFINED is correct. I would call that argument > HANDLE-UNDEFINED or something to that effect.) > > Also note that there's an inconsistency in how the value of this > variable is used: if it's a function, then the return value of nil > means leave the variable reference unchanged, but if it is not a > function, the value of nil means to replace the reference with an > empty string, and a non-nil value means leave it unchanged. The interface seems odd indeed, but your changes to the doc string has now made it match what it's doing (I think), so there doesn't seem to be anything more to be done in this bug report, and I'm closing it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no