From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22763@debbugs.gnu.org, Keith David Bershatsky <esq@lawlist.com>
Subject: bug#22763: 25.1.50; Feature Request -- A faster method to obtain line number at position.
Date: Sun, 07 Feb 2021 16:07:21 +0100 [thread overview]
Message-ID: <878s7z532u.fsf@gnus.org> (raw)
In-Reply-To: <83y4aclofm.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 Feb 2016 18:06:37 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> My suggestion is instead to expose display_count_lines to Lisp via a
> simple wrapper (that would need to take care of narrowing and such
> likes, something that your proposed API doesn't do, btw).
I've now added this to Emacs 28 -- line-number-at-position. In my
tests, it makes `count-lines' about 2x faster than the previous
implementation.
Now, there's a function called `line-number-at-pos' in simple.el (that
I've amended to use `line-number-at-position', so it's even faster), and
it has almost exactly the signature that the new function has. But it
has the POS parameter optional, and it has an ABSOLUTE parameter.
I didn't actually discover it before I had finished writing the new
function, so I think I'll just extend the new function to have the same
signature, and then remove the simple.el function.
Unless somebody else has a different opinion in the next ten minutes...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-02-07 15:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 2:42 bug#22763: 25.1.50; Feature Request -- A faster method to obtain line number at position Keith David Bershatsky
2016-02-22 16:06 ` Eli Zaretskii
2021-02-07 15:07 ` Lars Ingebrigtsen [this message]
2021-02-07 15:44 ` Lars Ingebrigtsen
2021-02-07 16:07 ` Lars Ingebrigtsen
2021-02-07 17:40 ` Stefan Monnier
2021-02-07 17:45 ` Lars Ingebrigtsen
2021-02-07 18:07 ` Lars Ingebrigtsen
2021-02-07 18:09 ` Eli Zaretskii
2021-02-07 18:14 ` Lars Ingebrigtsen
2021-02-07 18:23 ` Lars Ingebrigtsen
2021-02-07 19:02 ` Eli Zaretskii
2021-02-07 19:06 ` Eli Zaretskii
2021-02-07 19:25 ` Lars Ingebrigtsen
2021-02-07 19:34 ` Lars Ingebrigtsen
2021-02-07 19:43 ` Eli Zaretskii
2021-02-07 19:42 ` Eli Zaretskii
2021-02-07 19:46 ` Lars Ingebrigtsen
2021-02-07 19:52 ` Eli Zaretskii
2021-02-07 21:52 ` Lars Ingebrigtsen
2021-02-07 21:58 ` Lars Ingebrigtsen
2021-02-08 3:34 ` Eli Zaretskii
2021-02-07 22:09 ` Philipp
2021-02-07 20:37 ` Stefan Monnier
2021-02-07 20:42 ` Lars Ingebrigtsen
2021-02-07 20:50 ` Eli Zaretskii
2021-02-07 21:36 ` Lars Ingebrigtsen
2021-02-08 15:04 ` Eli Zaretskii
2021-02-09 2:17 ` Katsumi Yamaoka
2021-02-09 7:13 ` Lars Ingebrigtsen
2021-05-19 23:55 ` Ben Levy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-20 6:45 ` Eli Zaretskii
2021-05-20 7:27 ` Andreas Schwab
2021-05-20 7:35 ` Ben Levy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-20 9:08 ` Eli Zaretskii
2021-05-20 9:03 ` Eli Zaretskii
2021-05-20 19:53 ` Ben Levy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-20 20:09 ` Eli Zaretskii
2021-05-20 20:40 ` Ben Levy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-21 5:46 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s7z532u.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=22763@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=esq@lawlist.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).