From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Date: Tue, 09 Mar 2021 15:54:55 +0000 Message-ID: <878s6wqq40.fsf@tcd.ie> References: <87y2f0fq8v.fsf@protesilaos.com> <87sg58tkg7.fsf@tcd.ie> <87h7lofe6b.fsf@protesilaos.com> <87mtvfpgf2.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11317"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46964@debbugs.gnu.org, Stefan Monnier To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 09 17:39:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJfO0-0002rL-Gt for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 17:39:08 +0100 Original-Received: from localhost ([::1]:38712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJfNz-0007NP-FG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 11:39:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJeiI-0007md-9E for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 10:56:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJeiH-0002OL-Vo for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 10:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJeiH-0000EH-Vl for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 10:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Mar 2021 15:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46964-submit@debbugs.gnu.org id=B46964.1615305309816 (code B ref 46964); Tue, 09 Mar 2021 15:56:01 +0000 Original-Received: (at 46964) by debbugs.gnu.org; 9 Mar 2021 15:55:09 +0000 Original-Received: from localhost ([127.0.0.1]:47759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJehQ-0000D5-SD for submit@debbugs.gnu.org; Tue, 09 Mar 2021 10:55:09 -0500 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:46756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJehL-0000CS-EJ for 46964@debbugs.gnu.org; Tue, 09 Mar 2021 10:55:07 -0500 Original-Received: by mail-wr1-f46.google.com with SMTP id a18so16571330wrc.13 for <46964@debbugs.gnu.org>; Tue, 09 Mar 2021 07:55:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OYcZo8LIkKsor1O0D/eWdbjPDKtCGGUiRlyKm0ol7Jw=; b=bO7yFfo8R4vQPMHclpH0UgKZsy8q3EVdgcEHMN92QXaweHTwe9KZa3xv5X0oewOH50 D+XIQ/c7qX0IvGw1jHB3eBmC8uYnomY4ZD2N0EXEtwwtV0Hi7L2hf1HrCVPeKSjZ6w0+ S+kFA8L5yHlFZRvFsb7lveh4xozqVYlr29fAnChQKPs1+71JQyxqtFRvP8gZn1I+hJCY n2Ix6UA9qiEDpYhVOOF1Xu2/M6qpvv9iP/m1Z7PyHpmCA46mSV8cbPeQouE3U+WaINT0 niGG7qfPN5f2gDdFRgcoIbbWvVO0lEpyBpeO1y4LTO4AAWjZ22NBP2mYq+rudWRnmB8L L1YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OYcZo8LIkKsor1O0D/eWdbjPDKtCGGUiRlyKm0ol7Jw=; b=Tq8aLxTNZNbf7sZT9CPlLoyNCay9403+DOYUQPY3VisahpStItyd72jFAg7E8ZBzfO 51T+qnYye7+XjMRFUHrkEU48NVne2BA4FLs6rWYsXXhhHk/MZ7632FeM1Wv3QPhQC84O Px2duD9/Q1ux7tMFNjkdOE9WmY+mlFYp/BKPZXhfoI4hjP+0DX1dpUXps8l51MBnewnl CpVbaVA0KrYsj7u9fgGJU+nhLFKOtV4aIC9hdJ8s4DlpCtx226TtkvttqBL3Kwbm6crv QqYu+dbSIVKc3ThhiaawxnF0hQuZhfbk6L+rrODiUDzqqgSSJPCLpMHAGJS/NsqarANR 5Kxw== X-Gm-Message-State: AOAM530of6zV6L9lg0o+S33308BwZP5VBaSFR+hvcXahJzTg49oEyK6x c447cV63HlY9PjhwT+wolOusuw== X-Google-Smtp-Source: ABdhPJw9iHnRCYNYdMz7d8MylWzi4MtB+NH7FYxh19rvIaHuDhxT0IAtlI+uJPwPOC2e2YmZOrvpGQ== X-Received: by 2002:adf:fac1:: with SMTP id a1mr29764379wrs.98.1615305297554; Tue, 09 Mar 2021 07:54:57 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id p12sm3057874wrx.28.2021.03.09.07.54.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 07:54:56 -0800 (PST) In-Reply-To: <87mtvfpgf2.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sun, 07 Mar 2021 09:32:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201918 Archived-At: Protesilaos Stavrou writes: > Thank you! I have amended the patch using the format you recommended. Thanks, LGTM. Have you been able to verify that the tarball is created properly, and especially that the contained .info file is nonempty? Because locally I get either errors or empty .info files when I try 'make packages/modus-themes' or 'make build/modus-themes', regardless of sandboxing. I'm guessing full deployments don't suffer the same? > --- a/elpa-packages > +++ b/elpa-packages > @@ -208,8 +208,12 @@ > ("mmm-mode" > :url "https://github.com/purcell/mmm-mode.git" > :auto-sync t) > - ("modus-operandi-theme":url "https://gitlab.com/protesilaos/modus-themes") > - ("modus-vivendi-theme" :url "https://gitlab.com/protesilaos/modus-themes") Also wondering if we need to do anything special before "ripping off this bandaid"[1], or can we also get away with the money like MELPA? [1]: https://github.com/melpa/melpa/issues/7245 Thanks, -- Basil