From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47581: 27.1; tab-bar missed mouse clicks on MS-Windows Date: Mon, 12 Apr 2021 00:53:45 +0300 Organization: LINKOV.NET Message-ID: <878s5oebu6.fsf@mail.linkov.net> References: <83pmzbeajw.fsf@gnu.org> <87mtudac4g.fsf@mail.linkov.net> <83h7kd41no.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38561"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: ioannis.kappas@gmail.com, 47581@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 12 00:36:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVigs-0009wa-M7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Apr 2021 00:36:26 +0200 Original-Received: from localhost ([::1]:43720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVigp-0002MC-W2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Apr 2021 18:36:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVieY-0000Hq-PN for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 18:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVieY-0004Ie-I4 for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 18:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVieY-0003Lz-FL for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 18:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Apr 2021 22:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47581 X-GNU-PR-Package: emacs Original-Received: via spool by 47581-submit@debbugs.gnu.org id=B47581.161818040412823 (code B ref 47581); Sun, 11 Apr 2021 22:34:02 +0000 Original-Received: (at 47581) by debbugs.gnu.org; 11 Apr 2021 22:33:24 +0000 Original-Received: from localhost ([127.0.0.1]:56005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVidw-0003Kl-7J for submit@debbugs.gnu.org; Sun, 11 Apr 2021 18:33:24 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:41679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVidu-0003KW-S5 for 47581@debbugs.gnu.org; Sun, 11 Apr 2021 18:33:23 -0400 X-Originating-IP: 91.129.96.157 Original-Received: from mail.gandi.net (m91-129-96-157.cust.tele2.ee [91.129.96.157]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 1DA0A40006; Sun, 11 Apr 2021 22:33:15 +0000 (UTC) In-Reply-To: <83h7kd41no.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Apr 2021 12:21:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203867 Archived-At: >> Indeed, this code was copied from handle_tool_bar_click, >> but this extra logic was not removed because there are parts >> of the tab bar that should respond to moving the mouse pointer, >> namely the tab close buttons are activated when the mouse pointer >> is moved over them. But I'm not sure if this feature is related >> to this code, or won't be affected by removing this code. > > OK, I've fixed handle_tab_bar_click to not pay attention to > mouse-highlight, please see if there are any adverse side effects of > that change. > > I also removed note_tab_bar_highlight and the code which called it. I > couldn't find any place which depended on that, and there was no > visible effect of mouse-highlight on any part of the tab-bar buttons > that I could see. If I missed something, please show a recipe where > this highlight had any effect before my changes. Sorry, I don't understand the need to remove the highlighting code. Before the removal, the tab-bar button images reacted to mouse pointer movements, and highlighted the buttons under the mouse pointer using the pressed/released state DRAW_IMAGE_SUNKEN/RAISED. Now there is no visual feedback when the user moves the mouse pointer over the buttons. Doesn't seem like an improvement. > (It _is_ possible to have the tab-bar buttons react to mouse pointer > movements, but for that we need support in display code, which isn't > there. If we will ever want to add mouse sensitivity to tab-bar > buttons, we should first add code which displays those buttons > differently when the draw_glyphs_face value is DRAW_MOUSE_FACE or > DRAW_IMAGE_SUNKEN/RAISED; then we'd want to resurrect > note_tab_bar_highlight that I deleted.) Looks like a plan to re-add the same feature, but differently.