From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 15/15] Add and use BVAR_FIELD macros Date: Sat, 08 May 2021 13:13:42 -0400 Message-ID: <878s4pp2rd.fsf@catern.com> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-16-sbaugh@catern.com> <835yzudcvz.fsf@gnu.org> <87o8dmr96v.fsf@catern.com> <83tunebsiu.fsf@gnu.org> <87mtt6p6co.fsf@catern.com> <83sg2xaf4l.fsf@gnu.org> <87czu1pcv0.fsf@catern.com> <83a6p59vk6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20002"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Eli Zaretskii , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 08 19:14:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfQWo-00054K-4S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 May 2021 19:14:10 +0200 Original-Received: from localhost ([::1]:43942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfQWm-0003hv-HN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 May 2021 13:14:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfQWf-0003c0-VW for bug-gnu-emacs@gnu.org; Sat, 08 May 2021 13:14:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lfQWf-0004HI-OI for bug-gnu-emacs@gnu.org; Sat, 08 May 2021 13:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lfQWf-0003Kq-J4 for bug-gnu-emacs@gnu.org; Sat, 08 May 2021 13:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 May 2021 17:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162049402812807 (code B ref 48264); Sat, 08 May 2021 17:14:01 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 8 May 2021 17:13:48 +0000 Original-Received: from localhost ([127.0.0.1]:51276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfQWS-0003KV-4M for submit@debbugs.gnu.org; Sat, 08 May 2021 13:13:48 -0400 Original-Received: from venus.catern.com ([68.183.49.163]:37404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfQWO-0003KP-AZ for 48264@debbugs.gnu.org; Sat, 08 May 2021 13:13:46 -0400 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1620494023; bh=Htc4wMj8GirGEBAjyYd2rq/0rKSmBYN6DQdmesMjyfo=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=FQRFa8PdcxoeonGt5LFxzb6tPxj9ftZ7Z4jmLDNAfUwIfKeyUHI17Ob/YnZw2vydv twk+nCRFcJ0+rOUO1O+c6nI2Vt6vqfiFpxWNZXjijYcjEidQztdy1qd7dklOMrWWyb 6dlHyWx+CUXP/H+YskXK3iA7Lsfzx1EtUghEcL2M= Original-Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id E170F2E9869; Sat, 8 May 2021 17:13:42 +0000 (UTC) In-Reply-To: <83a6p59vk6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206023 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: 48264@debbugs.gnu.org >> Date: Sat, 08 May 2021 09:35:31 -0400 >> >> Keep in mind though, this name isn't exposed to the programmer >> >> anywhere - it might as well be _ABCDEFGHI_, nothing will change >> >> outside the definition of the BVAR_DEFAULTED_FIELD macro. >> > >> > See above: I'd prefer to get rid of the macro for this purpose. >> >> Sure, we could mostly get rid of it, although it's important that the >> argument to BVAR_OR_DEFAULT be "case_fold_search" rather than, say, >> "case_fold_search_def", even if the field is named the latter. >> Otherwise one might accidentally call BVAR with "case_fold_search_def", >> which would compile but behave wrong at runtime - and preventing that is >> the whole point of the different names. > > I agree, but I'm not sure I see the connection. Can you tell how > getting rid of the macro in the likes of b->SOME_MACRO(foo) could run > afoul of the argument to BVAR_OR_DEFAULT? Just wanted to make sure we were on the same page. I don't think getting rid of the macro in b->SOME_MACRO(foo) will run afoul of the argument to BVAR_OR_DEFAULT.