From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45328: 28.0.50; [PATCH] Compare raw syntax descriptors with equal in `python-indent-region' Date: Mon, 17 May 2021 17:06:03 +0200 Message-ID: <878s4djt7o.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24859"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45328@debbugs.gnu.org, Stefan Kangas To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 17 17:07:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liepx-0006EC-Hd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 May 2021 17:07:17 +0200 Original-Received: from localhost ([::1]:52618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liepw-0006RC-G1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 May 2021 11:07:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liepm-0006IE-O3 for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 11:07:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41956) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1liepi-0006vg-5t for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 11:07:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lieph-0000A4-W8 for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 11:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 May 2021 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45328-submit@debbugs.gnu.org id=B45328.1621263984568 (code B ref 45328); Mon, 17 May 2021 15:07:01 +0000 Original-Received: (at 45328) by debbugs.gnu.org; 17 May 2021 15:06:24 +0000 Original-Received: from localhost ([127.0.0.1]:53500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liep2-00008u-8a for submit@debbugs.gnu.org; Mon, 17 May 2021 11:06:24 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lieox-00008Z-HI for 45328@debbugs.gnu.org; Mon, 17 May 2021 11:06:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HycGSqQ9/DXldlltE1jR8C3B2O8p4b7e7gbpnaLITG0=; b=cH0eXJkA/AVvSuU1Nae3YEzD3k OJZib7Ert5t6zXDgQqRJy2RlJbI9sfE/O2GGQARy0wsgOsBAapZYyud6VrOapbiN1uk4OqEStcHHa rFonpq0Zi0gbC14494RTLJEVFDTQ9kWTqvZPnguSrnh6cSagXv8MXVtl1GUMmMciXw7U=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lieom-0000iw-Ad; Mon, 17 May 2021 17:06:06 +0200 X-Now-Playing: d'Eon's _LP_: "I Don't Want To Know" In-Reply-To: (Andrea Corallo's message of "Sun, 21 Mar 2021 21:19:33 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206717 Archived-At: Andrea Corallo writes: > Uhmm, I thought the patch was correct but re-testing it this is now > breaking the `python-indent-region-5' test. > > Maybe there's a reason why we should use eq there or maybe this is > unveiling a real bug? Not sure, I guess some expert of that code should > probably have a look. The code in question is: ;; Don't mess with strings, unless it's the ;; enclosing set of quotes or a docstring. (or (not (python-syntax-context 'string)) (eq (syntax-after (+ (1- (point)) (current-indentation) (python-syntax-count-quotes (char-after) (point= )))) (string-to-syntax "|")) (python-info-docstring-p)) That `eq' form will never return anything other than nil, so removing it gives us identical results. So I'm not quite sure what it's trying to do -- it's probably meant to be `equal', but that will (as you've found out) lead to mis-indenting some code. So I've added Fabi=C3=A1n to the CCs; perhaps he has some comments. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no