From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49043: 27.1: ibuffer-toggle-filter-group [BUGFIX] Date: Wed, 16 Jun 2021 10:19:23 +0200 Message-ID: <878s3aql10.fsf@gnus.org> References: <20210615155231.75wevy3wtzu4vx7l@E15-2016.optimum.net> <87k0mvrto4.fsf@gnus.org> <20210615201851.jwnjx23qptp3agp7@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15547"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49043@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 16 10:20:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltQmS-0003oo-2y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Jun 2021 10:20:12 +0200 Original-Received: from localhost ([::1]:45834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltQmQ-0002dB-Am for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Jun 2021 04:20:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltQmI-0002cp-Cg for bug-gnu-emacs@gnu.org; Wed, 16 Jun 2021 04:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ltQmI-0004Jq-4t for bug-gnu-emacs@gnu.org; Wed, 16 Jun 2021 04:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ltQmI-00084Q-1M for bug-gnu-emacs@gnu.org; Wed, 16 Jun 2021 04:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Jun 2021 08:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49043 X-GNU-PR-Package: emacs Original-Received: via spool by 49043-submit@debbugs.gnu.org id=B49043.162383157430985 (code B ref 49043); Wed, 16 Jun 2021 08:20:01 +0000 Original-Received: (at 49043) by debbugs.gnu.org; 16 Jun 2021 08:19:34 +0000 Original-Received: from localhost ([127.0.0.1]:51505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltQlp-00083h-Qp for submit@debbugs.gnu.org; Wed, 16 Jun 2021 04:19:34 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltQlo-00083T-CC for 49043@debbugs.gnu.org; Wed, 16 Jun 2021 04:19:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IzdWvg7q5DN28ow3sQwV5gzXywCIl3ZZs83EWFgfoIg=; b=tNG8Qi/erBj/vVmH9qqZXB3mTQ 822cz8E4YVomqKXU1GbU0HDIhj9p3Hagt7k/jbjKCHt3GoNlXmMVUGogllRBlDi+KDOvGZvageVha kP+X6HPi0WxfuOwqtBwX6TbE4SJi6S9PvRok1c3QHbkv/DGerq6HyEXg4l9AikOZHExs=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltQlg-0003Hx-Dv; Wed, 16 Jun 2021 10:19:26 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEX5+e/y8NZXSkTG u5p6cGydkXQnHCkNBhD///9PiCxjAAAAAWJLR0QIht6VegAAAAd0SU1FB+UGEAgODMwisrMAAAGT SURBVDjLvZLNVsIwEIXTwwu0etR9gHQLDHXtKQG2SqmuLZzp2orJ6zuZtDQF2XoXBebrzJ0fhPh/ RYnXNbkFkkuQxMNa59JSzui5zlYXYIH1QYgR1vZ1ACKFeBIRrO7sVxSCESIaSC2ibQYgIlDX1qm5 8FAVcty8DTLESKJy8UPsRqGe+3YVV/r0M4r4POBDtXXg1E3f7+I+ZY+4HT7YEmfYF185DsATg+9w nzB3n49+jP4ymgT3MF/Ys0kPWH7yWbBwVj7xbY2BG+uBlB4cdQEkAmWndwY/AC2ATkvf1jXI2N0E YLcKMmwBSzVlsMR87QxzD4AuacYOfFgjxwAb35bJ6AXTOLA1dNi9qhs+Ff1wT86g71WNx50fhFRh 5cCzNUore8rrLq4lgyw1qHVqVAfob8elINMoJ5sGO9B5kBRWOf4FNoghoG5asENUiH18qluwRwwS KiWn3pxWXhvsHagXbldKrYIw1eKMIsulqpQr1hrTNSexy8hKreVQDpQABZT5BfHA2e+1S8v7jOSG xK3oL0Rh2UH/2mkWAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA2LTE2VDA4OjE0OjEyKzAwOjAw mwwW5gAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNi0xNlQwODoxNDoxMiswMDowMOpRrloAAAAA SUVORK5CYII= X-Now-Playing: Sebastian's _Thirst_: "Doorman (feat. Syd)" In-Reply-To: <20210615201851.jwnjx23qptp3agp7@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 15 Jun 2021 16:18:51 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208624 Archived-At: Boruch Baum writes: > Oops. I misquoted the code (because I had submitted the report after I > had made/tested/byte-compiled/over-writte my only local copy). If you look at the > code on the gnu cgit instance, at line 1907, you'll see that it adds one > to the line-end-position before passing the value the function > delete-region. Right -- so I guess the problem here is that the last line of the buffer doesn't have a newline... but skimming the code (I'm not super-familiar with ibuffer), it seems like the final non-newline line is a summary line and should be kept out of the sorting/filtering process? (If there's a "buffer line" without a newline, it'll mess up the display after filtering.) So I think that perhaps the bug is somewhere else, but it's hard to say without a recipe that reproduces the bug. Do you have a test case? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no