From: Michael Albinus <michael.albinus@gmx.de>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 49229@debbugs.gnu.org
Subject: bug#49229: 27.2; `M-x shell' fails over TRAMP from local MS Windows
Date: Fri, 02 Jul 2021 14:58:46 +0200 [thread overview]
Message-ID: <878s2ox46x.fsf@gmx.de> (raw)
In-Reply-To: <CANh=_JERewyqbKv2kzk1O1PPU0KeJupaaVvv-5a+HBJ+8wASBA@mail.gmail.com> (Jim Porter's message of "Thu, 1 Jul 2021 10:07:53 -0700")
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
Jim Porter <jporterbugs@gmail.com> writes:
Hi Jim,
> (Hopefully I don't need to do anything special to comment on a closed bug...)
No problem,
> Maybe it would be best to revert the Tramp part of this patch and do
> something similar to the patch in my original message. That would
> ensure that nothing unexpected happens as a result of
> `default-directory' being relative to the current drive. If that makes
> sense, I can put together a proper patch for the `M-x shell' part.
As I've said in my reply, I believe the problem is more general, and not
restricted to just the `shell' function.
So I have pushed a patch to master, which reverts my Tramp change, and
which adds the following change to `read-file-name-default' of minibuffer.el:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 503 bytes --]
*** /tmp/ediffZeoKgh 2021-07-02 14:52:22.462303385 +0200
--- /home/albinus/src/emacs/lisp/minibuffer.el 2021-07-02 14:50:37.716338781 +0200
***************
*** 3161,3166 ****
--- 3161,3167 ----
(unless val (error "No file name specified"))
(if (and default-filename
+ (not (file-remote-p dir))
(string-equal val (if (consp insdef) (car insdef) insdef)))
(setq val default-filename))
(setq val (substitute-in-file-name val))
[-- Attachment #3: Type: text/plain, Size: 47 bytes --]
Could you, pls, test?
Best regards, Michael.
next prev parent reply other threads:[~2021-07-02 12:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 23:05 bug#49229: 27.2; `M-x shell' fails over TRAMP from local MS Windows Jim Porter
2021-06-26 14:33 ` Michael Albinus
2021-06-26 18:01 ` Jim Porter
2021-06-27 8:41 ` Michael Albinus
2021-06-28 0:47 ` Jim Porter
2021-06-28 6:18 ` Michael Albinus
2021-07-01 17:07 ` Jim Porter
2021-07-02 12:58 ` Michael Albinus [this message]
2021-07-02 21:30 ` Jim Porter
2021-07-03 6:42 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s2ox46x.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=49229@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).