From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#21185: 25.0.50; byte-compiler warn on quote lexical var Date: Thu, 08 Jul 2021 16:12:47 +0200 Message-ID: <878s2gsxls.fsf@gnus.org> References: <86y4hre7ku.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17087"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: stephen_leake@stephe-leake.org, 21185@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 08 16:19:50 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1UsX-0004Dz-QY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jul 2021 16:19:49 +0200 Original-Received: from localhost ([::1]:41566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1UsW-0007Vk-S3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jul 2021 10:19:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Umw-0005Ef-5y for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 10:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1Umv-0003FE-R8 for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 10:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m1Umv-0000ZR-Nj for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 10:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jul 2021 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21185 X-GNU-PR-Package: emacs Original-Received: via spool by 21185-submit@debbugs.gnu.org id=B21185.16257535972133 (code B ref 21185); Thu, 08 Jul 2021 14:14:01 +0000 Original-Received: (at 21185) by debbugs.gnu.org; 8 Jul 2021 14:13:17 +0000 Original-Received: from localhost ([127.0.0.1]:57110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1Um9-0000YI-K9 for submit@debbugs.gnu.org; Thu, 08 Jul 2021 10:13:17 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:35534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1Um6-0000Xo-Rx for 21185@debbugs.gnu.org; Thu, 08 Jul 2021 10:13:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gjLixkyGK6aiipkj04UISkCzOYR/xIFpovelut5saoc=; b=CjurrfRShujWvn01l1540f2WB6 V9U4BfpY/9AZVpNMvfXjZiU7e/VNljqeTzbOFc7RfR4zSfy8AphqIVQDCboGToZKL9rzKKT/zOsAV nQ1PtQ/Ju+z4Sq+uT4lauo1vRIflFOX1+FeQngyiU8Q+yfYfIYkRd6YCz9QqWR66GJjU=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1Ulj-0003Td-Pq; Thu, 08 Jul 2021 16:12:53 +0200 X-Now-Playing: Yorkston, Thorne, Khan's _Navarasa: Nine Emotions_: "Waliyan Da Raja" In-Reply-To: (Stefan Monnier's message of "Wed, 05 Aug 2015 23:28:52 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209692 Archived-At: Stefan Monnier writes: >> I've been bitten by this problem when converting code to use lexical >> binding; it would be helpful if the byte-compiler warned about it. > > Agreed, but I haven't figured out how to make this work. > There are two problems: > 1- detect not just things like =C2=AB 'var =C2=BB but also things like = =C2=AB '(var1 > var2 var3) =C2=BB since such occur in a few places as well. > 2- don't swamp the user with false positives. > > Problem 2 is by far the biggest. It's very common to have a local > variable `face' and at the same time to use the symbol `face' (quoted), > for example. So the suggestion is to have code like (let ((foo "bar")) (when (zot 'foo) ...)) give a warning (in lexical code)? That does sound useful, especially if the `zot' here is `bound-and-true-p', which somebody was using in a different bug report the other week. But I think that Stefan is totally correct in 2) -- there will be so many false positives that it won't be useful. So I'm closing this bug report. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no