From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#12299: 24.1; no byte compiler warning for inline function call with too few arguments [PATCH] Date: Fri, 23 Jul 2021 13:09:46 +0200 Message-ID: <878s1xffr9.fsf@gnus.org> References: <743DF3D0-DA0F-49D4-A780-02C698AE8EFB@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6045"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 12299@debbugs.gnu.org, Stefan Monnier , Roland Winkler To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 23 13:10:57 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6t4z-0001Py-GH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jul 2021 13:10:57 +0200 Original-Received: from localhost ([::1]:47224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6t4y-0004Qs-Gm for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jul 2021 07:10:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6t46-00037G-ET for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 07:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6t46-0002Pn-6M for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 07:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6t45-0003Lh-SY for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 07:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jul 2021 11:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12299 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 12299-submit@debbugs.gnu.org id=B12299.162703859912861 (code B ref 12299); Fri, 23 Jul 2021 11:10:01 +0000 Original-Received: (at 12299) by debbugs.gnu.org; 23 Jul 2021 11:09:59 +0000 Original-Received: from localhost ([127.0.0.1]:42391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6t42-0003LN-Pv for submit@debbugs.gnu.org; Fri, 23 Jul 2021 07:09:59 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:37498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6t40-0003L9-UB for 12299@debbugs.gnu.org; Fri, 23 Jul 2021 07:09:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2HwwfGmmoI9xlIa3Dsori869LocDhXjSpb317Qb/X0A=; b=AI7PNCNhLx6QWAx9Dn8huB0o42 d+TOuPBK0KYV5bZR48ttQvfVUdnN5gglCIdm1loTwlWSLJdlPlh4W9u4ViyJ8e12r3zk2CvJCA/uT qryxSdgcO0YfKQ2R2mppaphPrE1PntEtsQOqMQbcpHcMIgx8sthMpep2TQ7/j6j7c7V0=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6t3r-0006j4-7O; Fri, 23 Jul 2021 13:09:49 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEX7+/vi4d3DwrzO zcuvrqu/v7mPj41gYF9PT08fHyADAwQtLS50c3N/f4D///+/Y3f8AAAAAWJLR0QOb70wTwAAAAd0 SU1FB+UHFwo6Jg+ATfUAAAFVSURBVDjLvZK/S8NAFMffkVC1ONyZULA4VPoP3BFRKA4pVAed/A/s 4hAcBDcnBxejg05KNlGa5rVDB6fg0KFT/wT/Gi+NIdh7GUTwm+Uun/f7HUClBLQsBT7ANpMud8Hl tm+daOBZfXbAfAY7rNWQLjR4zc/sQDFHf11tsfAQG8pRQgnw2h4p+GcxkStPbpSjMsazxv+iXUn/ X7l9osER4mkVuK4AdxMS7M/OaA8b7At6JHtb0/L2PR994rXZ8bsB9HCscHSZ3ojSsgg0T3oQ4tTI sI4o4QofgS+BVUwA5vhgeCzAZwn4DxDgy1ILDDZz8GqEauZgwIjZdlmKb/Q2KBAg+iwiQIiJ1B4D A0SIH+cpjimQaWgsA38LrAIU+ygW44xyYCa/zx2kAdoRJkQKsCYBDnUbfaOq5w7GAdE4HK5h3KGA XmHcJIrKnsm4TgIb43oZ6gv0cocGYVYw+wAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wNy0yM1Qx MDo1ODozOCswMDowMO6R6QgAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDctMjNUMTA6NTg6Mzgr MDA6MDCfzFG0AAAAAElFTkSuQmCC X-Now-Playing: Jane Siberry's _Jane Siberry_: "This Girl I Know" In-Reply-To: <743DF3D0-DA0F-49D4-A780-02C698AE8EFB@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Thu, 22 Jul 2021 15:14:55 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210561 Archived-At: Mattias Engdeg=C3=A5rd writes: > Would this patch do? > For some reason that I haven't investigated, the usual > warning-suppression mechanisms seem ineffective for these > warnings. I'm probably doing something wrong. Even so, it's better to > have arity checks that cannot be disabled than none at all. Yes, we can fix up suppression afterwards... > From cb9d873871eb445ad18b2a89f3c4ba7e6a4d3ef3 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D > Date: Thu, 22 Jul 2021 15:00:17 +0200 > Subject: [PATCH] Warn about arity errors in inlining calls (bug#12299) This leads to warnings like: Warning: Eager macro-expansion skipped due to cycle: =E2=80=A6 =3D> (load "byte-opt.el") =3D> (macroexpand-all (defalias 'byte= -decompile-bytecode-1 =E2=80=A6)) =3D> (macroexpand (cl-symbol-macrolet =E2= =80=A6)) =3D> (load "byte-opt.el") At least initially? A "make bootstrap" made it go away. It otherwise seems to work fine for the test example. I wondered whether this added warning would find errors in the Emacs tree, so I did a "make bootstrap" after applying the patch, but we apparently have none of those, which surprised me. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no