From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50497: [PATCH] Adding eww-{next,previous,up,top}-path. Date: Mon, 13 Sep 2021 10:03:33 +0200 Message-ID: <878s00j416.fsf@gnus.org> References: <87lf45xh86.fsf@ypei.me> <87ee9wpt38.fsf@gnus.org> <878s04ijhc.fsf@mail.linkov.net> <87czpfnw4j.fsf@gnus.org> <87pmtfx7fs.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33405"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Yuchen Pei , 50497@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 13 10:04:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPgwt-0008SS-OH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 10:04:19 +0200 Original-Received: from localhost ([::1]:33924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPgws-0002wv-Hb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 04:04:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPgwd-0002tP-Ff for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 04:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPgwd-0000VT-7p for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 04:04:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPgwd-00037v-44 for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 04:04:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Sep 2021 08:04:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50497 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50497-submit@debbugs.gnu.org id=B50497.163152022411980 (code B ref 50497); Mon, 13 Sep 2021 08:04:03 +0000 Original-Received: (at 50497) by debbugs.gnu.org; 13 Sep 2021 08:03:44 +0000 Original-Received: from localhost ([127.0.0.1]:44168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPgwK-00037A-5Q for submit@debbugs.gnu.org; Mon, 13 Sep 2021 04:03:44 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPgwI-00036x-SJ for 50497@debbugs.gnu.org; Mon, 13 Sep 2021 04:03:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UlE+2DkFwGxDe9KW0kvKGzFLgWPSf4/BDzO2EQD5Ibg=; b=uFAaZOS5cKdyHab3t1lm0wO3Ss U+cfIgTzkab8oqyflaB1bd7Qi9t/bLC65bmB5YOYYFvKH4kxI7OoYJOjxhdMdLHiy4cJ0kh5u5OJv gvXbAvNQf/NiMBbCxSmb4MqtyyEwPE1UOdHqou69w7mSxZJaLSUzricPzbUoXwvXc2wc=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPgwA-0006Kt-2e; Mon, 13 Sep 2021 10:03:36 +0200 In-Reply-To: <87pmtfx7fs.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 11 Sep 2021 22:01:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214190 Archived-At: Juri Linkov writes: >> That's also true, so I was sceptical about adding that (because it also >> makes `C-s' etc behave sub-optimally in 99.7% of web pages), so I've >> been pondering whether to remove it (or at least hide it behind and >> option defaulting to "off"). > > But users like it: > https://www.reddit.com/r/emacs/comments/9oi1e3/ewws_awesome_isearch_support_just_blew_my_mind/ Yeah, it's a neat trick (which makes people go "ooo"). So disabling it would be a shame. But it does make the user experience slightly worse most of the time... Actually, we could just tweak it -- today it says "repeat for next buffer" even if there's no next buffer (it only checks afterwards), apparently. Hm... Right, if eww only sets `multi-isearch-next-buffer-function' when there's a rel=next/prev, then this awkwardness disappears. Now done. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no