From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#50581: 27.2.50; Tramp fails to (un)compress directories Date: Mon, 20 Sep 2021 14:50:19 +0200 Message-ID: <878rzre7hw.fsf@gmx.de> References: <87o88vco8a.fsf@gmail.com> <87sfy7ov5m.fsf@gmx.de> <87wnnc7bmp.fsf@calancha-pc.dy.bbexcite.jp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13725"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: uyennhi.qm@gmail.com, 50581@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 20 14:51:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSIlp-0003MU-B4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 14:51:41 +0200 Original-Received: from localhost ([::1]:35104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSIlo-00016e-2W for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 08:51:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSIlC-00013A-5p for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 08:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57898) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSIlB-00051g-PW for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 08:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSIlB-00073T-N3 for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 08:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Sep 2021 12:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50581-submit@debbugs.gnu.org id=B50581.163214222827073 (code B ref 50581); Mon, 20 Sep 2021 12:51:01 +0000 Original-Received: (at 50581) by debbugs.gnu.org; 20 Sep 2021 12:50:28 +0000 Original-Received: from localhost ([127.0.0.1]:41211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSIke-00072b-Ix for submit@debbugs.gnu.org; Mon, 20 Sep 2021 08:50:28 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:59183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSIkd-00072K-Ba for 50581@debbugs.gnu.org; Mon, 20 Sep 2021 08:50:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1632142220; bh=BTHU/UobTi2C73EIAtsUMjLc5vlw/WT1NRVPlNB1LK8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=lo3awNPJr/ew/LcDx2ZNJ3RN5rt/Uo56Bv+raR+bUyqrHnA6B/kAb84Bi9KFTCaQb OefZZ2cLy+XGZ++/WsqyVNWsjXOuu7/ZjeCM461t5sC5NHbGvMnrT7ZXc3ZHm+yWhs w1a1FB7nJ/Z7M3sdQD9FZnTUUvaomGPWim5c9+GI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.238.85]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N0X8u-1mpLui1M6G-00wXr6; Mon, 20 Sep 2021 14:50:20 +0200 In-Reply-To: <87wnnc7bmp.fsf@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Sun, 19 Sep 2021 18:50:38 +0200") X-Provags-ID: V03:K1:fPRSKliF0RcQNkOxHSvfAC/jCnTKE+JorpqTXGqaivY0/aSsuxQ BGjDMKblawCD77tJaq6tQYNKTeoXjJ5tjy3DnaZZAeEKfGCGDSQlVl/XDszLK9qOksxWkeQ Olr8FdJieEDGu6sKfxAcAT+7D2GVg7U60O4SfUfhrnKgx0oQ3L+1Kyj1xUK3f4whjz6o7OJ NngN2OVb9K/r9MAXLk6Tw== X-UI-Out-Filterresults: notjunk:1;V03:K0:v3aaSOUOCH8=:ZyRGSZfcn57pmV2AK7KNEx vH3z17D22khTU8C28Hn2namJYTncjg/RBgJQC4fs6j5BHySNsKotaogVEbA5hOCuD/oxUWLNF jR7BoOdJoOvNEFGlBvwNeEPEAXjOkSFfeLXZ0P8ygXecCasCc5BSm/1YrWpqyrGLhiXVdu3BH TLpuA0l/wZkvvsK4zWdcK0Y3Jh1Yt0Zu3/TylULbUvvexRqHqayEzOkrgo91deDJggHGNscO6 NC2F3CY1tVuYNeYav0Xsf59m6LjDo0IU71FY//PjWAERg2snrbSs0xn9J568CSeL2M+rfGwdW CdMbWZWm7gJzglAxsd3zlLObU78RPQ+/v9/x1ur/mGbjqxEvsTiXTSM/7AKatYV1mT9tA3ylv IeYbiEA5ANqdTjAQCj/J5YSeANkyviuZlXEDvcZfYqGuuV32nKB7KLHmuGoikITLAkf0K7Ofy V8afa9UVKFqvp+xybjn8IirOfK2o3DbaZlNp5BbvwVgcGL/O+mWqpf7XWh8kI0tPOtM8hJDue vGxXjNgZtS5INT8xLbgd+HMGEsI5OHV94dVw9hUbtxQwvPW4p05A4vCW2d2xBuG+1bcdaO76I J57zPSnU2cvSs1B02xTWODuGiuaFOilFJFHjfDoDFdl88OtMKwbzBPViGOYSIlg0iNF8LFrkB QDjUsp/ukV/iM9GkLm4YaJIjxwVYyTLa7/R6Pckmoe2biJZPbq6ZEKPivsU/Uph7tcDN3nPJx bczowNWvDzmppME0QcXWeWNFio2ENkigojj1c6/mCOK1KRBWrNDrkSzxCcBYZETGG5YzI2tv X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214860 Archived-At: Tino Calancha writes: Hi Tino, >> Indeed, the directory case is not implemented in tramp-sh-handle-dired-compress-file. >> I will see how to implement it next time. > > I have mimic what `dired-compress-file' does: it checks if the > file is a directory. Thanks, your patch looks good to me. And the two test functions work in general. Just some few comments: > --- a/test/lisp/net/tramp-tests.el > +++ b/test/lisp/net/tramp-tests.el > +(ert-deftest tramp-test47-dired-compress-file () Please give it another name, which comes lexically before tramp-test46-unload. That test must be the last one, because it unloads Tramp in batch mode. I recommend tramp-test44-dired-compress-file. > + "Check that Tramp (un)compress normal files." "compresses" > + (skip-unless (tramp--test-enabled)) Add also (skip-unless (tramp--test-sh-p)) This is the only backend which implements dired-compress-file. > +(ert-deftest tramp-test47-dired-compress-dir () Same comments. If you like you could push it to Emacs, I will run then the zillions of test configurations I have available locally. Thanks, and best regards, Michael.