From: Michael Albinus <michael.albinus@gmx.de>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: uyennhi.qm@gmail.com, 50581@debbugs.gnu.org
Subject: bug#50581: 27.2.50; Tramp fails to (un)compress directories
Date: Mon, 20 Sep 2021 14:50:19 +0200 [thread overview]
Message-ID: <878rzre7hw.fsf@gmx.de> (raw)
In-Reply-To: <87wnnc7bmp.fsf@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Sun, 19 Sep 2021 18:50:38 +0200")
Tino Calancha <tino.calancha@gmail.com> writes:
Hi Tino,
>> Indeed, the directory case is not implemented in tramp-sh-handle-dired-compress-file.
>> I will see how to implement it next time.
>
> I have mimic what `dired-compress-file' does: it checks if the
> file is a directory.
Thanks, your patch looks good to me. And the two test functions work in
general.
Just some few comments:
> --- a/test/lisp/net/tramp-tests.el
> +++ b/test/lisp/net/tramp-tests.el
> +(ert-deftest tramp-test47-dired-compress-file ()
Please give it another name, which comes lexically before
tramp-test46-unload. That test must be the last one, because it unloads
Tramp in batch mode.
I recommend tramp-test44-dired-compress-file.
> + "Check that Tramp (un)compress normal files."
"compresses"
> + (skip-unless (tramp--test-enabled))
Add also
(skip-unless (tramp--test-sh-p))
This is the only backend which implements dired-compress-file.
> +(ert-deftest tramp-test47-dired-compress-dir ()
Same comments.
If you like you could push it to Emacs, I will run then the zillions of
test configurations I have available locally.
Thanks, and best regards, Michael.
next prev parent reply other threads:[~2021-09-20 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 12:53 bug#50581: 27.2.50; Tramp fails to (un)compress directories Tino Calancha
2021-09-14 18:43 ` Michael Albinus
2021-09-19 16:50 ` Tino Calancha
2021-09-20 12:50 ` Michael Albinus [this message]
2021-11-05 3:36 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rzre7hw.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=50581@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
--cc=uyennhi.qm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).