From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50798: 28.0.50; Tab line close button is off-center until it is highlighted with the mouse Date: Mon, 27 Sep 2021 18:39:13 +0300 Organization: LINKOV.NET Message-ID: <878rzi11xq.fsf@mail.linkov.net> References: <8735ptxhzs.fsf.ref@yahoo.com> <8735ptxhzs.fsf@yahoo.com> <87wnn5m8eo.fsf@gnus.org> <83wnn5qe48.fsf@gnu.org> <87k0j5m5ik.fsf@gnus.org> <83tui9qd2j.fsf@gnu.org> <87fsttm512.fsf@gnus.org> <87y27kbi6y.fsf@mail.linkov.net> <83a6k0phik.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13876"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: luangruo@yahoo.com, larsi@gnus.org, 50798@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 27 17:43:48 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUsnD-0003IO-Fo for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Sep 2021 17:43:47 +0200 Original-Received: from localhost ([::1]:33708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUsnC-0005b7-GO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Sep 2021 11:43:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUsmV-000437-63 for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2021 11:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUsmU-0004E2-VL for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2021 11:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUsmU-0003qn-If for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2021 11:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Sep 2021 15:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50798 X-GNU-PR-Package: emacs Original-Received: via spool by 50798-submit@debbugs.gnu.org id=B50798.163275737814773 (code B ref 50798); Mon, 27 Sep 2021 15:43:02 +0000 Original-Received: (at 50798) by debbugs.gnu.org; 27 Sep 2021 15:42:58 +0000 Original-Received: from localhost ([127.0.0.1]:42435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUsmQ-0003qA-7q for submit@debbugs.gnu.org; Mon, 27 Sep 2021 11:42:58 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:33045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUsmM-0003pV-5G for 50798@debbugs.gnu.org; Mon, 27 Sep 2021 11:42:54 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 0551D200008; Mon, 27 Sep 2021 15:42:46 +0000 (UTC) In-Reply-To: <83a6k0phik.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Sep 2021 22:44:19 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215682 Archived-At: >> >> Try starting Emacs with a larger font, then. As in >> >> >> >> emacs -Q -fn "FOO-18" >> >> >> >> where FOO is the font you get by default, like "DejaVu Sans Mono" or >> >> something. >> > >> > I'm still not seeing any difference whether the mouse is over the x or >> > not. >> >> I can reproduce this with a very big font on the tab-line, but not tab-bar. > > We _are_ talking about the tab-line. The problem is that hovering mouse over the text property 'mouse-face' set to 'tab-line-highlight' that contains ':inherit' applies its face attributes such as :box :line-width twice thus shifting the image upwards. This patch fixes the problem by copying face attributes from the inherited face directly to the face used by 'mouse-face': diff --git a/lisp/tab-line.el b/lisp/tab-line.el index 4a751b384e..3993e625c9 100644 --- a/lisp/tab-line.el +++ b/lisp/tab-line.el @@ -119,7 +119,11 @@ tab-line-tab-current :group 'tab-line-faces) (defface tab-line-highlight - '((t :inherit tab-line-tab)) + '((((class color) (min-colors 88)) + :box (:line-width 1 :style released-button) + :background "grey85" + :foreground "black") + (t :inverse-video nil)) "Tab line face for highlighting." :version "27.1" :group 'tab-line-faces) --