From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49484: 27.2; [PATCH] Undoing a 'RET' in comint and eshell Date: Mon, 08 Nov 2021 00:11:45 +0100 Message-ID: <878rxzef2m.fsf@gnus.org> References: <87eec7c01w.fsf@miha-pc> <87fswmnmsl.fsf@gnus.org> <86zgukf4pn.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16346"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 49484@debbugs.gnu.org, Stefan Monnier To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 08 00:17:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjrPT-0003nD-VJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Nov 2021 00:17:11 +0100 Original-Received: from [::1] (port=47262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjrPT-0005Ts-0m for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 18:17:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjrKX-0003es-Bv for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 18:12:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjrKU-0003Wo-OI for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 18:12:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjrKU-0006ov-I6 for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 18:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Nov 2021 23:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49484 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49484-submit@debbugs.gnu.org id=B49484.163632671826202 (code B ref 49484); Sun, 07 Nov 2021 23:12:02 +0000 Original-Received: (at 49484) by debbugs.gnu.org; 7 Nov 2021 23:11:58 +0000 Original-Received: from localhost ([127.0.0.1]:55217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjrKP-0006oY-Sv for submit@debbugs.gnu.org; Sun, 07 Nov 2021 18:11:58 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:39912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjrKO-0006oI-2Z for 49484@debbugs.gnu.org; Sun, 07 Nov 2021 18:11:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ihvMrg+jVhA0/N1Q4AfFWwf2me4BUs1fuT/a/Uy9LZM=; b=K3K6OtlsLxCB9u++j/W0ynYy1a 2c2pF054C4InW4iKD5AY0lHI2Zy9V6T300h6827FXD53UcMCIoo8ZeIXP0JvBvOHxGYL6zySMmMhw BTPfhFDlFxVz9BtPe7/b3yEVE3Iaim4o2O+EHTUWLK3Dq+vvRFT2EQH03vAt630l4Bpg=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjrKD-0004em-Tv; Mon, 08 Nov 2021 00:11:48 +0100 X-Now-Playing: Leslie Winer's _When I Hit You, You'll Feel It_: "He Was" In-Reply-To: <86zgukf4pn.fsf@miha-pc> (miha@kamnitnik.top's message of "Sun, 18 Jul 2021 09:42:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219302 Archived-At: writes: > So after thinking about this some more, I arrived at a simpler solution: > deleting and reinserting text to generate suitable undo list entries > instead of adding them explicitly. > As opposed to the first patch, this one should also handle > undo-in-region reasonably well. Thanks, I've now finally tested this, and it seems to work perfectly, so I've now pushed it to Emacs 29. Sorry for the delay. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no