From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52593: 28.0.90; (thing-at-point thing) has so much overhead since commit 7db376e560448e61485ba054def8c82b21f33d6a Date: Sun, 19 Dec 2021 16:49:37 +0100 Message-ID: <878rwgtx0u.fsf@gnus.org> References: <83zgoybbfr.fsf@gnu.org> <83ee689156.fsf@gnu.org> <878rwgra3k.fsf@gnus.org> <87h7b4u01e.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6665"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52593@debbugs.gnu.org To: Kang Niu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 19 16:50:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myyS4-0001Zp-Hr for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 16:50:20 +0100 Original-Received: from localhost ([::1]:35634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myyS3-0007xj-Bw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 10:50:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myyRr-0007x4-3J for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 10:50:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36228) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myyRm-0003dd-5V for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 10:50:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myyRm-0000Pk-3k for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 10:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Dec 2021 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52593 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 52593-submit@debbugs.gnu.org id=B52593.16399289911570 (code B ref 52593); Sun, 19 Dec 2021 15:50:02 +0000 Original-Received: (at 52593) by debbugs.gnu.org; 19 Dec 2021 15:49:51 +0000 Original-Received: from localhost ([127.0.0.1]:47774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myyRa-0000PG-UX for submit@debbugs.gnu.org; Sun, 19 Dec 2021 10:49:51 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:43548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myyRY-0000P2-TW for 52593@debbugs.gnu.org; Sun, 19 Dec 2021 10:49:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vokT9mM/sIKM2SHU7ac7NyTxhY+Z0LtXAfJ5rqNk1Qo=; b=jBFxVbech2z723jEygP3soqhgE D1Z6Njgn223lQyymWbtcTcOnzZPZUr5Ah00u1tLxr6jSX+A/1ZAWSrl+IB7COTc7CU0MSVTOwDWsB O9R1ACfmxXpF0VwDHjK/f0BaV7ETfjG9O424adIgn1HlKD679w6CJ/PBuG1X8X11FXG0=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myyRP-0004yn-Na; Sun, 19 Dec 2021 16:49:42 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEX9/fz18s/x7Kms qY1aWEU0MyeZlG+BfWL///+iDY0nAAAAAWJLR0QIht6VegAAAAd0SU1FB+UMEw8wGb1w7O8AAAGv SURBVDjL3ZPBbusgEEXDHwQiva7BUbJNwbXXiYewr5hm29ZxvG0TGv9+B7DbKttunoqQJTjce8dj PJv9F4PPabLfeTChFE0+Y3zO05iAUpILmbYEVyqeyamCACULTZCkUtDqBxAl+PskGBWMHOgo+4fu FkguSStCW/EM5AhUVHBVGnMDVvfkdLmstc77k1UB3p0MhGuVgKRSMsBxwNAbpVbvt8BDYfGs1I5L kQEEQG/RB2PxUamjEjqDIQCcCNgr4n4Au1s8fltBfDjEHgZoeJ2BnUJcVPShUXfzL4X1vdMl+goA dlpskgSOQOnU99KdgiMrF54TeIiS4bXQVYhph7bqk4KVtDy8nB+uHynqqTCv+Xt0HnGrTKe7XMMK fQZHWm3XnZNU3qEGJP6WwJJee1vYZh2PmwB2At2+w3dOybEv4FocAbOXD9zyJRUU+9LUXwAvFp8W 9C6xL3Yfi9yMoLboekitSY9cFbNND+CGAaJZ6ibkliybI7irqWiP0tB7b1NL2KLpT61Wa2pIS04+ IOTwjU7XdhWsN/FDQn3OVuPfQjdS0m2fM86m6/6nxycD0pDzRpzfuQAAACV0RVh0ZGF0ZTpjcmVh dGUAMjAyMS0xMi0xOVQxNTo0ODoyNSswMDowMGOJs9EAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEt MTItMTlUMTU6NDg6MjUrMDA6MDAS1AttAAAAAElFTkSuQmCC X-Now-Playing: Neil Young's _Comes a Time_: "Goin' Back" In-Reply-To: (Kang Niu's message of "Sun, 19 Dec 2021 23:37:05 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222704 Archived-At: Kang Niu writes: > Maybe the field functions are slow. > I replaced the field functions with point-min and point-max > (narrow-to-region (point-min) (point-max)) > and the overhead disappeared. Reading the field functions, it seems like they don't check for the common case -- that is, being called outside a field, and do a whole lot of work that turns out to be pointless. Does the following (untested) patch fix the performance problems? diff --git a/src/editfns.c b/src/editfns.c index 5c9c34dc35..3e716a4544 100644 --- a/src/editfns.c +++ b/src/editfns.c @@ -437,6 +437,17 @@ find_field (Lisp_Object pos, Lisp_Object merge_at_boundary, after_field = get_char_property_and_overlay (pos, Qfield, Qnil, NULL); + + /* We're not in a field, so just return `point-min'/`point-max'. */ + if (NILP (after_field)) + { + if (beg) + *beg = BEGV; + if (end) + *end = ZV; + return; + } + before_field = (XFIXNAT (pos) > BEGV ? get_char_property_and_overlay (make_fixnum (XFIXNUM (pos) - 1), -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no