From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#54838: 28.1; Buffers are not updated when a directory is renamed in dired Date: Sun, 10 Apr 2022 19:19:26 +0200 Message-ID: <878rscetim.fsf@gnu.org> References: <87ilrh55aj.fsf@valhala.localdomain> <838rsc7tdy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39264"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.12; emacs 29.0.50 Cc: Nicolas Martyanoff , 54838@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 10 19:31:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndbP6-000A4M-DQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Apr 2022 19:31:12 +0200 Original-Received: from localhost ([::1]:51766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndbP5-00077f-5v for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Apr 2022 13:31:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndbOw-00077H-J5 for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2022 13:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndbOw-0002iq-7y for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2022 13:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ndbOw-0001BE-4z for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2022 13:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Apr 2022 17:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54838 X-GNU-PR-Package: emacs Original-Received: via spool by 54838-submit@debbugs.gnu.org id=B54838.16496118054374 (code B ref 54838); Sun, 10 Apr 2022 17:31:02 +0000 Original-Received: (at 54838) by debbugs.gnu.org; 10 Apr 2022 17:30:05 +0000 Original-Received: from localhost ([127.0.0.1]:41335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndbO0-00018S-EO for submit@debbugs.gnu.org; Sun, 10 Apr 2022 13:30:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndbNy-00017S-KN for 54838@debbugs.gnu.org; Sun, 10 Apr 2022 13:30:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndbNt-0002Np-A6; Sun, 10 Apr 2022 13:29:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=h44PnlfcPjhFBcRjvB+99wFdoz8vt+Csd0ucFOnSSiA=; b=Z9GBwVVhRDP1pX OgAeaM9grepLPDNaZdqZzNpc1CPIuy3XLoEJp8I6ZH653DpbyUebZdEg9qulxeXic7mLMeYc1BraO Qf0MA9399ayruOMSEXS4RTnY8g1tzZUVvKsB5/saX6zuztQrFKAFIwgnIq91HH+xsY+Zecyxh4f8h fYa0fZ6BHpUupoRF06wH44PJVky4PbEecBP15YgwsaOCn/2IGfxqriivxwwDP8+sTIx7UUjTUCLV+ 3XIrYMfFoCJPcWc4imNuKBH+fvwfz+p2tQH6OaFf8M4mSacGXCJifUQgepp67qc6QpUdJK+YVicyD ij9zFP2euCbx4Maq9JhQ==; Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:44845) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndbNs-0002ob-SS; Sun, 10 Apr 2022 13:29:56 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id 7540627C0054; Sun, 10 Apr 2022 13:29:56 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 10 Apr 2022 13:29:56 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekgedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe evveeikeetkeeviefgfeffiedvteeguddvffeuueduveegtddthedvhfeuveffhfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedv leekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Apr 2022 13:29:55 -0400 (EDT) In-reply-to: <838rsc7tdy.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229679 Archived-At: Eli Zaretskii writes: Hi Eli, > Tassilo, part of this bug is yet another fallout from replacing > dired-in-this-tree-p with file-in-directory-p: the latter returns nil > if its second arg doesn't exist, and in this scenario we are dealing > with a directory that was already renamed to the new name. Do you > agree with my proposed solution for that below? I would just revert back to using dired-in-this-tree-p and never file-in-directory-p in those places. I've done that for many places in 61677ac3e4685d8f81c3b90eb751d9b5e8a3732d, too, because it turned out that the change from dired-in-this-tree-p to file-in-directory-p caused performance problems. The fact that dired-in-this-tree-p works for non-existing files and dired relies on that didn't even occur to me. :-( Bye, Tassilo