From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#54458: 27.2; erc-dcc-get: Re-entering top level after C stack overflow Date: Mon, 25 Apr 2022 05:08:52 -0700 Message-ID: <878rrtz7or.fsf__1326.61235272593$1650888633$gmane$org@neverwas.me> References: <78459EAB-314B-4122-8E3B-7F82685D0DBA@acm.org> <83a6da9vm8.fsf@gnu.org> <87r16m46uf.fsf@neverwas.me> <4DA2DB05-D902-42DF-860D-87617FBB74C8@acm.org> <83k0cc907r.fsf@gnu.org> <5A8EE4CF-6F5E-4119-8765-8E301E2BE935@acm.org> <87czi435nh.fsf@neverwas.me> <87mth8rst7.fsf@neverwas.me> <98F3182F-80A4-4131-8E9C-E1576908DF96@acm.org> <87sfqygccz.fsf@neverwas.me> <87h77aozgw.fsf@gmail.com> <87wng67xxd.fsf@neverwas.me> <875yng39sa.fsf@neverwas.me> <87sfqkz4ts.fsf@neverwas.me> <87ilqyrn9s.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13190"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , emacs-erc@gnu.org, bandali@gnu.org, 54458@debbugs.gnu.org To: Fernando de Morais Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 25 14:10:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nixXr-0003G4-87 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Apr 2022 14:10:23 +0200 Original-Received: from localhost ([::1]:45060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nixXp-0001vm-SE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Apr 2022 08:10:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nixXX-0001i7-Ef for bug-gnu-emacs@gnu.org; Mon, 25 Apr 2022 08:10:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nixXW-0005Rp-J4 for bug-gnu-emacs@gnu.org; Mon, 25 Apr 2022 08:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nixXW-0006ko-De for bug-gnu-emacs@gnu.org; Mon, 25 Apr 2022 08:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Apr 2022 12:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 54458-submit@debbugs.gnu.org id=B54458.165088854925896 (code B ref 54458); Mon, 25 Apr 2022 12:10:02 +0000 Original-Received: (at 54458) by debbugs.gnu.org; 25 Apr 2022 12:09:09 +0000 Original-Received: from localhost ([127.0.0.1]:33450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nixWd-0006ja-FJ for submit@debbugs.gnu.org; Mon, 25 Apr 2022 08:09:09 -0400 Original-Received: from mail-108-mta80.mxroute.com ([136.175.108.80]:34849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nixWY-0006j2-Kg for 54458@debbugs.gnu.org; Mon, 25 Apr 2022 08:09:06 -0400 Original-Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta80.mxroute.com (ZoneMTA) with ESMTPSA id 180609fef8d000fe85.002 for <54458@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 25 Apr 2022 12:08:55 +0000 X-Zone-Loop: 2b8e1b80a28c66bb06ea539d83bdd2f1aa0b95aa554b X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OH/mhW27eZSaFxhnQ0y+1hKIe8R5r0hWP2MGS/i6FuQ=; b=jV1Fnf+LCXBG0GyV2lnvpWGW5D +08J8UnXNzEoXHez7dpxF5hAkBBlw4EJGPUyXYWR9d2LhkysNHosNkBMKmdfMg6LsPeRhbGBWMq9L PJhYl0y/OYjj9t2JSbFSHs3nfE+GbExgCX93PKXUl7D82OCb50z6Igtb3xTU4hn/5Rzlnd+vuc6O2 xecuApFXJdHyVfamQvTGw1b1D4+e2/pISB+Yq183zGgA9jPDRapDuExvvGfYqjJTYfb/cNtjs5kPW 84mpAZtRtLQIY8G6zXSnm9P2sXbp4s1W14tKHomgl5TjvPCIzjzFfukJ16tXUgpj2tC/aoW0AI4h/ j5BxJijQ==; In-Reply-To: <87ilqyrn9s.fsf@gmail.com> (Fernando de Morais's message of "Sun, 24 Apr 2022 21:59:27 -0300") X-AuthUser: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230636 Archived-At: Fernando de Morais writes: > Once more, sorry for the late response. Not a problem! Plenty to do around here. > I tested your patch (0003) and it worked the way you detailed: now I can > do more than one transfer simultaneously, however, at some point I lose > control of Emacs and regain it, completely, only when the transfers are > finished. I "believe" the simultaneous-receive problem and the loss-of-control issue are unrelated (despite the second being exacerbated by the first). > I believe I did something wrong when running `tcpdump' command, as it > did not detect any files transferred through DCC GET in my tests and > the dump file generated was always the same, 24 bytes, containing only > one line. No worries. I'll just assume the sender is behaving aberrantly. The thing is, I still haven't been able to repro this with a real client as sender. And when I asked around to see if anyone else has encountered anything related, e.g., 1. senders that never read 2. clients that always act defensively I only got crickets for the second and for the first was told there's a variant of the protocol (or some extension) called TSEND, which might be to blame if enabled by a sender. That said, I don't see an obvious problem with applying some version of the proposed patches because we wouldn't be impacting routine behavior, AFAICT. And since DCC has basically been deprecated for years, the risk of incurring related hate mail is low should this observation prove faulty. > I found this approach very interesting and as soon as I could I tried to > test it, but even in Emacs 28.1 I get the following error messages: > > error in process sentinel: erc-format-message: No format spec for message dcc-get-failed > error in process sentinel: No format spec for message dcc-get-failed > > Is this an issue specific to the versions of Emacs (27.2 and 28.1) I > tested it on? Hm. And you applied *all* the patches as a sequence? I.e., git am ~/somedir/000{1..4}-*.patch Because the format spec lives in the first one: 0001-Display-error-message-on-incomplete-ERC-DCC-transfer.patch So that needs to be present (as do the rest). IOW, in this capacity, they're acting as a set (not v1..vN iterations). Can you compare your version of erc-dcc.el to the one on HEAD? BTW, I know for sure that they won't apply cleanly on 27 (but they "should" on 28). > Thank you so much for keeping investigating possible solutions. I'll be > using your patches #2 and #3. My pleasure! Thanks for reporting this. (FWIW, the subprocess thing worked for me, but YMMV.)