bug#38083: 27.0.50; Deprecation warnings in NS build

bug#38083: 27.0.50; Deprecation warnings in NS build

[Pankaj Jangid]

In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin19.0.0, NS appkit-1894.10 Version 10.15.1 (Build 19B88))
 of 2019-11-06 built on Pankajs-MacBook-Pro.local
Repository revision: 0661a39d1b501a41e439df8c73f7b7f3bf3e3761
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.1

Configured using:
 'configure CPPFLAGS=-I/usr/local/opt/ruby/include
 LDFLAGS=-L/usr/local/opt/ruby/lib'

Configured features:
RSVG DBUS GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS
NS MODULES THREADS JSON PDUMPER LCMS2 GMP

There are several deprecation warnings in NS build. Good thing is that,
these are confined to just two files - nsterm.o and nsselect.o. I've
copied following warnings from the build output,

CC       nsterm.o
nsterm.m:2771:26: warning: 'scrollRect:by:' is deprecated: first deprecated in macOS 10.14 - Use NSScrollView to achieve scrolling views. [-Wdeprecated-declarations]
      [FRAME_NS_VIEW (f) scrollRect: src by: delta];
                         ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSView.h:213:1: note: 'scrollRect:by:' has been explicitly marked deprecated here
- (void)scrollRect:(NSRect)rect by:(NSSize)delta API_DEPRECATED("Use NSScrollView to achieve scrolling views.", macos(10.0,10.14));
^
nsterm.m:5442:29: warning: 'NSFilenamesPboardType' is deprecated: first deprecated in macOS 10.14 - Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead
      [-Wdeprecated-declarations]
                            NSFilenamesPboardType,
                            ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:312:32: note: 'NSFilenamesPboardType' has been explicitly marked deprecated here
APPKIT_EXTERN NSPasteboardType NSFilenamesPboardType API_DEPRECATED("Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead", macos(10.0,10.14));
                               ^
nsterm.m:8258:35: warning: 'NSFilenamesPboardType' is deprecated: first deprecated in macOS 10.14 - Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead
      [-Wdeprecated-declarations]
  else if ([type isEqualToString: NSFilenamesPboardType])
                                  ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:312:32: note: 'NSFilenamesPboardType' has been explicitly marked deprecated here
APPKIT_EXTERN NSPasteboardType NSFilenamesPboardType API_DEPRECATED("Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead", macos(10.0,10.14));
                               ^
nsterm.m:8273:35: warning: 'NSURLPboardType' is deprecated: first deprecated in macOS 10.14 [-Wdeprecated-declarations]
  else if ([type isEqualToString: NSURLPboardType])
                                  ^~~~~~~~~~~~~~~
                                  NSPasteboardTypeURL
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:321:32: note: 'NSURLPboardType' has been explicitly marked deprecated here
APPKIT_EXTERN NSPasteboardType NSURLPboardType API_DEPRECATED_WITH_REPLACEMENT("NSPasteboardTypeURL", macos(10.0,10.14));
                               ^
nsterm.m:8282:35: warning: 'NSStringPboardType' is deprecated: first deprecated in macOS 10.14 [-Wdeprecated-declarations]
  else if ([type isEqualToString: NSStringPboardType]
                                  ^~~~~~~~~~~~~~~~~~
                                  NSPasteboardTypeString
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:311:32: note: 'NSStringPboardType' has been explicitly marked deprecated here
APPKIT_EXTERN NSPasteboardType NSStringPboardType API_DEPRECATED_WITH_REPLACEMENT("NSPasteboardTypeString", macos(10.0,10.14));
                               ^
nsterm.m:8283:38: warning: 'NSTabularTextPboardType' is deprecated: first deprecated in macOS 10.14 [-Wdeprecated-declarations]
           || [type isEqualToString: NSTabularTextPboardType])
                                     ^~~~~~~~~~~~~~~~~~~~~~~
                                     NSPasteboardTypeTabularText
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:315:32: note: 'NSTabularTextPboardType' has been explicitly marked deprecated here
APPKIT_EXTERN NSPasteboardType NSTabularTextPboardType API_DEPRECATED_WITH_REPLACEMENT("NSPasteboardTypeTabularText", macos(10.0,10.14));
                               ^
6 warnings generated.
  CC       nsselect.o
nsselect.m:81:27: warning: 'NSFilenamesPboardType' is deprecated: first deprecated in macOS 10.14 - Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead
      [-Wdeprecated-declarations]
  if ([t isEqualToString: NSFilenamesPboardType])
                          ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:312:32: note: 'NSFilenamesPboardType' has been explicitly marked deprecated here
APPKIT_EXTERN NSPasteboardType NSFilenamesPboardType API_DEPRECATED("Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead", macos(10.0,10.14));
                               ^
nsselect.m:476:36: warning: 'NSFilenamesPboardType' is deprecated: first deprecated in macOS 10.14 - Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead
      [-Wdeprecated-declarations]
             [NSNumber numberWithLong:0], NSFilenamesPboardType,
                                          ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:312:32: note: 'NSFilenamesPboardType' has been explicitly marked deprecated here
APPKIT_EXTERN NSPasteboardType NSFilenamesPboardType API_DEPRECATED("Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead", macos(10.0,10.14));
                               ^
2 warnings generated.

-- 
Pankaj Jangid

bug#38083: 27.0.50; Deprecation warnings in NS build

[Lars Ingebrigtsen]

Pankaj Jangid <pankaj.jangid@gmail.com> writes:

> There are several deprecation warnings in NS build. Good thing is that,
> these are confined to just two files - nsterm.o and nsselect.o. I've
> copied following warnings from the build output,
>
> CC       nsterm.o
> nsterm.m:2771:26: warning: 'scrollRect:by:' is deprecated: first deprecated in macOS 10.14 - Use NSScrollView to achieve scrolling views. [-Wdeprecated-declarations]
>       [FRAME_NS_VIEW (f) scrollRect: src by: delta];

[etc]

I haven't checked whether these are still present in Emacs 29, but
perhaps Po Lu has some input here; added to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#38083: 27.0.50; Deprecation warnings in NS build

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> There are several deprecation warnings in NS build. Good thing is that,
>> these are confined to just two files - nsterm.o and nsselect.o. I've
>> copied following warnings from the build output,
>>
>> CC       nsterm.o
>> nsterm.m:2771:26: warning: 'scrollRect:by:' is deprecated: first deprecated in macOS 10.14 - Use NSScrollView to achieve scrolling views. [-Wdeprecated-declarations]
>>       [FRAME_NS_VIEW (f) scrollRect: src by: delta];
>
> [etc]
>
> I haven't checked whether these are still present in Emacs 29, but
> perhaps Po Lu has some input here; added to the CCs.

I don't know about the nsselect ones, but we have this in nsterm.m now:

#if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
  double scale = [[self window] backingScaleFactor];
  CGContextRef context = [(EmacsLayer *)[self layer] getContext];
  int bpp = CGBitmapContextGetBitsPerPixel (context) / 8;
  void *pixels = CGBitmapContextGetData (context);
  int rowSize = CGBitmapContextGetBytesPerRow (context);
  int srcRowSize = NSWidth (srcRect) * scale * bpp;
  void *srcPixels = (char *) pixels
    + (int) (NSMinY (srcRect) * scale * rowSize
             + NSMinX (srcRect) * scale * bpp);
  void *dstPixels = (char *) pixels
    + (int) (dest.y * scale * rowSize
             + dest.x * scale * bpp);

  if (NSIntersectsRect (srcRect, dstRect)
      && NSMinY (srcRect) < NSMinY (dstRect))
    for (int y = NSHeight (srcRect) * scale - 1 ; y >= 0 ; y--)
      memmove ((char *) dstPixels + y * rowSize,
               (char *) srcPixels + y * rowSize,
               srcRowSize);
  else
    for (int y = 0 ; y < NSHeight (srcRect) * scale ; y++)
      memmove ((char *) dstPixels + y * rowSize,
               (char *) srcPixels + y * rowSize,
               srcRowSize);

#else

So we are off the hook now, since scrollRect is no longer used on Mac OS
X 10.14 and later.

bug#38083: 27.0.50; Deprecation warnings in NS build

[Pankaj Jangid]

And I no longer use (and have access to) a Mac OS. So I cannot verify
this bug report. Probably we can close it.

bug#38083: 27.0.50; Deprecation warnings in NS build

[Lars Ingebrigtsen]

I rooted out my Apple laptop (Macos 12.3.1, which is probably the
newest?), and I get the following warnings:

xwidget.c:491:19: warning: variable 'xw' set but not used [-Wunused-but-set-variable]
  struct xwidget *xw;
                  ^
xwidget.c:493:23: warning: unused variable 'keycode' [-Wunused-variable]
  int character = -1, keycode = -1;
                      ^
xwidget.c:492:17: warning: variable 'f' set but not used [-Wunused-but-set-variable]
  struct frame *f = NULL;
                ^
xwidget.c:493:7: warning: unused variable 'character' [-Wunused-variable]
  int character = -1, keycode = -1;
      ^
xwidget.c:494:7: warning: unused variable 'modifiers' [-Wunused-variable]
  int modifiers = 0;
      ^
and the following deprecation warnings:

nsfns.m:841:47: warning: 'iconForFileType:' is deprecated: first deprecated in macOS 12.0 - Use -[NSWorkspace iconForContentType:] instead. [-Wdeprecated-declarations]
      image = [[[NSWorkspace sharedWorkspace] iconForFileType: @"text"] retain];
                                              ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSWorkspace.h:456:1: note: 'iconForFileType:' has been explicitly marked deprecated here
- (NSImage *)iconForFileType:(NSString *)fileType API_DEPRECATED("Use -[NSWorkspace iconForContentType:] instead.", macos(10.0, 12.0));
^
nsfns.m:1760:12: warning: 'setAllowedFileTypes:' is deprecated: first deprecated in macOS 12.0 - Use -allowedContentTypes instead [-Wdeprecated-declarations]
    [panel setAllowedFileTypes: nil];
           ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSSavePanel.h:215:49: note: property 'allowedFileTypes' is declared deprecated here
@property (nullable, copy) NSArray<NSString *> *allowedFileTypes API_DEPRECATED("Use -allowedContentTypes instead", macos(10.3,12.0));
                                                ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSSavePanel.h:215:49: note: 'setAllowedFileTypes:' has been explicitly marked deprecated here
nsfns.m:2599:11: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
      if (IOMasterPort (MACH_PORT_NULL, &masterPort) != kIOReturnSuccess
          ^~~~~~~~~~~~
          IOMainPort
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:132:1: note: 'IOMasterPort' has been explicitly marked deprecated here
IOMasterPort( mach_port_t       bootstrapPort,
^
  CC       lastfile.o
3 warnings generated.
nsxwidget.m:75:31: warning: 'plugInsEnabled' is deprecated: first deprecated in macOS 10.15 - Plug-ins are no longer supported [-Wdeprecated-declarations]
    configuration.preferences.plugInsEnabled = YES;
                              ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/WebKit.framework/Headers/WKPreferences.h:84:28: note: 'plugInsEnabled' has been explicitly marked deprecated here
@property (nonatomic) BOOL plugInsEnabled API_DEPRECATED("Plug-ins are no longer supported", macos(10.10, 10.15));
                       

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#38083: 27.0.50; Deprecation warnings in NS build

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I rooted out my Apple laptop (Macos 12.3.1, which is probably the
> newest?), and I get the following warnings:
>
> xwidget.c:491:19: warning: variable 'xw' set but not used [-Wunused-but-set-variable]
>   struct xwidget *xw;
>                   ^
> xwidget.c:493:23: warning: unused variable 'keycode' [-Wunused-variable]
>   int character = -1, keycode = -1;
>                       ^
> xwidget.c:492:17: warning: variable 'f' set but not used [-Wunused-but-set-variable]
>   struct frame *f = NULL;
>                 ^
> xwidget.c:493:7: warning: unused variable 'character' [-Wunused-variable]
>   int character = -1, keycode = -1;
>       ^
> xwidget.c:494:7: warning: unused variable 'modifiers' [-Wunused-variable]
>   int modifiers = 0;
>       ^

The NS xwidget implementation is currently completely broken.  I wrote
that in etc/TODO, and patches are welcome, since I don't know my way
around the Mac OS WebKit APIs.

> nsfns.m:841:47: warning: 'iconForFileType:' is deprecated: first deprecated in macOS 12.0 - Use -[NSWorkspace iconForContentType:] instead. [-Wdeprecated-declarations]
>       image = [[[NSWorkspace sharedWorkspace] iconForFileType: @"text"] retain];
>                                               ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSWorkspace.h:456:1: note: 'iconForFileType:' has been explicitly marked deprecated here
> - (NSImage *)iconForFileType:(NSString *)fileType API_DEPRECATED("Use -[NSWorkspace iconForContentType:] instead.", macos(10.0, 12.0));
> ^
> nsfns.m:1760:12: warning: 'setAllowedFileTypes:' is deprecated: first deprecated in macOS 12.0 - Use -allowedContentTypes instead [-Wdeprecated-declarations]
>     [panel setAllowedFileTypes: nil];
>            ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSSavePanel.h:215:49: note: property 'allowedFileTypes' is declared deprecated here
> @property (nullable, copy) NSArray<NSString *> *allowedFileTypes API_DEPRECATED("Use -allowedContentTypes instead", macos(10.3,12.0));
>                                                 ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSSavePanel.h:215:49: note: 'setAllowedFileTypes:' has been explicitly marked deprecated here
> nsfns.m:2599:11: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
>       if (IOMasterPort (MACH_PORT_NULL, &masterPort) != kIOReturnSuccess
>           ^~~~~~~~~~~~
>           IOMainPort
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:132:1: note: 'IOMasterPort' has been explicitly marked deprecated here
> IOMasterPort( mach_port_t       bootstrapPort,
> ^
>   CC       lastfile.o
> 3 warnings generated.

I will look into the others, thanks.

bug#38083: 27.0.50; Deprecation warnings in NS build

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

>> 3 warnings generated.
>
> I will look into the others, thanks.

Thanks.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#38083: 27.0.50; Deprecation warnings in NS build

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I rooted out my Apple laptop (Macos 12.3.1, which is probably the
> newest?), and I get the following warnings:
>
> xwidget.c:491:19: warning: variable 'xw' set but not used [-Wunused-but-set-variable]
>   struct xwidget *xw;
>                   ^
> xwidget.c:493:23: warning: unused variable 'keycode' [-Wunused-variable]
>   int character = -1, keycode = -1;
>                       ^
> xwidget.c:492:17: warning: variable 'f' set but not used [-Wunused-but-set-variable]
>   struct frame *f = NULL;
>                 ^
> xwidget.c:493:7: warning: unused variable 'character' [-Wunused-variable]
>   int character = -1, keycode = -1;
>       ^
> xwidget.c:494:7: warning: unused variable 'modifiers' [-Wunused-variable]
>   int modifiers = 0;
>       ^
> and the following deprecation warnings:
>
> nsfns.m:841:47: warning: 'iconForFileType:' is deprecated: first deprecated in macOS 12.0 - Use -[NSWorkspace iconForContentType:] instead. [-Wdeprecated-declarations]
>       image = [[[NSWorkspace sharedWorkspace] iconForFileType: @"text"] retain];
>                                               ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSWorkspace.h:456:1: note: 'iconForFileType:' has been explicitly marked deprecated here
> - (NSImage *)iconForFileType:(NSString *)fileType API_DEPRECATED("Use -[NSWorkspace iconForContentType:] instead.", macos(10.0, 12.0));
> ^
> nsfns.m:1760:12: warning: 'setAllowedFileTypes:' is deprecated: first deprecated in macOS 12.0 - Use -allowedContentTypes instead [-Wdeprecated-declarations]
>     [panel setAllowedFileTypes: nil];
>            ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSSavePanel.h:215:49: note: property 'allowedFileTypes' is declared deprecated here
> @property (nullable, copy) NSArray<NSString *> *allowedFileTypes API_DEPRECATED("Use -allowedContentTypes instead", macos(10.3,12.0));
>                                                 ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSSavePanel.h:215:49: note: 'setAllowedFileTypes:' has been explicitly marked deprecated here
> nsfns.m:2599:11: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
>       if (IOMasterPort (MACH_PORT_NULL, &masterPort) != kIOReturnSuccess
>           ^~~~~~~~~~~~
>           IOMainPort
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:132:1: note: 'IOMasterPort' has been explicitly marked deprecated here
> IOMasterPort( mach_port_t       bootstrapPort,
> ^
>   CC       lastfile.o
> 3 warnings generated.
> nsxwidget.m:75:31: warning: 'plugInsEnabled' is deprecated: first deprecated in macOS 10.15 - Plug-ins are no longer supported [-Wdeprecated-declarations]
>     configuration.preferences.plugInsEnabled = YES;
>                               ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/WebKit.framework/Headers/WKPreferences.h:84:28: note: 'plugInsEnabled' has been explicitly marked deprecated here
> @property (nonatomic) BOOL plugInsEnabled API_DEPRECATED("Plug-ins are no longer supported", macos(10.10, 10.15));

These should be fixed now, aside from the ones in the xwidget code.
Please test.

bug#38083: 27.0.50; Deprecation warnings in NS build

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> These should be fixed now, aside from the ones in the xwidget code.
> Please test.

Thanks; I can confirm that the warnings are gone, so I'm closing this
bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no