From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46493: [feature/pgtk] Low contrast region face Date: Sun, 19 Jun 2022 20:51:19 +0800 Message-ID: <878rpszuig.fsf@yahoo.com> References: <87sg5zrjos.fsf@tcd.ie> <20210214.125955.33145462292773166.masm@luna.pink.masm11.me> <87a6ab8l1t.fsf@gnus.org> <874k0i3f7t.fsf@yahoo.com> <87k09e2spd.fsf@gnus.org> <871qvl1isu.fsf@yahoo.com> <87wndcykky.fsf@gnus.org> <87ilowzx5t.fsf@yahoo.com> <87bkuoyi6t.fsf@gnus.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19064"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: contovob@tcd.ie, 46493@debbugs.gnu.org, Yuuki Harano To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 19 14:52:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2uPj-0004j7-Ak for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jun 2022 14:52:27 +0200 Original-Received: from localhost ([::1]:39664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2uPh-0000d3-Oc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jun 2022 08:52:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2uPK-0000cu-Ro for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 08:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56932) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2uPK-00086w-F6 for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 08:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o2uPK-0002aF-DS for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 08:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jun 2022 12:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 46493-submit@debbugs.gnu.org id=B46493.16556430979896 (code B ref 46493); Sun, 19 Jun 2022 12:52:02 +0000 Original-Received: (at 46493) by debbugs.gnu.org; 19 Jun 2022 12:51:37 +0000 Original-Received: from localhost ([127.0.0.1]:50829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2uOv-0002ZY-FE for submit@debbugs.gnu.org; Sun, 19 Jun 2022 08:51:37 -0400 Original-Received: from sonic308-56.consmr.mail.ne1.yahoo.com ([66.163.187.31]:43471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2uOs-0002ZJ-Kj for 46493@debbugs.gnu.org; Sun, 19 Jun 2022 08:51:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1655643088; bh=fhtIIcjmakv3AKJ0RsSV/6mdGZ6ubP521B6J91NQFoo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=dlrxZ2LAm4P2aY1y/i692fg2C6BMww1XvsTXPg1botJ/7lU7A/GDtPp2uvqGyaEkYWYdIwu0oK7qH4Kx4MC2thx0EJODR3Tpm7mGBggafbH4KpQlF93Cv3+EeAp3dKzYGlV3hzNSNPBy3bX6ma5UzWkqEKY3rcjmIN09D98vfMpSkMUYlJPer+3tr1G2NFHNEef3nh0J7qMqMLc+KY8I7Ke8JKuEi6ilsFu5fIqAIwefcKM+8ZUXDCyEvazIblHqQKx8PQ37Z/Odz4vknN3w0SAfu7tUX7KPY+KRIj+BXsoNt0KxPgqHzkAPHBrdYl94kYlbLCvLpCHkqFYxOYsbqQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1655643088; bh=gYQ14wdHer2s2qP2mf0qQ5h0hgLD+AuCWn0xutkFQc7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Wip8y3lUn07mHAl1xgDFkQHpj1DuJAoGSBLyM1J4cP0cad0aSOYiucM+rDiNHDhNRqmByQQKKB/qPbNI99g949rIiLZRq+1jUMXPrSz1Pt/l/uhSmBedH8uAH0GNABfvwYlSYMuLXtCipMmGnVAH28Tr0BpSr5otbwMBxD5CByeoBMX2FlEdcxHyDrIUvYdDQmD2M0SutCjG50gobf1VxPqgqDjGrlYlJ0lNDtdQMT0C6dTcgY3GBhjsscy8Mvhn1Ck/P/orTfqNFICPf/k913GFRkze3J6rBu+7wmu5GppDEqld3U2tWcwZ5IzS3a0w7li1sDkYcmzRkkkyZzf7nw== X-YMail-OSG: MLu8s5AVM1k0eyyC.dPSRXEJ8vBQeHxfhMRcqkDEzBqcgkAwymXU3HF.yYxa0d3 SMRv8OaYHMReOvBoicSSbhBmMAvRNYjGsiDqcH29JzTVW.clY0OlM8v1JphzNmy3s0M1yYIPq2zo ceQP.aXwRJr4pP6Zjg3PmRUz0G5xZj_TXGyORHw_4RdHQrk6n.wDhR6lF3OKCz_Zrn17dOgJ.DYm 01JTx6K7_FIjRqP4o8BdsbQj8r9.lItU20.0q9cQ2e.2GEx8pTxLT0ep3TZSv8TRR6VPGO8BmmS_ 7WU4uaR8oovmd6u8TeQ5uVn8k9EvLWxcqlI70Y7qomP0t9tMy5FP9aJA09zD_DV4rpqlMTN.aX4N S3JYVaUuhmsKc5HtnQUXZo2K6VRV1UEPfsr6cnDI1lwd8QiqX.7fY8PzWTawpDMf1LiWk5V2AKAW 9sgxeUy88uA_rOZ0_PwCsaUSGPApKcvyqiLMqX3I.L0ZUloZtTg5BiEwxs72c3.Zk44VyGt.divE 5gs75lPeCh9TFPoOYhviIsfez9pcayCfA9cbBSlWAYXWgBmus.28aJLRgoFWjZHXH6ot4Mvd4g6c 0LJetK7FTTobAaJmiOckszvWIdCrhgY19ZUcuk0e3I1jnzPtGZCJ3ifIS80hiyowPpUPwW8QsG99 ZxiHblMOzZRD_MPTILKQTkjf1v7gbQHkNAIpyHkYP3eSvX1vd_1i7odpKE8at4G5JPVj.nPcbUBF ZwCiNGhbzQNXmiWja4ZjQ2J3cvScu81yp3FmItpgvv.s6UnZzWwQmmsO5WKYOoDdeO9F11pUzQL1 _Fbcw6pc4TJ68iPlLYia_ImD0ruq3BQqilLOR9EnZl X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Sun, 19 Jun 2022 12:51:28 +0000 Original-Received: by hermes--canary-production-sg3-559fcd5995-5cxt2 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5911e59126955e85caf37c80d60b48c4; Sun, 19 Jun 2022 12:51:24 +0000 (UTC) In-Reply-To: <87bkuoyi6t.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 19 Jun 2022 14:02:50 +0200") X-Mailer: WebService/1.1.20280 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234781 Archived-At: Lars Ingebrigtsen writes: > Testing this on my laptop, I get the same colour in pgtk and not -- a > very dark grey. And that's because I use a dark theme in Gnome Shell, > presumably? I guess so, yes. Though the GNOME Shell theme is separate from the GTK stylesheet itself, as GNOME Shell uses a different toolkit. > However, we ignore the theme for everything else, so "emacs -Q" gives me > an Emacs with a white background -- and a very dark region face. That shouldn't be problematic, right? Because we have the distant foreground set to the GTK region foreground color, so there will always be sufficient contrast. > It's nonsensical to heed Gtk's settings for the region face when we > don't heed it for the default background colour, so again I'm back to > the same point: We should probably just remove that code and use the > normal Emacs-determined face colours on (p)gtk, too. I don't think so: it seems unduly harsh, since we also do the same on other platforms such as Mac OS. Users using a non-default GTK stylesheet should know of the consequences, and can simply customize the region face to use a different background color.