From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46493: [feature/pgtk] Low contrast region face Date: Mon, 20 Jun 2022 00:41:45 +0200 Message-ID: <878rpstgwm.fsf@gnus.org> References: <87sg5zrjos.fsf@tcd.ie> <20210214.125955.33145462292773166.masm@luna.pink.masm11.me> <87a6ab8l1t.fsf@gnus.org> <874k0i3f7t.fsf@yahoo.com> <87k09e2spd.fsf@gnus.org> <871qvl1isu.fsf@yahoo.com> <87wndcykky.fsf@gnus.org> <87ilowzx5t.fsf@yahoo.com> <87bkuoyi6t.fsf@gnus.org> <878rpszuig.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9685"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: contovob@tcd.ie, 46493@debbugs.gnu.org, Yuuki Harano To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 20 00:42:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o33cT-0002Jo-CD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jun 2022 00:42:13 +0200 Original-Received: from localhost ([::1]:52134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o33cR-00011e-UR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jun 2022 18:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o33cI-00011Q-LM for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 18:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59503) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o33cI-0004hU-Db for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 18:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o33cI-0006AL-9m for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 18:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jun 2022 22:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 46493-submit@debbugs.gnu.org id=B46493.165567851823692 (code B ref 46493); Sun, 19 Jun 2022 22:42:02 +0000 Original-Received: (at 46493) by debbugs.gnu.org; 19 Jun 2022 22:41:58 +0000 Original-Received: from localhost ([127.0.0.1]:53400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o33cD-0006A4-TY for submit@debbugs.gnu.org; Sun, 19 Jun 2022 18:41:58 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o33cC-00069r-8m for 46493@debbugs.gnu.org; Sun, 19 Jun 2022 18:41:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VAbTJiWPCUxNhvz9uyJcytxJbGRYI2Vat7bqOVCvqQo=; b=ltq7TRg62xxfdfs79Lu9mAkadC SWg2d36OaQHW3XsmeutuELcgQ8UISK4W/cPCkXyBEEoI3CiDSp2VpZ+HdNFw5N9FW3LXLdAtVew/W jJ7kW8OY1agSlc698yiCRVYtr1E9IZzAa4tDKMAnghZUBAFWsItEFRAFJywFTLkzIZ2U=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o33c2-0003D9-7A; Mon, 20 Jun 2022 00:41:48 +0200 In-Reply-To: <878rpszuig.fsf@yahoo.com> (Po Lu's message of "Sun, 19 Jun 2022 20:51:19 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234819 Archived-At: Po Lu writes: >> However, we ignore the theme for everything else, so "emacs -Q" gives me >> an Emacs with a white background -- and a very dark region face. > > That shouldn't be problematic, right? Because we have the distant > foreground set to the GTK region foreground color, so there will always > be sufficient contrast. It's nonsensical of Emacs to use the Gtk theme for just one colour here. It should either use the Gtk theme for the background/foreground colours, too, or not use it at all. > Users using a non-default GTK stylesheet should know of the > consequences, and can simply customize the region face to use a > different background color. Emacs composes the colours we use here, and we choose colours that have the mixture we want. Our current approach leads to two bugs: With a dark theme, we get a nonsensically dramatic region face, and with a light theme, we get a region face that has too low contrast. That's an Emacs bug, and not something the user should have to deal with. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no