unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Ryan C. Thompson" <rct@thompsonclan.org>
Cc: 47127@debbugs.gnu.org
Subject: bug#47127: 27.1; ido file completion sorting should respect ido-case-fold, maybe?
Date: Fri, 24 Jun 2022 14:56:11 +0200	[thread overview]
Message-ID: <878rpmp6dw.fsf@gnus.org> (raw)
In-Reply-To: <d203861f-0c1d-8431-b375-c4eca5b36e24@thompsonclan.org> (Ryan C. Thompson's message of "Sat, 13 Mar 2021 16:57:03 -0500")

"Ryan C. Thompson" <rct@thompsonclan.org> writes:

> ;; Returns nil, as expected
> (let ((ido-case-fold nil))
>   (ido-file-lessp "a" "B"))
>
> ;; Should return t, but currently returns nil
> (let ((ido-case-fold t))
>   (ido-file-lessp "a" "B"))
>
> ;; Should still return t because case is the only difference
> (let ((ido-case-fold t))
>   (ido-file-lessp "A" "a"))
>
> At least, this is what makes sense to me.

I think this function should respect ido-case-fold, but special-casing
equal strings here seems pretty unnatural to me -- if you want to ignore
case, you want to ignore case.

So I've now made this change in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-06-24 12:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13 21:57 bug#47127: 27.1; ido file completion sorting should respect ido-case-fold, maybe? Ryan C. Thompson
2022-06-24 12:56 ` Lars Ingebrigtsen [this message]
2022-06-24 13:58   ` Ryan C. Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rpmp6dw.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=47127@debbugs.gnu.org \
    --cc=rct@thompsonclan.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).