From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#56110: 27+; switching from line-mode to char-mode Date: Sun, 26 Jun 2022 20:00:02 +0200 Message-ID: <878rpjl2zh.fsf@web.de> References: <875ykvs9gq.fsf@electra.home.arpa> <87wndaw84w.fsf@web.de> <87sfnyw6m7.fsf@web.de> <877d58obnn.fsf@web.de> <87k097mi81.fsf@web.de> <8735frqy2a.fsf@web.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25034"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56110-done@debbugs.gnu.org, Stefan Monnier To: signal3 Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 26 20:36:02 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5X74-0006Jz-28 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jun 2022 20:36:02 +0200 Original-Received: from localhost ([::1]:57676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5X73-0008D2-4d for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jun 2022 14:36:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5WZC-0002DM-9d for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 14:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55062) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5WZB-00021V-Ry for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 14:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5WZB-00012c-Q8 for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 14:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2022 18:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56110 X-GNU-PR-Package: emacs Original-Received: via spool by 56110-done@debbugs.gnu.org id=D56110.16562664203947 (code D ref 56110); Sun, 26 Jun 2022 18:01:01 +0000 Original-Received: (at 56110-done) by debbugs.gnu.org; 26 Jun 2022 18:00:20 +0000 Original-Received: from localhost ([127.0.0.1]:48959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5WYV-00011a-St for submit@debbugs.gnu.org; Sun, 26 Jun 2022 14:00:20 -0400 Original-Received: from mout.web.de ([212.227.17.12]:38237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5WYQ-00011B-9K for 56110-done@debbugs.gnu.org; Sun, 26 Jun 2022 14:00:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1656266404; bh=ds9E0GXuhqiUSpEszuqg/Ro585jbyQU+DVv0v34pST0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=TjvCKeee0pAuH21qvSw+WhqxFJvF1jSpWDIStLwbn/A9kwkLrBDgYNZe6L/59SmXY F0bZ4qlqy+svt6tS422j2x5yL1dE/4JlJv+laUGvahPXqHZVVZMlMutSr/7twjuOLM OyKvIcqRrBHNky3AP1zooyI3GBnbPuKIh9BbkCeU= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N2jWI-1ndyhz3pc4-013R39; Sun, 26 Jun 2022 20:00:04 +0200 In-Reply-To: (signal3@gmail.com's message of "Sun, 26 Jun 2022 16:01:43 +0000") X-Provags-ID: V03:K1:KQWlNRalTIOGspQ4BM+ymR51H1dsAiJ06QG/XPaNMUznaIAN3Qm Z6dtwFc6lubQKJkeQkDhAgKBeUhr3lWoFopUqmlYQLe6eITZuLZ3GMpKd6yHlpVKVN1xyXM p8mZVtnMpLTjDLeYLhWRpVi+gMPDPFtpxadtXAnKBlPxSGGyDp2Dhw/CJblIHTc2Ni3zdbU Mi+TGgYcVDVtr6hmnazoQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:m2/ThANdp5s=:JoEoSWqaXWpv4CSQ/wGY2g FlbNBC3le/VWIQTfZjxFIDNmXw3vzoYPeh0lha8G6Z2yT8RGsCEoc5HZJXKRdaj5HzFkiWUez QavJ1dPjhI5c1bAQGYhjUZKJKWwPQcgwdQm1W65kmbvfFL+IqlISziX1bdEXO+Y+Y10ScLkzo utZOCeBgdB7QHn+G3sK5n2+WrpzEiqXsNdL8GhPL0hw45YyJCACP+V2+Rgv/iNIn67T14EtQp qRy0NmYfRbJAeuYxDJTeFJFlgAwxHD3ZPqMMy4SGy2vg7JnxqF4VzbI9HelH/xC0KD0Q3+q4i WVI6qqoQSwOFg3Lw+F5tMKnzFrOOJKJtrCsRMO6olLJ18JCt4qsHz6ojbiajLLQAJRbSZuaMx i9sKvBqthufXxm9hTntHxlvlPGmXif4nn2RE30MVj04NqrNn1kbi9UJcA/Ng//RocgdxuUoBj bqhV0rZQ2whA7iftENcvcuq93LeOAMd5+D26N60jI+TpSvH6It12VarkuLjWWqXCAHdlBnmI2 tYMGB7J0KSJsCpdLxizWypzrngR7swU7qWXCdSenAF+pu8uwiU2B+LByN1o/mXcvod78tGV2p z5SX8BIi2l2Kk7R07xRishHBvvyoYjgWZ2s72eRpg1uSqZX2IjUaLlBzJeA0O5wmHjoefisB7 /FELn6kJZ/ATbY9h4zG+KiS2SLLc/OzgsI8OZr7rRh95UNTKal/7VpPsM28sbefZi6bNogmti Tv2fv8LzSgSHjAsbKvT2buZMUKMv98aNun4E3bq3JH2lmJA7MeEfvFj4UmSzZdoVSGkh5UoJ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235388 Archived-At: --=-=-= Content-Type: text/plain signal3 writes: > I may literally die from laughter when someone changes it back! See: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49186 > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44087 Oh no - not literally! Anyway - thanks for this important hint. Is installing this ok for everyone (Lars?)? I don't think anyone will miss the never intended behavior. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-term-char-mode-doc-string-correction.patch Content-Transfer-Encoding: quoted-printable =46rom bf8663415e31abb6b7b96baff2947d9b74b37b1a Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Sun, 26 Jun 2022 19:14:41 +0200 Subject: [PATCH] `term-char-mode' doc string correction This reverts 16860f6c5f "`term-char-mode' doc string clarification". Making switching to `term-char-mode' send partially given input obviously was changed by accident (in 5653b76d0b "Fix minor compilation issues with cl-lib and lexbind"). See Bug#44087, Bug#49186 and Bug#56110. * lisp/term.el (term-char-mode): Restore the version of the docstring describing the originally intended behavior. Break an overlong line. =2D-- lisp/term.el | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lisp/term.el b/lisp/term.el index a8e44b4c34..2a7eb72363 100644 =2D-- a/lisp/term.el +++ b/lisp/term.el @@ -1445,10 +1445,7 @@ term-send-function-key (defun term-char-mode () "Switch to char (\"raw\") sub-mode of term mode. Each character you type is sent directly to the inferior without -intervention from Emacs, except for the escape character (usually C-c). - -This command will send existing partial lines to the terminal -process." +intervention from Emacs, except for the escape character (usually C-c)." (interactive) ;; FIXME: Emit message? Cfr ilisp-raw-message (when (term-in-line-mode) @@ -1467,7 +1464,8 @@ term-char-mode (when (> (point) pmark) (unwind-protect (progn - (add-function :override (local 'term-input-sender) #'term-send-str= ing) + (add-function :override (local 'term-input-sender) + #'term-send-string) (end-of-line) (term-send-input)) (remove-function (local 'term-input-sender) #'term-send-string)))) =2D- 2.30.2 --=-=-= Content-Type: text/plain TIA, Michael. --=-=-=--