From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Date: Mon, 11 Jul 2022 09:50:11 +0800 Message-ID: <878rp01kq4.fsf@yahoo.com> References: <87tu7p1z75.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8107"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Alan Third , 56462@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 11 03:51:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAiZs-0001sx-S3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 03:51:13 +0200 Original-Received: from localhost ([::1]:36590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAiZr-0004IG-BR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jul 2022 21:51:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAiZi-0004Go-L3 for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 21:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44151) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAiZi-00045Y-Ar for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 21:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAiZi-0004kS-8a for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 21:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 01:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56462-submit@debbugs.gnu.org id=B56462.165750423018205 (code B ref 56462); Mon, 11 Jul 2022 01:51:02 +0000 Original-Received: (at 56462) by debbugs.gnu.org; 11 Jul 2022 01:50:30 +0000 Original-Received: from localhost ([127.0.0.1]:38048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAiZC-0004jZ-LY for submit@debbugs.gnu.org; Sun, 10 Jul 2022 21:50:30 -0400 Original-Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:44995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAiZA-0004jA-3c for 56462@debbugs.gnu.org; Sun, 10 Jul 2022 21:50:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657504222; bh=9GFFEfSiyg8ia0rH3WtToYmMzxYcpFFp+wAif+9k+5o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=QZwzFL9muvlkuPZU2P/0vhzHzx7DBKhk50sFL5HS4lrCZzf0z6hGFIDwB994PrtviYiGlGEYitZJ986oDqxFUwmvF/YzR6cecsnwmyHgr8E3Nbtw5LGinddLxfRbFikbmyaekseVzZOh0Qf6BKEgaBXCTMSO454vhnbpwmLeuDp0589X1Wn9XidjbjIwXIunyHOe9iTh39e/dH8AOz/ohd5QJ9rDsxiwCiHhWF9GqLPzRsUnfITpXAiDlxqvivLx3Wgi+NLPrBXAlmlcRgS7qMm2+7KG0VivEjRiLBUcuHT8r/6ihq8rthdcqzlvF3Nfz/nTZFnreSxNjAZZEtdfMg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657504222; bh=SHAEr6CcTAAKFxyldfL2qerKLVPiEL9U/eAoHOeXr1b=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=rJQBL3beb/XJRXVZ+LFc3SNuNvsFKQtln7g/u9/fgM6JhgsAxVHAdTbhwdeKjBVNE2PGzdPdv6z7B3+2ITxuO+6XLjnwMRHFJgYAv+re6k7+awUgGvrJBb8IEavENijrBMSIcuVuGy6fD8v6VsdB0xIpP0vldUF+mwVcCL4IwTUPwWmPpShTWcYZR20s3GfMRg+ntVmXpwE0drYslxaHEgCAQhIp9K6D1Iwu6NI0Oj8X+p7fsEUmhOhVXv4QwpfwcvwiGqBrasJrpsIFhi110ZLJWV1FsTeh2P63BRMG78SWcO3wgrQq0AwZpVN9lG9tjBB2wT7S3/UGRO8CqFraIg== X-YMail-OSG: .mw7OQcVM1kx6FuWrmI2dvZ6b1RFF2sNKQ0IROEPSHOyqTv0a63Cnxcq1DX2jS4 WyhxxIMv9SnNC43h53pAEXWI73RhUSPC97VSbqMzejfovCEiUgeDuSqoOcg3RfyxZqLCqXQ3vqKC 9JKgynv9xWgdq8LQpSxC8yepD4_.uqrWy8.Vxi7lgdLcDFxT3Za4V79BFTDGdhAA4FSvERXZWlMd Ihn54g8wwC2I984KhomyEQCMQqyC7kdlpYTy3dv7Z8qPgfFJ5A.g0JCjAkZNqFRHtawgdRw9BHui 7DvIm8UuwWMOBBgXqhGZUHFtv.ecbzNSXbJj0sy0ucsK5PooEnNdyvWUI5WppcIjg94cN2OkNI.O hjq7nMwIa1HleN9SIsLsxY4s2BYwxii_wUDBuVqxepFjIrOaCgZYQ9EF2yN4xCsHQx7G7AetTjKO NbzML.r61gOXS7lqThIzLz_DpjaBW5LkfKXZD5P6wFY.NVDKdEexqUoy1PTsPx.3WHE.5ZSghte9 XVEtE42kh1UJ5KW7yPwq2XjKHFvpcbaPRfw.zK_m63hl0jpCol1QBhgyD21.86Tn20y6tij5BI9V HUa76ad6KcWVWd6tqmnqefQvibFyf5gsV7vdOHWmFNG1MUM2Ub2Jq_9bVfXWq2xWFPi4WEKeMrO6 _VxlP_xECSZAVgJdlIGcxUAQYEZ8qIePS21CaRW3MqmKYNiEtzTKcNPtJZCLOp2QgmyEdylRn1wV t8Uel3yYiU5LsTKU.i9kopItXqapiAS8bT_YaBiGmkqorUDDQFSG9El95xkq4TlHbrq6Lcbvl4M2 3pHepdEO1hGUOR98y.9DhugCWy5BEQCNj0oFnNfBY4 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Mon, 11 Jul 2022 01:50:22 +0000 Original-Received: by hermes--canary-production-sg3-67975bbd4b-5klrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 31d65b5fe73489dbf23fd7118eb496d0; Mon, 11 Jul 2022 01:50:16 +0000 (UTC) In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sun, 10 Jul 2022 22:52:08 +0200") X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236599 Archived-At: Daniel Mart=C3=ADn writes: > Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > >>> >>> Thanks. But I think the use of static variables there is rather ugly, >>> and it would be much nicer if we replicated the `x_setup_relief_color' >>> logic there. >>> >>> Do you want to work on that, or should I? >> >> Thanks, I can give it a try. > > Here's a patch where the static variables are now proper fields in the > ns_output structure. Is that what you had in mind? Yes, this would be great. Thanks. Alan might have some comments; if he doesn't, I'll install this now.