From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good Date: Tue, 09 Aug 2022 20:03:46 +0200 Message-ID: <878rnxwayl.fsf@gnus.org> References: <83tu6ltlcq.fsf@gnu.org> <87y1vxwe0y.fsf@gnus.org> <83k07htjxf.fsf@gnu.org> <87o7wtwcu9.fsf@gnus.org> <83fsi5tj31.fsf@gnu.org> <87k07hwbgs.fsf@gnus.org> <838rnxti1k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25035"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57079@debbugs.gnu.org, stefan@marxist.se To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 09 20:14:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLTkB-0006QH-FT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 20:14:19 +0200 Original-Received: from localhost ([::1]:47092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLTkA-0002rE-JM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 14:14:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLTbC-0001ui-Gi for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 14:05:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55111) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLTbC-0002xC-0z for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 14:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLTbB-0006Kx-RO for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 14:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Aug 2022 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57079 X-GNU-PR-Package: emacs Original-Received: via spool by 57079-submit@debbugs.gnu.org id=B57079.166006824524231 (code B ref 57079); Tue, 09 Aug 2022 18:05:01 +0000 Original-Received: (at 57079) by debbugs.gnu.org; 9 Aug 2022 18:04:05 +0000 Original-Received: from localhost ([127.0.0.1]:44860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTaG-0006Il-SC for submit@debbugs.gnu.org; Tue, 09 Aug 2022 14:04:05 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTa7-0006I9-Uz for 57079@debbugs.gnu.org; Tue, 09 Aug 2022 14:04:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=z3uoTsf8l66jsDOHfatnL/OO0FOn/WDRLYgz/UM3hB0=; b=SaP+k+A/Phkt12ox12s0phDuW2 QUAewnBmLgoDIdTt0fpLAeWTElucuKINaEB/9zrMEqMekw7tvXt/RnsVt3T2rHVcrbXAs3phTKaYq TlrEQXqBUYA4lars9IQPDFViomq7Jbiqjys1+vLhdPg1cG9wDaK0bE2RGYE8QgunVMIQ=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLTZy-0006Kf-VU; Tue, 09 Aug 2022 20:03:49 +0200 In-Reply-To: <838rnxti1k.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Aug 2022 20:59:03 +0300") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEUKBAcjFitoYmSF foAoK2EmR5YnWqomWaz////PNYGJAAAAAWJLR0QIht6VegAAAAd0SU1FB+YICRE0A352PX4AAAF4 SURBVDjLlZNRbsMgDIaLtAOEigOscIKRHaCRoO+VMDsB5AIrXH92CIoTNQ/zQx74+G3z27lc/h9X o/Wn1vZm7Giv2hpj9bgAbfTNGvtlRv2Nl4y20nSVPMkmMQb6vDlfY3cuzsB2PJxmOlEo6eSxhKPw wTmWTahJOYCYAMPdWSa6m3Othci0AYUA5oqRURSGN6CWfAB+BbWkMHEAHdQEHHjsaQUZ3F4R567Y iiwAclccwVqFA9lAbF3BZoqgdpsE387bRe8I5EJuTeyBeL9p0FxKJDqASIceswxCIVBDBy08pheO ufuxHM8lPJ4XGZ9sUA+yO9aXm4Svv2yEngDMLyfVD2LW1pIrlkCgwjZcsfQKOQWPILCpq0ZiLXN9 sRF2CZnCbd8A+VhOFNgVX9K1BvnL3MUgd2PKVIKvIraFNrZdTLwEPTG1RHyAHbTSByB86qsV7nvQ u83hoMgrgT1Y+l3CTXsFLSktw3T4d2XbH3AO/1BcFZL9AU2AuNk9yzc1AAAAJXRFWHRkYXRlOmNy ZWF0ZQAyMDIyLTA4LTA5VDE3OjUyOjAzKzAwOjAwUiA95QAAACV0RVh0ZGF0ZTptb2RpZnkAMjAy Mi0wOC0wOVQxNzo1MjowMyswMDowMCN9hVkAAAAASUVORK5CYII= X-Now-Playing: Grace Jones's _Warm Leatherette_: "The Hunter Gets Captured By The Game" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239188 Archived-At: Eli Zaretskii writes: > My point is that it will never be as fast as the implementations > Stefan deleted, replacing them with seq-uniq. My point is that those > changes just made several places in Emacs slower, even after your > speedup, for no good reason. Those deleted functions, if they needed > to be deleted, should have been replaced by a different > implementation, which doesn't support TESTFN and is therefore faster, > as the original implementations, now deleted, were. The performance of the new seq-uniq (called with no TESTFN) is identical to the old gnus-delete-duplicates -- it's the same code.