From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#57150: 29.0.50; [PATCH] Add test coverage for overlay modification hooks Date: Sat, 13 Aug 2022 12:07:49 +0800 Message-ID: <878rns946i.fsf@localhost> References: <87ilmygjyv.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23310"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57150@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 13 06:07:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMiQZ-0005rK-Fn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Aug 2022 06:07:11 +0200 Original-Received: from localhost ([::1]:40740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oMiQX-0002Jx-VG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Aug 2022 00:07:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMiQR-0002Jj-38 for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 00:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oMiQQ-0001HH-Qp for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 00:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oMiQQ-0000D3-KJ for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 00:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Aug 2022 04:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57150-submit@debbugs.gnu.org id=B57150.1660363620797 (code B ref 57150); Sat, 13 Aug 2022 04:07:02 +0000 Original-Received: (at 57150) by debbugs.gnu.org; 13 Aug 2022 04:07:00 +0000 Original-Received: from localhost ([127.0.0.1]:59364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMiQO-0000Cm-0X for submit@debbugs.gnu.org; Sat, 13 Aug 2022 00:07:00 -0400 Original-Received: from mail-pj1-f51.google.com ([209.85.216.51]:53862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMiQJ-0000CX-Uy for 57150@debbugs.gnu.org; Sat, 13 Aug 2022 00:06:58 -0400 Original-Received: by mail-pj1-f51.google.com with SMTP id pm17so2593848pjb.3 for <57150@debbugs.gnu.org>; Fri, 12 Aug 2022 21:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc; bh=ia4j0pjPS/yDHLDlTV9bCiB0ghrok+tcDoov+h+1H14=; b=ZpZrGom37YbSik69TI3gaJibV5E0p4a0Gfs/lTdUn0GU2dFZWz50lSl5XVTJfGtnE+ WQYBgLw/MXluJ66VKgzoanXZHirdre2LFgG03pvNHrvuDVCBTXNjZLDlswrGpFhaIJs8 WovCjzczEyWZ/Hz/Xn2FTf+7a1Y0E+MUotDl6qv3YzSGzu9a3WUp2FiGFPCPGyLJWFvy ibREh6slhuXIMw9V7SNjo6ffm+oFNr1qrd2jx89jy9e4rJndnp8vjQN+1jWTeWEKNHXr NWOzuMyyYXsSE2gIRR7mkJZ7UvZ1nTrYTXsmGnF4o+skUvYxRZEUH6WBJwpEEE8VYMtK T39g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc; bh=ia4j0pjPS/yDHLDlTV9bCiB0ghrok+tcDoov+h+1H14=; b=i8ciRdjUHTKZwuXL12v0Nbtjce9sOADLcZtToxgNdHWClYN6sHVN9KvMv5Zw3DtKb7 e2bvjkA9XDpwm3i3aoKUXURFfuIXy6gOwsOEe/SShmI8Ve0HaQGhPqoT0XnSJeyXSklc g/nIVHYj7BNQkn5Pm84r923cqtpLFva+29nUvQ0UuPpbYH/RH5YCEZtK/MSYFT88GXWn 1f/j+xp3wNt4tsZKQGNMcLv/TQIzElCf8/1F/+tZ8EZi1ixDlkAy9TqWeuB1IbxUCtoB DPVx0bPkTdqsHDlc35uKHU9qOmKKt58IDCLLweuoXCOqZUywmDWXRJQrGOsbuOYuChNQ psqg== X-Gm-Message-State: ACgBeo3C6UDGXMqUraBpxSeaa6EdXQxADwU7aQ3SSvgpilPgmpO7yJcl ojYSHFJ3z59nXe0bWhXSUKI= X-Google-Smtp-Source: AA6agR6sm5mkiXxKztH/Hil4m+aTPHMbDGl6bqhLHIiL6hIdR/NymZiFvLRKYBz3IGQu1hqC5n3HVA== X-Received: by 2002:a17:90a:8001:b0:1f4:fe95:c420 with SMTP id b1-20020a17090a800100b001f4fe95c420mr7571343pjn.146.1660363609710; Fri, 12 Aug 2022 21:06:49 -0700 (PDT) Original-Received: from localhost ([2409:8a70:2bf:80b0:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id b12-20020a621b0c000000b005255f5d8f9fsm2431725pfb.112.2022.08.12.21.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Aug 2022 21:06:49 -0700 (PDT) In-Reply-To: <87ilmygjyv.fsf@rfc20.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239479 Archived-At: Matt Armstrong writes: > I noticed there was no explicit test against the overlay modification > hook boundary conditions. The attached patch adds some, which might be > nice to have if a person (possibly me) someday optimizes overlay > performance with a change in data structure. Just in case. Have you seen https://lists.gnu.org/archive/html/emacs-devel/2019-12/msg00323.html ? I am not sure how much progress have been made on the noverlay branch, but there was at least some existing test suitcase in there. Not sure if it has been merged or if your proposed patch is not covered. Best, Ihor