From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57502: 29.0.50; Issue with `or' clause of buffer-match-p Date: Sat, 03 Sep 2022 11:19:55 +0000 Message-ID: <878rn0k8mc.fsf@posteo.net> References: <87o7w0fwnt.fsf@gmail.com> <87ilm87f78.fsf@posteo.net> <878rn47f21.fsf@posteo.net> <87edwsk9cb.fsf@posteo.net> <835yi4ogqt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18746"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57502@debbugs.gnu.org, arstoffel@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 03 13:21:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oURDP-0004k7-Vs for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Sep 2022 13:21:32 +0200 Original-Received: from localhost ([::1]:42774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oURDO-0006Gy-O2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Sep 2022 07:21:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oURD1-0006Gm-LG for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2022 07:21:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oURCw-00031G-9c for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2022 07:21:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oURCv-0007tX-UF for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2022 07:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Sep 2022 11:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57502 X-GNU-PR-Package: emacs Original-Received: via spool by 57502-submit@debbugs.gnu.org id=B57502.166220400830239 (code B ref 57502); Sat, 03 Sep 2022 11:21:01 +0000 Original-Received: (at 57502) by debbugs.gnu.org; 3 Sep 2022 11:20:08 +0000 Original-Received: from localhost ([127.0.0.1]:41057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oURC4-0007re-8y for submit@debbugs.gnu.org; Sat, 03 Sep 2022 07:20:08 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:41047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oURC2-0007r5-3E for 57502@debbugs.gnu.org; Sat, 03 Sep 2022 07:20:06 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 6C1B1240105 for <57502@debbugs.gnu.org>; Sat, 3 Sep 2022 13:19:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662204000; bh=mzobjVQrju4fkcSjxZD7NJxezuCasTmbHPYqJ5yqhBc=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Sf8kN4Q79X+B6YfJLTu77fMPS0WMmwq9bADE4xby+1Vrwacotex0yU3JmaSQPwAF3 8gjHmfvOVqRdIAJqyQLy39uH9j13a4li/d5VvMvtKGMSrIv3mTOrO3zraS6KDG1gih 3mmp24klN58lET54RR9o2yOClJq4lu9HMbxh5+8n2rspg3jAto0NuMBIjwgD5Ky0hE EXGPuSf5Li5Jd3OthZEnfWLnQnmwH/Yu7mNbxYdYcg0nWeBWp77kn8zI7wu5aNNYtj JADyZVpaLCMSMJlHGeE+qJ9ep5+OcTo9OOy3OFUKlQLMoDIrqaQ7PkZy+9sMM7WYk5 nPu4UNBAvuJgw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MKXPT6FvHz9rxH; Sat, 3 Sep 2022 13:19:56 +0200 (CEST) In-Reply-To: <835yi4ogqt.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 03 Sep 2022 14:10:50 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241389 Archived-At: Eli Zaretskii writes: >> Cc: 57502@debbugs.gnu.org >> From: Philip Kaludercic >> Date: Sat, 03 Sep 2022 11:04:20 +0000 >> >> Are there any objections against applying this change? From what I see >> pcase is used elsewhere in seq, so it should be possible to recognise >> and expand the macro, right? > > I think we should avoid using pcase in subr.el, since subr.el is > loaded by loadup.el before pcase. But I see that this ship has sailed > already, sigh. There is no insistence from my end to use pcase, especially because at first I assumed it ought not to be used in subr.el. But from what I see there have been instances of the macro (in `called-interactively-p') for almost ten years now. So unless there is a plan to revert this trend, I'd use pcase to avoid simple issues like the one that caused this bug.