unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: David Ponce <da_vid@orange.fr>
Cc: 57652@debbugs.gnu.org, gregory@heytings.org
Subject: bug#57652: 29.0.50; Warning setting attribute of face ‘term’
Date: Thu, 08 Sep 2022 13:02:20 +0800	[thread overview]
Message-ID: <878rmua277.fsf@yahoo.com> (raw)
In-Reply-To: <5f92d116-3cfd-e4b4-0caf-b2337fa1bd7f@orange.fr> (David Ponce's message of "Wed, 7 Sep 2022 20:49:06 +0200")

David Ponce <da_vid@orange.fr> writes:

> diff --git a/term.el b/term.el
> index 797fb18074..c564a5429a 100644
> --- a/term.el
> +++ b/term.el
> @@ -755,17 +755,19 @@ ansi-term-color-vector
>     term-color-bright-cyan
>     term-color-bright-white])
>
> -(defcustom term-default-fg-color nil
> -  "If non-nil, default color for foreground in Term mode."
> +(defcustom term-default-fg-color 'unspecified
> +  "Default color for foreground in Term mode."
>    :group 'term
> -  :type '(choice (const nil) (string :tag "color")))
> +  :type '(choice (const unspecified)
> +                 (string :tag "color")))

Doesn't that change behavior?

i.e. wouldn't it be better to test that term-default-fg-color is not nil
wherever the face is actually made that color?





  reply	other threads:[~2022-09-08  5:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 18:49 bug#57652: 29.0.50; Warning setting attribute of face ‘term’ David Ponce
2022-09-08  5:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-09-08  8:22   ` David Ponce
2022-09-08  8:42     ` Eli Zaretskii
2022-09-08 12:34       ` David Ponce
2022-09-08  8:43     ` David Ponce
2022-09-08 11:44     ` Akib Azmain Turja via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rmua277.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=57652@debbugs.gnu.org \
    --cc=da_vid@orange.fr \
    --cc=gregory@heytings.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).