unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Felician Nemeth <felician.nemeth@gmail.com>
To: 58892@debbugs.gnu.org
Subject: bug#58892: 29.0.50; [PATCH] eglot-manual: Open the local info documentation
Date: Sun, 30 Oct 2022 10:05:25 +0100	[thread overview]
Message-ID: <878rkxk7fu.fsf@betli.tmit.bme.hu> (raw)

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

Eglot now has a beautiful documentation in info format.  This patch
let the user open it from Eglot's menu.

BTW, the menu is the mode-line and I think it cannot be accessed using
only the keyboard.  Would it make sense to put this menu in the "Tools"
part of the menu-bar as well?

Thanks.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-eglot-manual-Open-the-local-info-documentation.patch --]
[-- Type: text/x-diff, Size: 1072 bytes --]

From 2877c7ef6832b7f1bc3f3cfd46d8701dafa0af43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Felici=C3=A1n=20N=C3=A9meth?= <felician.nemeth@gmail.com>
Date: Sun, 30 Oct 2022 09:51:46 +0100
Subject: [PATCH] eglot-manual: Open the local info documentation

* lisp/progmodes/eglot.el (eglot-manual): Open the local info
documentation instead of the on-line version.
---
 lisp/progmodes/eglot.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index c587061837..1d67f37e34 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -1823,8 +1823,8 @@ eglot--mouse-call
                                            (call-interactively what)
                                            (force-mode-line-update t))))))
 
-(defun eglot-manual () "Open on-line documentation."
-  (interactive) (browse-url "https://github.com/joaotavora/eglot#readme"))
+(defun eglot-manual () "Open documentation."
+  (interactive) (info "(eglot)"))
 
 (easy-menu-define eglot-menu nil "Eglot"
   `("Eglot"
-- 
2.30.2


             reply	other threads:[~2022-10-30  9:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-30  9:05 Felician Nemeth [this message]
2022-10-30 10:18 ` bug#58892: 29.0.50; [PATCH] eglot-manual: Open the local info documentation Eli Zaretskii
2022-10-30 12:42   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-30 12:53     ` Eli Zaretskii
2022-10-30 13:32   ` Felician Nemeth
2022-10-30 14:02     ` Eli Zaretskii
2022-10-31 13:22       ` João Távora
2022-10-31 13:36         ` Eli Zaretskii
2022-11-11 13:05         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rkxk7fu.fsf@betli.tmit.bme.hu \
    --to=felician.nemeth@gmail.com \
    --cc=58892@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).