From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Akib Azmain Turja via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58985: 29.0.50; Have auth-source-pass behave more like other back ends Date: Thu, 10 Nov 2022 00:21:11 +0600 Message-ID: <878rkkoup4.fsf__32689.052277577$1668018802$gmane$org@disroot.org> References: <87wn8cb0ym.fsf@neverwas.me> <874jvdardn.fsf__3771.40490324877$1667692584$gmane$org@neverwas.me> <87pme09vis.fsf@gmx.de> Reply-To: Akib Azmain Turja Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11738"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Damien Cassou , emacs-erc@gnu.org, 58985@debbugs.gnu.org, "J.P." To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 09 19:33:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ospsu-0002kG-3i for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Nov 2022 19:33:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ospsm-0005kB-3H; Wed, 09 Nov 2022 13:33:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ospsk-0005js-Nb for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 13:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ospsk-0004jT-Eq for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 13:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ospsj-0004lx-VS for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 13:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Akib Azmain Turja Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Nov 2022 18:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58985-submit@debbugs.gnu.org id=B58985.166801873918275 (code B ref 58985); Wed, 09 Nov 2022 18:33:01 +0000 Original-Received: (at 58985) by debbugs.gnu.org; 9 Nov 2022 18:32:19 +0000 Original-Received: from localhost ([127.0.0.1]:40867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osps2-0004kg-RA for submit@debbugs.gnu.org; Wed, 09 Nov 2022 13:32:19 -0500 Original-Received: from knopi.disroot.org ([178.21.23.139]:46118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osprw-0004kM-Sl for 58985@debbugs.gnu.org; Wed, 09 Nov 2022 13:32:17 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 56FB941092; Wed, 9 Nov 2022 19:32:11 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OaRNNUofhtIf; Wed, 9 Nov 2022 19:32:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1668018729; bh=2DdFbtvprzGWrPiSMwDeeN5GnJMgfoP26EHEihVzyMI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EVWZ6vA6QPTAtr+5iC+vi1Dx9CdqZ+88hXwV54XBRUi+JCZ+6Lry+mwFr+NwOfBsm otIuZoSHuhfE+jxxmaVtRB4t36nBer+IaITh5OOKzwtWWVxlEi+NU1dJnspThj0Y3p p/hcINrTApZyhbox7zT1AFGvUPDU9cluEEZhwjv3taUPWLQfqX7a+ggcHBaXX/1kKf QqO8NefAc5zs8NCCIQOMX80fli44wPFWCUedUbRsBZZ18VCYY2Sc/SdSpqGy7tVJTD uMYpkvqMg+SFusfU2VCDnGcCyn5BFzd5YB37QHPBikRHssoQ1/WFF8MLgbRf36Jd7B ggCaHMxAbCVAw== In-Reply-To: <87pme09vis.fsf@gmx.de> (Michael Albinus's message of "Sun, 06 Nov 2022 12:23:23 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247461 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Michael Albinus writes: > "J.P." writes: > > Hi, > >> v2. Respect existing user option. > > I'm not familiar with the auth-source-pass.el implementation, so I > cannot speak too much about your patch. Reading it roughly, I haven't > found serious flaws, 'tho. It has a serious flaw AFAIK. I have a password entry "akib@disroot.org", and this legitimate search query doesn't find it: (auth-source-search :host "disroot.org") But if specify the user, it finds the entry: (auth-source-search :host "disroot.org" :user "akib") And the entries can also be ambiguous. For example, the entry at path "foo.org/bar.net" might be interpreted as the password of bar.net, or as the password of the user "bar.net" on "foo.org". The current implementation seems to interpret such entries unpredictably. > > However :-) > > +(defcustom auth-source-pass-standard-search nil > + "Whether to use more standardized search behavior. > +When nil, the password-store backend works like it always has and > +considers at most one `:user' search parameter and returns at > +most one result. With t, it tries to more faithfully mimic other > +auth-source backends." > + :version "29.1" > + :type 'boolean) > > - The name of this user option as well as its docstring are focussed on > the current behavior. People won't know what "mimic other auth-source > backends" would mean. Please describe the effect w/o that comparison, > and pls give it a name based on its effect, and not "...-standard-searc= h". I agree. This variable should be something like "auth-source-pass-old-search" (or even "...-obsolete-search"). And the default should be nil, because it fixes many bugs, and it's pointless to disable the fixes by the default. > > - I'm missing the documentation in doc/misc/auth.texi and etc/NEWS. What documentation? Of this change or anything else? I think we should focus on the implement before writing documentation. > > Best regards, Michael. > > > =2D-=20 Akib Azmain Turja, GPG key: 70018CE5819F17A3BBA666AFE74F0EFA922AE7F5 Fediverse: akib@hostux.social Codeberg: akib emailselfdefense.fsf.org | "Nothing can be secure without encryption." --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEyVTKmrtL6kNBe3FRVTX89U2IYWsFAmNr75cACgkQVTX89U2I YWtZAhAA2023wqxFSfifBQ3Z321ua/gZyM0vR9hY5V9h/Z9RO4m1+JxpbF/yJ56a V4pCfiN1b+q/YflO5r+k2EeMjxIYwBrFt6A2GI3LBMO43GIffaour0sv94EtGSU9 kh3fYS+9J9uLjCqupm4058PHBFHkUtbu9r3P4lwKPzxbXDbasb8my3+Jc/BcePhj pgI0DbS88LiLLjZzN0C1kYsfF6r+ay6Jh4EN0k6VAG4EeSAlh/w6iUmonbX5J2sR lIvUU910jMj+uImUmvpHpvy1KlpYT6OCT3R+PfqA0e4KGQMLJGcDTill8XTvxi2u iVkWiGDffspPfE6I6FnHd1kqFUGe+zv3vKvy94wzyRfz9ymzugZWOJYflGsLFRxK NKhhXUjBFfdEA7Fo8+T78c/VmOCaNPpjtUqAidfrtsdDUF8fQ93FU1CqWDsUXm+K jjxUVaKP8z+xvv2f+KTlTCzP2T0THEwghlZQR02Dtmuq0uXPnbwrwjplkrIKSyTe euak4q4RLEVn196clLqjJwcbHZjGSGJEaMtjYwFZ4kiwoxU3VyYez0sz7cWitK5N TcTDplhQ3hoHXbmviJIBoTPqGLH38gt9FmfKlQ8JXwQ0XNWtMoHKfyI4fkLUMQ0n tNLk9Y/sWWZlNgJydZXinOE+XCbCKiA95ysds0nUvHR6BImHJlA= =HYbU -----END PGP SIGNATURE----- --=-=-=--