From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#59314: 29.0.50; EUDC and message-mode header completion Date: Wed, 16 Nov 2022 11:46:00 -0800 Message-ID: <878rka1y4n.fsf@ericabrahamsen.net> References: <87a64q7p25.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34972"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alexander Adolf , 59314@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 16 20:47:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovONK-0008qn-P4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Nov 2022 20:47:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovONG-0002P7-W7; Wed, 16 Nov 2022 14:47:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovONC-0002Ld-5t for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 14:47:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovONB-00077o-Tp for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 14:47:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovONB-0008Ob-Kw for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 14:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2022 19:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59314 X-GNU-PR-Package: emacs Original-Received: via spool by 59314-submit@debbugs.gnu.org id=B59314.166862797532214 (code B ref 59314); Wed, 16 Nov 2022 19:47:01 +0000 Original-Received: (at 59314) by debbugs.gnu.org; 16 Nov 2022 19:46:15 +0000 Original-Received: from localhost ([127.0.0.1]:58249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovOMQ-0008NW-P2 for submit@debbugs.gnu.org; Wed, 16 Nov 2022 14:46:15 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:36516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovOMO-0008NI-JM for 59314@debbugs.gnu.org; Wed, 16 Nov 2022 14:46:14 -0500 Original-Received: from localhost (unknown [76.135.104.211]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 510E3FA0E3; Wed, 16 Nov 2022 19:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1668627966; bh=c/jJK1DCN2zhN/69wfQ+YwZTE7cwvFnC3sYHnoyaGvg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=w2g7yvoK2Vc5dGgo3PcmIYH2QUICvGfEtE1dOhy0jvynV4i0zUhaUsFvNgCh335Sk oNwTVlxBFzTk/vxJCXSKzGNlDMw1VJrWSw8NSI93kyX4chDOZwbGqdPwfvmU013Di+ s9ot8cnWV8j/5nCzCcAcV3ZcJBWVHGz1U4X0B9Q4= In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 16 Nov 2022 14:18:06 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248047 Archived-At: On 11/16/22 14:18 PM, Thomas Fitzsimmons wrote: > Hi Eric, > > Thanks for filing this. > > Eric Abrahamsen writes: > >> Address completion in message-mode has stopped working in master, >> possibly as a result of 0e25a39e69acca0324c326ea8e46b1725594bff5. This >> has been reported for several contact-management backends that expect to >> have their completions available with . >> >> `completion-at-point-functions' contains '(eudc-capf-complete >> message-completion-function t) at this point -- `eudc-capf-complete' >> returns no matches, and no other functions in the list are consulted. > > I just checked and I didn't think the recent patch I pushed, > 0e25a39e6..., should have affected completion-at-point-functions. It > did change the default of eudc-server-hotlist from `nil' to > `(("localhost" . ecomplete) ("localhost" . mailabbrev))". I thought > that should only affect EUDC users who have not customized > eudc-server-hotlist. > > `eudc-capf-complete' was added to `message-mode' in commit > 620ac6735... I'm pretty sure that commenting out this line in > message.el will restore prior behaviour, but I don't yet know what prior > behaviour should be (see below). > > (add-hook 'completion-at-point-functions #'message-completion-function nil t) > >> On gnus.general, someone using BBDB and corfu reported that this recipe >> fixed the problem: >> >> (setq eudc-server-hotlist '(("localhost" . bbdb))) >> >> (add-hook 'message-mode-hook >> (lambda () >> (setq-local completion-at-point-functions >> (delq 'message-completion-function >> completion-at-point-functions)))) >> >> Someone else *not* using corfu reported that that didn't work for them. >> Dunno. > > I'm not sure what the out-of-the-box behaviour here is meant to be. Can > you make a recipe starting from "emacs -Q" (including adding dummy email > addresses somewhere) that makes completion work how you want it to? For > me: > > emacs -Q > C-x m TAB > > inserts four spaces and prints in *Messages*: > > Loading eudcb-ecomplete...done > Loading eudcb-mailabbrev...done > > (Those are new, due to 0e25a39e6... but I thought should be harmless.) Yuck, it's been a long time since I looked at this... In emacs -Q, message-mode `completion-at-point-functions' is: (eudc-capf-complete message-completion-function t) Actually that's what it is in my regular Emacs, as well. All I'd need for EBDB (and BBDB and everything else) is for `message-completion-function' to get called, which it isn't. I believe you could allow this by having `eudc-capf-complete' return nil, or have `eudc-capf-message-expand-name' return a `(list beg end )' structure that includes the prop `:exclusive 'no' at the end of it. That would allow a fallthrough to the next function. In fact this whole message-mode thing is an impossible tangle, burritos within burritos, and it would be great to get rid of it altogether. `message-completion-function' already looks at where it is in the message buffer, and calls `message-expand-name' if it's in a "name" header. That function consults `message-expand-name-databases', and *that's* where EBDB should put its completion table, except `message-expand-name-databases' is hardcoded to (or 'eudc 'bbdb) for no reason. So I need to clobber `message-expand-name' altogether. And EUDC having a function on `completion-at-point-functions' is wrapping yet another burrito outside the existing burritos, because now EUDC has a completion function both inside and outside message-mode's own completion machinery. In fact the docstring of `eudc-capf-message-expand-name' makes it sound like it thinks it's being called as part of `message-expand-name', but now it isn't -- it's being called as part of the capf machinery. Or rather, it could potentially be called in both places. I think a half-stick of dynamite is the only real solution. Eric