bug#60308: 30.0.50; Can't read some PDF files any more

bug#60308: 30.0.50; Can't read some PDF files any more

[Jean Louis]

[-- Attachment #1: Type: text/plain, Size: 3541 bytes --]


The attached PDF file I cannot read with emacs -Q including many other
files, not appearing for unknown reason. Before month or more it was all
working well.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.17.6, Xaw3d scroll bars) of 2022-12-22 built on
 protected.rcdrun.com
Repository revision: e98ab3f458b25812eff1b3a7ce6429caece4c891
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Parabola GNU/Linux-libre

Configured using:
 'configure --with-x-toolkit=lucid --with-mailutils'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: @im=exwm-xim
  locale-coding-system: utf-8-unix

Major mode: Dired by name

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny rfc822
mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util
text-property-search time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils shell subr-x pcomplete comint
ansi-osc ansi-color ring doc-view filenotify jka-compr image-mode exif
dired-aux cl-loaddefs cl-lib dired dired-loaddefs rmc iso-transl tooltip
cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
xinput2 x multi-tty make-network-process emacs)

Memory information:
((conses 16 51499 5773)
 (symbols 48 6414 2)
 (strings 32 18519 1600)
 (string-bytes 1 533945)
 (vectors 16 13003)
 (vector-slots 8 182726 11451)
 (floats 8 57 22)
 (intervals 56 451 0)
 (buffers 984 14))

-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/

[-- Attachment #2: erinn-clark-attack-appelbaum.pdf --]
[-- Type: application/pdf, Size: 34898 bytes --]

bug#60308: 30.0.50; Can't read some PDF files any more

[Jean Louis]

I can't read this file with emacs -Q:

https://gnu.support/files/tmp/2023-01-05/FR%20205.pdf

I see that change happened before weeks.

--
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/

bug#60308: 30.0.50; Can't read some PDF files any more

[Ihor Radchenko]

Jean Louis <bugs@gnu.support> writes:

> I can't read this file with emacs -Q:
>
> https://gnu.support/files/tmp/2023-01-05/FR%20205.pdf

I can reproduce on Emacs 30 and Emacs 29, but not on Emacs 28

Recipe: emacs -Q /path/to/the/linked/downloaded/pdf

Observed: empty buffer
Expected: PDF page is displayed

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

bug#60308: 30.0.50; Can't read some PDF files any more

[Eli Zaretskii]

> Cc: 60308@debbugs.gnu.org
> From: Ihor Radchenko <yantar92@posteo.net>
> Date: Thu, 05 Jan 2023 17:12:21 +0000
> 
> Jean Louis <bugs@gnu.support> writes:
> 
> > I can't read this file with emacs -Q:
> >
> > https://gnu.support/files/tmp/2023-01-05/FR%20205.pdf
> 
> I can reproduce on Emacs 30 and Emacs 29, but not on Emacs 28
> 
> Recipe: emacs -Q /path/to/the/linked/downloaded/pdf
> 
> Observed: empty buffer
> Expected: PDF page is displayed

Can someone bisect this, please?

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

>>> I can't read this file with emacs -Q:
>>>
>>> https://gnu.support/files/tmp/2023-01-05/FR%20205.pdf
>>
>> I can reproduce on Emacs 30 and Emacs 29, but not on Emacs 28
>>
>> Recipe: emacs -Q /path/to/the/linked/downloaded/pdf
>>
>> Observed: empty buffer
>> Expected: PDF page is displayed
>
> Can someone bisect this, please?
>

FTR, that file opens fine here, with Emacs 29 at ec172d748f, at 
d2a9dae400, at a6bad4d60f, at c59b8dfefa... and with Emacs 28.

bug#60308: 30.0.50; Can't read some PDF files any more

[Jean Louis]

With latest Emacs, pulled from git before minutes, I can't see first
page of that file, but if I press page down, I can see subsequent
pages.

I have been observing similar with other PDF files.

Including I can't see some PNGs

--
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/

bug#60308: 30.0.50; Can't read some PDF files any more

[Eli Zaretskii]

> Date: Thu, 05 Jan 2023 20:58:24 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: Ihor Radchenko <yantar92@posteo.net>, 60308@debbugs.gnu.org, 
>     bugs@gnu.support
> 
> >>> I can't read this file with emacs -Q:
> >>>
> >>> https://gnu.support/files/tmp/2023-01-05/FR%20205.pdf
> >>
> >> I can reproduce on Emacs 30 and Emacs 29, but not on Emacs 28
> >>
> >> Recipe: emacs -Q /path/to/the/linked/downloaded/pdf
> >>
> >> Observed: empty buffer
> >> Expected: PDF page is displayed
> >
> > Can someone bisect this, please?
> >
> 
> FTR, that file opens fine here, with Emacs 29 at ec172d748f, at 
> d2a9dae400, at a6bad4d60f, at c59b8dfefa... and with Emacs 28.

Thanks.

So maybe the problem is updates to libraries/executables we use for
viewing PDF?  AFAIR, this is DocView, and it use Ghostscript and
libpng?  Maybe both Jean and Ihor had their systems updated recently?

bug#60308: 30.0.50; Can't read some PDF files any more

[Stephen Berman]

[-- Attachment #1: Type: text/plain, Size: 1754 bytes --]

On Fri, 06 Jan 2023 08:40:13 +0200 Eli Zaretskii <eliz@gnu.org> wrote:

>> Date: Thu, 05 Jan 2023 20:58:24 +0000
>> From: Gregory Heytings <gregory@heytings.org>
>> cc: Ihor Radchenko <yantar92@posteo.net>, 60308@debbugs.gnu.org,
>>     bugs@gnu.support
>>
>> >>> I can't read this file with emacs -Q:
>> >>>
>> >>> https://gnu.support/files/tmp/2023-01-05/FR%20205.pdf
>> >>
>> >> I can reproduce on Emacs 30 and Emacs 29, but not on Emacs 28
>> >>
>> >> Recipe: emacs -Q /path/to/the/linked/downloaded/pdf
>> >>
>> >> Observed: empty buffer
>> >> Expected: PDF page is displayed
>> >
>> > Can someone bisect this, please?
>> >
>>
>> FTR, that file opens fine here, with Emacs 29 at ec172d748f, at
>> d2a9dae400, at a6bad4d60f, at c59b8dfefa... and with Emacs 28.
>
> Thanks.
>
> So maybe the problem is updates to libraries/executables we use for
> viewing PDF?  AFAIR, this is DocView, and it use Ghostscript and
> libpng?  Maybe both Jean and Ihor had their systems updated recently?

I see the problem in Emacs 29 and master, but not in Emacs 28, on the
same system, i.e. with the same image libraries.  When the bad display
appears, the following entry appears in *Messages*:

Error parsing SVG image: XML parse error: Error domain 1 code 68 on line
7393 column 18 of data: StartTag: invalid element name

This seems to comes from svg_load_image in image.c.  I started Emacs 29
with -Q in gdb after setting a breakpoint at svg_load_image, opened the
PDF file, hit the breakpoint and stepped through till the bad display
appeared.  The ouput of bt full is attached.  (I also ran Emacs 28 under
gdb with the same breakpoint, and there visiting the PDF file does not
hit the breakpoint.)

Steve Berman



[-- Attachment #2: backtrace --]
[-- Type: application/octet-stream, Size: 32293 bytes --]

(gdb) c
Continuing.

Thread 1 "emacs" hit Breakpoint 3, svg_load_image (f=f@entry=0x5555562e3660, img=img@entry=0x55555607b260, contents=contents@entry=0x555556c1b5b0 "<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" version=\"1.1\" width=\"826.38888pt\" height=\"1169.4445pt\" viewBox=\"0 0 826.38888 1169.4445\">\n<defs>\n<clipPath id=\"clip_1"..., size=2360606, filename=0x55555613b210 "/tmp/docview1000/FR 205.pdf-7039e6f9886aceec549c36d51591d258/page-1.svg") at /home/steve/src/emacs/emacs-29/src/image.c:11180
11180	{
(gdb) bt full
#0  svg_load_image
    (f=f@entry=0x5555562e3660, img=img@entry=0x55555607b260, contents=contents@entry=0x555556c1b5b0 "<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" version=\"1.1\" width=\"826.38888pt\" height=\"1169.4445pt\" viewBox=\"0 0 826.38888 1169.4445\">\n<defs>\n<clipPath id=\"clip_1"..., size=2360606, filename=0x55555613b210 "/tmp/docview1000/FR 205.pdf-7039e6f9886aceec549c36d51591d258/page-1.svg")
    at /home/steve/src/emacs/emacs-29/src/image.c:11180
        rsvg_handle = <optimized out>
        viewbox_width = <optimized out>
        viewbox_height = <optimized out>
        err = 0x5555557d76e2 <slurp_file+235>
        pixbuf = <optimized out>
        width = 2360606
        height = 261050041
        pixels = <optimized out>
        rowstride = <optimized out>
        wrapped_contents = <optimized out>
        wrapped_size = <optimized out>
        empty_errmsg = <optimized out>
        errmsg = <optimized out>
        errlen = <optimized out>
        css = <optimized out>
        input_stream = <optimized out>
        base_file = <optimized out>
        lcss = <optimized out>
        gviewbox_width = 3.2759516713149693e-319
        gviewbox_height = 1.5548685593048827e-317
        has_viewbox = 0
#1  0x00005555557dd619 in svg_load (f=0x5555562e3660, img=0x55555607b260)
    at /home/steve/src/emacs/emacs-29/src/lisp.h:1672
        fd = 13
        file = <optimized out>
        size = 2360606
        contents = 0x555556c1b5b0 "<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" version=\"1.1\" width=\"826.38888pt\" height=\"1169.4445pt\" viewBox=\"0 0 826.38888 1169.4445\">\n<defs>\n<clipPath id=\"clip_1"...
        success_p = false
        file_name = <optimized out>
        base_uri = XIL(0x55555608f8d4)
#2  0x00005555557dfb46 in lookup_image
    (f=0x5555562e3660, spec=spec@entry=XIL(0x5555560d97d3), face_id=<optimized out>) at /home/steve/src/emacs/emacs-29/src/image.c:2910
        img = 0x55555607b260
        hash = 611508767724881678
        face = <optimized out>
        foreground = 4278190080
        background = 4294967295
        font_size = 13
        font_family = 0x555555e8e960 "DejaVu Sans Mono"
#3  0x000055555561909e in handle_single_display_spec
    (it=it@entry=0x7fffffffae50, spec=<optimized out>, 
    spec@entry=XIL(0x5555560d97d3), object=object@entry=XIL(0x55555608026d), overlay=overlay@entry=XIL(0x555556a04b7d), position=position@entry=0x7fffffffafa0, bufpos=bufpos@entry=1, display_replaced=0, frame_window_p=true, enable_eval_p=true) at /home/steve/src/emacs/emacs-29/src/xdisp.c:6100
        retval = 1
        form = <optimized out>
        location = XIL(0)
        value = XIL(0x5555560d97d3)
        start_pos = {
          charpos = 1,
          bytepos = 1
        }
        itdata = <optimized out>
        valid_p = <optimized out>
#4  0x00005555556193d0 in handle_display_spec
    (it=it@entry=0x7fffffffae50, spec=spec@entry=XIL(0x5555560d97d3), object=object@entry=XIL(0x55555608026d), overlay=XIL(0x555556a04b7d), position=position@entry=0x7fffffffafa0, bufpos=bufpos@entry=1, frame_window_p=true)
    at /home/steve/src/emacs/emacs-29/src/xdisp.c:5563
        replacing = 0
        enable_eval = true
#5  0x0000555555619a15 in handle_display_prop (it=0x7fffffffae50)
    at /home/steve/src/emacs/emacs-29/src/xdisp.c:5471
        propval = XIL(0x5555560d97d3)
--Type <RET> for more, q to quit, c to continue without paging--
        object = XIL(0x55555608026d)
        overlay = XIL(0x555556a04b7d)
        position = 0x7fffffffafa0
        bufpos = 1
        display_replaced = 0
#6  0x000055555561438e in handle_stop (it=it@entry=0x7fffffffae50)
    at /home/steve/src/emacs/emacs-29/src/xdisp.c:3978
        handled = HANDLED_NORMALLY
        handle_overlay_change_p = true
        p = 0x555555880480 <it_props+32>
#7  0x0000555555614563 in reseat
    (it=it@entry=0x7fffffffae50, pos=..., force_p=force_p@entry=true)
    at /home/steve/src/emacs/emacs-29/src/xdisp.c:7513
        original_pos = 1
#8  0x0000555555614f72 in init_iterator
    (it=it@entry=0x7fffffffae50, w=w@entry=0x5555562e38b0, charpos=1, bytepos=<optimized out>, row=<optimized out>, base_face_id=base_face_id@entry=DEFAULT_FACE_ID) at /home/steve/src/emacs/emacs-29/src/xdisp.c:3488
        remapped_base_face_id = <optimized out>
        body_width = <optimized out>
        body_height = <optimized out>
#9  0x000055555561f3b8 in start_display
    (it=it@entry=0x7fffffffae50, w=w@entry=0x5555562e38b0, pos=...)
    at /home/steve/src/emacs/emacs-29/src/xdisp.c:3595
        row = <optimized out>
        first_vpos = 0
#10 0x00005555555f07d6 in buffer_posn_from_coords
    (w=w@entry=0x5555562e38b0, x=x@entry=0x7fffffffd5e8, y=y@entry=0x7fffffffd5ec, pos=pos@entry=0x7fffffffd600, object=object@entry=0x7fffffffd5f8, dx=dx@entry=0x7fffffffd5d8, dy=0x7fffffffd5dc, width=0x7fffffffd5e0, height=0x7fffffffd5e4) at /home/steve/src/emacs/emacs-29/src/dispnew.c:5547
        it = {
          window = XIL(0x5555562e38b5),
          w = 0x5555562e38b0,
          f = 0x5555562e3660,
          method = GET_FROM_BUFFER,
          stop_charpos = 913549,
          prev_stop = 0,
          base_level_stop = 0,
          end_charpos = 913549,
          narrowed_begv = 0,
          narrowed_zv = 0,
          locked_narrowing_begv = 0,
          locked_narrowing_zv = 0,
          s = 0x0,
          string_nchars = 0,
          multibyte_p = false,
          tab_line_p = false,
          header_line_p = false,
          string_from_display_prop_p = false,
          string_from_prefix_prop_p = false,
          from_disp_prop_p = true,
          ellipsis_p = false,
          avoid_cursor_p = false,
          dp = 0x0,
          dpvec = 0x0,
          dpend = 0x0,
          dpvec_char_len = 0,
          dpvec_face_id = 0,
          saved_face_id = 0,
          ctl_chars = {XIL(0) <repeats 16 times>},
          start = {
            pos = {
              charpos = 1,
              bytepos = 1
            },
            overlay_string_index = -1,
            string_pos = {
              charpos = -1,
              bytepos = -1
            },
            dpvec_index = -1
          },
          current = {
            pos = {
              charpos = 913549,
              bytepos = 913549
--Type <RET> for more, q to quit, c to continue without paging--c
            },
            overlay_string_index = -1,
            string_pos = {
              charpos = -1,
              bytepos = -1
            },
            dpvec_index = -1
          },
          n_overlay_strings = 0,
          overlay_strings_charpos = 0,
          overlay_strings = {XIL(0) <repeats 16 times>},
          string_overlays = {XIL(0) <repeats 16 times>},
          string = XIL(0),
          from_overlay = XIL(0x555556a04b7d),
          stack = {{
              string = XIL(0),
              string_nchars = 0,
              end_charpos = 913549,
              stop_charpos = 913549,
              prev_stop = 0,
              base_level_stop = 0,
              cmp_it = {
                stop_pos = 0,
                id = -1,
                ch = 0,
                rule_idx = 0,
                lookback = 0,
                nglyphs = 0,
                reversed_p = false,
                parent_it = 0x7fffffffae50,
                charpos = 0,
                nchars = 0,
                nbytes = 0,
                from = 0,
                to = 0,
                width = 0
              },
              face_id = 16,
              u = {
                image = {
                  object = XIL(0),
                  slice = {
                    x = XIL(0),
                    y = XIL(0),
                    width = XIL(0),
                    height = XIL(0)
                  },
                  image_id = 0
                },
                stretch = {
                  object = XIL(0)
                },
                xwidget = {
                  object = XIL(0)
                }
              },
              position = {
                charpos = 913549,
                bytepos = 913549
              },
              current = {
                pos = {
                  charpos = 913549,
                  bytepos = 913549
                },
                overlay_string_index = -1,
                string_pos = {
                  charpos = -1,
                  bytepos = -1
                },
                dpvec_index = -1
              },
              from_overlay = XIL(0),
              area = TEXT_AREA,
              method = GET_FROM_BUFFER,
              paragraph_embedding = L2R,
              multibyte_p = false,
              string_from_display_prop_p = false,
              string_from_prefix_prop_p = false,
              display_ellipsis_p = false,
              avoid_cursor_p = false,
              bidi_p = false,
              from_disp_prop_p = false,
              line_wrap = WINDOW_WRAP,
              voffset = 0,
              space_width = XIL(0),
              font_height = XIL(0)
            }, {
              string = XIL(0),
              string_nchars = 0,
              end_charpos = 0,
              stop_charpos = 0,
              prev_stop = 0,
              base_level_stop = 0,
              cmp_it = {
                stop_pos = 0,
                id = 0,
                ch = 0,
                rule_idx = 0,
                lookback = 0,
                nglyphs = 0,
                reversed_p = false,
                parent_it = 0x0,
                charpos = 0,
                nchars = 0,
                nbytes = 0,
                from = 0,
                to = 0,
                width = 0
              },
              face_id = 0,
              u = {
                image = {
                  object = XIL(0),
                  slice = {
                    x = XIL(0),
                    y = XIL(0),
                    width = XIL(0),
                    height = XIL(0)
                  },
                  image_id = 0
                },
                stretch = {
                  object = XIL(0)
                },
                xwidget = {
                  object = XIL(0)
                }
              },
              position = {
                charpos = 0,
                bytepos = 0
              },
              current = {
                pos = {
                  charpos = 0,
                  bytepos = 0
                },
                overlay_string_index = 0,
                string_pos = {
                  charpos = 0,
                  bytepos = 0
                },
                dpvec_index = 0
              },
              from_overlay = XIL(0),
              area = LEFT_MARGIN_AREA,
              method = GET_FROM_BUFFER,
              paragraph_embedding = NEUTRAL_DIR,
              multibyte_p = false,
              string_from_display_prop_p = false,
              string_from_prefix_prop_p = false,
              display_ellipsis_p = false,
              avoid_cursor_p = false,
              bidi_p = false,
              from_disp_prop_p = false,
              line_wrap = TRUNCATE,
              voffset = 0,
              space_width = XIL(0),
              font_height = XIL(0)
            }, {
              string = XIL(0),
              string_nchars = 0,
              end_charpos = 0,
              stop_charpos = 0,
              prev_stop = 0,
              base_level_stop = 0,
              cmp_it = {
                stop_pos = 0,
                id = 0,
                ch = 0,
                rule_idx = 0,
                lookback = 0,
                nglyphs = 0,
                reversed_p = false,
                parent_it = 0x0,
                charpos = 0,
                nchars = 0,
                nbytes = 0,
                from = 0,
                to = 0,
                width = 0
              },
              face_id = 0,
              u = {
                image = {
                  object = XIL(0),
                  slice = {
                    x = XIL(0),
                    y = XIL(0),
                    width = XIL(0),
                    height = XIL(0)
                  },
                  image_id = 0
                },
                stretch = {
                  object = XIL(0)
                },
                xwidget = {
                  object = XIL(0)
                }
              },
              position = {
                charpos = 0,
                bytepos = 0
              },
              current = {
                pos = {
                  charpos = 0,
                  bytepos = 0
                },
                overlay_string_index = 0,
                string_pos = {
                  charpos = 0,
                  bytepos = 0
                },
                dpvec_index = 0
              },
              from_overlay = XIL(0),
              area = LEFT_MARGIN_AREA,
              method = GET_FROM_BUFFER,
              paragraph_embedding = NEUTRAL_DIR,
              multibyte_p = false,
              string_from_display_prop_p = false,
              string_from_prefix_prop_p = false,
              display_ellipsis_p = false,
              avoid_cursor_p = false,
              bidi_p = false,
              from_disp_prop_p = false,
              line_wrap = TRUNCATE,
              voffset = 0,
              space_width = XIL(0),
              font_height = XIL(0)
            }, {
              string = XIL(0),
              string_nchars = 0,
              end_charpos = 0,
              stop_charpos = 0,
              prev_stop = 0,
              base_level_stop = 0,
              cmp_it = {
                stop_pos = 0,
                id = 0,
                ch = 0,
                rule_idx = 0,
                lookback = 0,
                nglyphs = 0,
                reversed_p = false,
                parent_it = 0x0,
                charpos = 0,
                nchars = 0,
                nbytes = 0,
                from = 0,
                to = 0,
                width = 0
              },
              face_id = 0,
              u = {
                image = {
                  object = XIL(0),
                  slice = {
                    x = XIL(0),
                    y = XIL(0),
                    width = XIL(0),
                    height = XIL(0)
                  },
                  image_id = 0
                },
                stretch = {
                  object = XIL(0)
                },
                xwidget = {
                  object = XIL(0)
                }
              },
              position = {
                charpos = 0,
                bytepos = 0
              },
              current = {
                pos = {
                  charpos = 0,
                  bytepos = 0
                },
                overlay_string_index = 0,
                string_pos = {
                  charpos = 0,
                  bytepos = 0
                },
                dpvec_index = 0
              },
              from_overlay = XIL(0),
              area = LEFT_MARGIN_AREA,
              method = GET_FROM_BUFFER,
              paragraph_embedding = NEUTRAL_DIR,
              multibyte_p = false,
              string_from_display_prop_p = false,
              string_from_prefix_prop_p = false,
              display_ellipsis_p = false,
              avoid_cursor_p = false,
              bidi_p = false,
              from_disp_prop_p = false,
              line_wrap = TRUNCATE,
              voffset = 0,
              space_width = XIL(0),
              font_height = XIL(0)
            }, {
              string = XIL(0),
              string_nchars = 0,
              end_charpos = 0,
              stop_charpos = 0,
              prev_stop = 0,
              base_level_stop = 0,
              cmp_it = {
                stop_pos = 0,
                id = 0,
                ch = 0,
                rule_idx = 0,
                lookback = 0,
                nglyphs = 0,
                reversed_p = false,
                parent_it = 0x0,
                charpos = 0,
                nchars = 0,
                nbytes = 0,
                from = 0,
                to = 0,
                width = 0
              },
              face_id = 0,
              u = {
                image = {
                  object = XIL(0),
                  slice = {
                    x = XIL(0),
                    y = XIL(0),
                    width = XIL(0),
                    height = XIL(0)
                  },
                  image_id = 0
                },
                stretch = {
                  object = XIL(0)
                },
                xwidget = {
                  object = XIL(0)
                }
              },
              position = {
                charpos = 0,
                bytepos = 0
              },
              current = {
                pos = {
                  charpos = 0,
                  bytepos = 0
                },
                overlay_string_index = 0,
                string_pos = {
                  charpos = 0,
                  bytepos = 0
                },
                dpvec_index = 0
              },
              from_overlay = XIL(0),
              area = LEFT_MARGIN_AREA,
              method = GET_FROM_BUFFER,
              paragraph_embedding = NEUTRAL_DIR,
              multibyte_p = false,
              string_from_display_prop_p = false,
              string_from_prefix_prop_p = false,
              display_ellipsis_p = false,
              avoid_cursor_p = false,
              bidi_p = false,
              from_disp_prop_p = false,
              line_wrap = TRUNCATE,
              voffset = 0,
              space_width = XIL(0),
              font_height = XIL(0)
            }},
          sp = 1,
          selective = 0,
          what = IT_IMAGE,
          face_id = 16,
          selective_display_ellipsis_p = true,
          ctl_arrow_p = true,
          face_box_p = false,
          start_of_box_run_p = false,
          end_of_box_run_p = false,
          overlay_strings_at_end_processed_p = false,
          ignore_overlay_strings_at_pos_p = false,
          glyph_not_available_p = false,
          starts_in_middle_of_char_p = false,
          face_before_selective_p = false,
          constrain_row_ascent_descent_p = false,
          line_number_produced_p = false,
          line_wrap = WINDOW_WRAP,
          base_face_id = 0,
          c = 0,
          len = 0,
          cmp_it = {
            stop_pos = 0,
            id = -1,
            ch = 0,
            rule_idx = 0,
            lookback = 0,
            nglyphs = 0,
            reversed_p = false,
            parent_it = 0x7fffffffae50,
            charpos = 0,
            nchars = 0,
            nbytes = 0,
            from = 0,
            to = 0,
            width = 0
          },
          char_to_display = 0,
          glyphless_method = GLYPHLESS_DISPLAY_THIN_SPACE,
          image_id = 0,
          xwidget = 0x0,
          slice = {
            x = XIL(0),
            y = XIL(0),
            width = XIL(0),
            height = XIL(0)
          },
          space_width = XIL(0),
          voffset = 0,
          tab_width = 8,
          font_height = XIL(0),
          object = XIL(0x55555608026d),
          position = {
            charpos = 1,
            bytepos = 1
          },
          truncation_pixel_width = 0,
          continuation_pixel_width = 8,
          first_visible_x = 0,
          last_visible_x = 640,
          last_visible_y = 578,
          extra_line_spacing = 0,
          max_extra_line_spacing = 0,
          override_ascent = -1,
          override_descent = 0,
          override_boff = 0,
          glyph_row = 0x555556753400,
          area = TEXT_AREA,
          nglyphs = 1,
          pixel_width = 0,
          ascent = 0,
          descent = 0,
          max_ascent = 0,
          max_descent = 0,
          phys_ascent = 0,
          phys_descent = 0,
          max_phys_ascent = 0,
          max_phys_descent = 0,
          current_x = 0,
          continuation_lines_width = 0,
          eol_pos = {
            charpos = 0,
            bytepos = 0
          },
          current_y = 0,
          first_vpos = 0,
          vpos = 0,
          hpos = 0,
          lnum = 0,
          lnum_bytepos = 0,
          lnum_width = 0,
          lnum_pixel_width = 0,
          pt_lnum = 0,
          stretch_adjust = 0,
          left_user_fringe_bitmap = 0,
          right_user_fringe_bitmap = 0,
          left_user_fringe_face_id = 0,
          right_user_fringe_face_id = 0,
          bidi_p = false,
          bidi_it = {
            bytepos = 0,
            charpos = 0,
            ch = 0,
            nchars = 0,
            ch_len = 0,
            type = UNKNOWN_BT,
            type_after_wn = UNKNOWN_BT,
            orig_type = UNKNOWN_BT,
            resolved_level = 0 '\000',
            isolate_level = 0 '\000',
            invalid_levels = 0,
            invalid_isolates = 0,
            prev = {
              charpos = 0,
              type = UNKNOWN_BT,
              orig_type = UNKNOWN_BT
            },
            last_strong = {
              charpos = 0,
              type = UNKNOWN_BT,
              orig_type = UNKNOWN_BT
            },
            next_for_neutral = {
              charpos = 0,
              type = UNKNOWN_BT,
              orig_type = UNKNOWN_BT
            },
            prev_for_neutral = {
              charpos = 0,
              type = UNKNOWN_BT,
              orig_type = UNKNOWN_BT
            },
            next_for_ws = {
              charpos = 0,
              type = UNKNOWN_BT,
              orig_type = UNKNOWN_BT
            },
            bracket_pairing_pos = 0,
            bracket_enclosed_type = UNKNOWN_BT,
            next_en_pos = 0,
            next_en_type = UNKNOWN_BT,
            sos = NEUTRAL_DIR,
            scan_dir = 0,
            disp_pos = 0,
            disp_prop = 0,
            stack_idx = 0,
            level_stack = {{
                next_for_neutral_pos = 0,
                next_for_neutral_type = 0,
                last_strong_type = 0,
                prev_for_neutral_type = 0,
                level = 0 '\000',
                flags = 0 '\000'
              } <repeats 128 times>},
            string = {
              lstring = XIL(0),
              s = 0x0,
              schars = 0,
              bufpos = 0,
              from_disp_str = false,
              unibyte = false
            },
            w = 0x5555562e38b0,
            paragraph_dir = NEUTRAL_DIR,
            separator_limit = 0,
            first_elt = false,
            new_paragraph = false,
            frame_window_p = false
          },
          paragraph_embedding = L2R,
          min_width_property = XIL(0),
          min_width_start = 0
        }
        old_current_buffer = XIL(0x55555608026d)
        string = <optimized out>
        row = <optimized out>
        img = 0x0
        x0 = <optimized out>
        x1 = <optimized out>
        to_x = <optimized out>
        it_vpos = <optimized out>
        itdata = 0x0
#11 0x00005555556e7622 in make_lispy_position (f=f@entry=0x5555562e3660, x=<optimized out>, y=<optimized out>, t=5603645) at /home/steve/src/emacs/emacs-29/src/keyboard.c:5614
        string2 = <optimized out>
        object2 = XIL(0)
        dy2 = 0
        width2 = -10512
        height2 = 32767
        x2 = 347
        p = {
          pos = {
            charpos = 2,
            bytepos = 93824994660347
          },
          overlay_string_index = 140736912871512,
          string_pos = {
            charpos = 288,
            bytepos = 4294967256
          },
          dpvec_index = -344911323
        }
        dx2 = 2
        y2 = 158
        w = 0x5555562e38b0
        width = -1
        height = -1
        string_info = XIL(0)
        textpos = <optimized out>
        col = -1
        dx = -1
        wx = <optimized out>
        row = -1
        dy = -1
        object = XIL(0)
        wy = 158
        part = ON_TEXT
        posn = XIL(0)
        extra_info = XIL(0)
        mx = <optimized out>
        my = <optimized out>
        xret = 347
        yret = 158
        window_or_frame = XIL(0x5555562e38b5)
        tool_bar_p = false
        menu_bar_p = false
#12 0x00005555556ea0de in make_lispy_event (event=event@entry=0x555555d0f460 <kbd_buffer+3776>) at /home/steve/src/emacs/emacs-29/src/keyboard.c:6071
        f = 0x5555562e3660
        row = 1433707937
        column = 21845
        button = 0
        start_pos = <optimized out>
        is_double = <optimized out>
        position = XIL(0)
        start_pos_ptr = <optimized out>
        i = <optimized out>
#13 0x00005555556effce in kbd_buffer_get_event (kbp=kbp@entry=0x7fffffffd808, used_mouse_menu=used_mouse_menu@entry=0x7fffffffddbb, end_time=end_time@entry=0x0) at /home/steve/src/emacs/emacs-29/src/keyboard.c:4288
        pinch_dx = <optimized out>
        pinch_dy = <optimized out>
        pinch_angle = <optimized out>
        frame = <optimized out>
        focus = <optimized out>
        event = 0x555555d0f460 <kbd_buffer+3776>
        obj = XIL(0)
        str = <optimized out>
        had_pending_selection_requests = <optimized out>
#14 0x00005555556f0551 in read_event_from_main_queue (end_time=end_time@entry=0x0, local_getcjmp=local_getcjmp@entry=0x7fffffffdb40, used_mouse_menu=used_mouse_menu@entry=0x7fffffffddbb) at /home/steve/src/emacs/emacs-29/src/keyboard.c:2270
        c = XIL(0)
        save_jump = {{
            __jmpbuf = {0, 0, 0, 0, 0, 0, 0, 0},
            __mask_was_saved = 0,
            __saved_mask = {
              __val = {0 <repeats 16 times>}
            }
          }}
        kb = 0x555555f38f30
#15 0x00005555556f06ab in read_decoded_event_from_main_queue (end_time=end_time@entry=0x0, local_getcjmp=local_getcjmp@entry=0x7fffffffdb40, prev_event=prev_event@entry=XIL(0), used_mouse_menu=used_mouse_menu@entry=0x7fffffffddbb) at /home/steve/src/emacs/emacs-29/src/keyboard.c:2333
        nextevt = <optimized out>
        frame = <optimized out>
        terminal = <optimized out>
        events = {XIL(0), XIL(0x5555563e3193), XIL(0x5555560fc083), XIL(0x23166c5f58343d00), XIL(0x5555560fc063), XIL(0x23166c5f58343d00), XIL(0), XIL(0x5555560fc063), XIL(0x5555560fc073), XIL(0), XIL(0x1), XIL(0), XIL(0x5555560e6b01), XIL(0x5555556ef153), XIL(0x1), XIL(0x1)}
        n = 0
#16 0x00005555556f17c7 in read_char (commandflag=1, map=map@entry=XIL(0x555556a57cf3), prev_event=XIL(0), used_mouse_menu=used_mouse_menu@entry=0x7fffffffddbb, end_time=end_time@entry=0x0) at /home/steve/src/emacs/emacs-29/src/keyboard.c:2964
        c = <optimized out>
        local_getcjmp = {{
            __jmpbuf = {0, 1777488678940991397, 1443785600, 0, 0, 93825004366723, 5620416908969795493, 1777494992433471397},
            __mask_was_saved = 0,
            __saved_mask = {
              __val = {93824994288257, 37776, 140737488346096, 2, 0, 0, 93824994346483, 93825004068848, 96, 0, 140737142423072, 140737150321675, 93824994287073, 140737150321659, 93824993957934, 4294967296}
            }
          }}
        save_jump = {{
            __jmpbuf = {0, 0, 0, 0, 0, 0, 0, 0},
            __mask_was_saved = 0,
            __saved_mask = {
              __val = {0 <repeats 16 times>}
            }
          }}
        tem = <optimized out>
        save = <optimized out>
        previous_echo_area_message = XIL(0)
        also_record = XIL(0)
        reread = false
        recorded = false
        polling_stopped_here = true
        orig_kboard = 0x555555f38f30
#17 0x00005555556f244e in read_key_sequence (keybuf=keybuf@entry=0x7fffffffdec0, prompt=prompt@entry=XIL(0), dont_downcase_last=dont_downcase_last@entry=false, can_return_switch_frame=can_return_switch_frame@entry=true, fix_current_buffer=fix_current_buffer@entry=true, prevent_redisplay=prevent_redisplay@entry=false) at /home/steve/src/emacs/emacs-29/src/keyboard.c:10074
        interrupted_kboard = 0x555555f38f30
        interrupted_frame = 0x5555562e3660
        key = <optimized out>
        used_mouse_menu = false
        echo_local_start = 0
        last_real_key_start = 0
        keys_local_start = 0
        new_binding = <optimized out>
        t = 0
        echo_start = 0
        keys_start = 0
        current_binding = XIL(0x555556a57cf3)
        first_unbound = 31
        mock_input = 0
        used_mouse_menu_history = {false <repeats 30 times>}
        fkey = {
          parent = XIL(0x555555ea3423),
          map = XIL(0x555555ea3423),
          start = 0,
          end = 0
        }
        keytran = {
          parent = XIL(0x7fffebd95b4b),
          map = XIL(0x7fffebd95b4b),
          start = 0,
          end = 0
        }
        indec = {
          parent = XIL(0x555555ea3413),
          map = XIL(0x555555ea3413),
          start = 0,
          end = 0
        }
        shift_translated = false
        delayed_switch_frame = XIL(0)
        original_uppercase = XIL(0)
        original_uppercase_position = -1
        dummyflag = false
        starting_buffer = 0x555556080268
        fake_prefixed_keys = XIL(0)
        first_event = XIL(0)
        second_event = <optimized out>
#18 0x00005555556f3817 in command_loop_1 () at /home/steve/src/emacs/emacs-29/src/keyboard.c:1376
        cmd = <optimized out>
        keybuf = {make_fixnum(13), make_fixnum(100), XIL(0x80), XIL(0x9900), XIL(0x555555d75280), XIL(0), make_fixnum(0), XIL(0), XIL(0), XIL(0x55555574a281), XIL(0x9900), XIL(0x7fffffffdf70), make_fixnum(0), XIL(0), XIL(0), XIL(0x5555557585f3), XIL(0x555555e1db40), XIL(0x60), XIL(0x30), XIL(0), XIL(0), XIL(0x555555759a1d), XIL(0xb), XIL(0x9900), XIL(0), XIL(0x7fffeb61370d), make_fixnum(1000), XIL(0x23166c5f58343d00), XIL(0x60), XIL(0x7fffebd9f4fb)}
        i = <optimized out>
        prev_modiff = 915
        prev_buffer = 0x5555560f4620
#19 0x0000555555758cab in internal_condition_case (bfun=bfun@entry=0x5555556f3645 <command_loop_1>, handlers=handlers@entry=XIL(0x90), hfun=hfun@entry=0x5555556e9396 <cmd_error>) at /home/steve/src/emacs/emacs-29/src/eval.c:1474
        val = <optimized out>
        c = 0x555555e88f80
#20 0x00005555556e426b in command_loop_2 (handlers=handlers@entry=XIL(0x90)) at /home/steve/src/emacs/emacs-29/src/keyboard.c:1125
        val = <optimized out>
#21 0x0000555555758c22 in internal_catch (tag=tag@entry=XIL(0x10050), func=func@entry=0x5555556e4251 <command_loop_2>, arg=arg@entry=XIL(0x90)) at /home/steve/src/emacs/emacs-29/src/eval.c:1197
        val = <optimized out>
        c = 0x555555e88e40
#22 0x00005555556e422e in command_loop () at /home/steve/src/emacs/emacs-29/src/keyboard.c:1103
#23 0x00005555556e8fa2 in recursive_edit_1 () at /home/steve/src/emacs/emacs-29/src/keyboard.c:712
        val = <optimized out>
#24 0x00005555556e92ae in Frecursive_edit () at /home/steve/src/emacs/emacs-29/src/keyboard.c:795
        buffer = <optimized out>
#25 0x00005555556e3848 in main (argc=2, argv=0x7fffffffe268) at /home/steve/src/emacs/emacs-29/src/emacs.c:2529
        stack_bottom_variable = 0x7fffeca69080 <(anonymous namespace)::num_get_w>
        no_loadup = false
        junk = 0x0
        dname_arg = 0x0
        ch_to_dir = 0x0
        original_pwd = <optimized out>
        dump_mode = <optimized out>
        skip_args = 0
        temacs = 0x0
        attempt_load_pdump = <optimized out>
        only_version = false
        rlim = {
          rlim_cur = 10022912,
          rlim_max = 18446744073709551615
        }
        lc_all = <optimized out>
        sockfd = -1
        module_assertions = <optimized out>
(gdb) 

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

>
> I see the problem in Emacs 29 and master, but not in Emacs 28, on the 
> same system, i.e. with the same image libraries.  When the bad display 
> appears, the following entry appears in *Messages*:
>
> Error parsing SVG image: XML parse error: Error domain 1 code 68 on line 
> 7393 column 18 of data: StartTag: invalid element name
>
> This seems to comes from svg_load_image in image.c.  I started Emacs 29 
> with -Q in gdb after setting a breakpoint at svg_load_image, opened the 
> PDF file, hit the breakpoint and stepped through till the bad display 
> appeared.  The ouput of bt full is attached.  (I also ran Emacs 28 under 
> gdb with the same breakpoint, and there visiting the PDF file does not 
> hit the breakpoint.)
>

Thanks.  Can you please also share the "/tmp/docview1000/FR 205.pdf-7039e6f9886aceec549c36d51591d258/page-1.svg" file?

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

>
> Thanks.  Can you please also share the "/tmp/docview1000/FR 
> 205.pdf-7039e6f9886aceec549c36d51591d258/page-1.svg" file?
>

And also the output of "mutool -v" (IOW, the version of mupdf that is 
installed on your computer)?

bug#60308: 30.0.50; Can't read some PDF files any more

[Stephen Berman]

[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]

On Fri, 06 Jan 2023 10:10:03 +0000 Gregory Heytings <gregory@heytings.org> wrote:

>>
>> I see the problem in Emacs 29 and master, but not in Emacs 28, on the same
>> system, i.e. with the same image libraries.  When the bad display appears,
>> the following entry appears in *Messages*:
>>
>> Error parsing SVG image: XML parse error: Error domain 1 code 68 on line
>> 7393 column 18 of data: StartTag: invalid element name
>>
>> This seems to comes from svg_load_image in image.c.  I started Emacs 29 with
>> -Q in gdb after setting a breakpoint at svg_load_image, opened the PDF file,
>> hit the breakpoint and stepped through till the bad display appeared.  The
>> ouput of bt full is attached.  (I also ran Emacs 28 under gdb with the same
>> breakpoint, and there visiting the PDF file does not hit the breakpoint.)
>>
>
> Thanks.  Can you please also share the "/tmp/docview1000/FR
> 205.pdf-7039e6f9886aceec549c36d51591d258/page-1.svg" file?

Attached (gzipped).  In the mean time I found the problem: that file
contains occurrences of "<" and that causes the error; after replacing
them with "&lt;" the PDF is displayed correctly.

On Fri, 06 Jan 2023 10:22:02 +0000 Gregory Heytings <gregory@heytings.org> wrote:

>
> And also the output of "mutool -v" (IOW, the version of mupdf that is
> installed on your computer)?

mutool version 1.21.0

Steve Berman


[-- Attachment #2: page-1.svg.gz --]
[-- Type: application/octet-stream, Size: 210679 bytes --]

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

>
> Attached (gzipped).  In the mean time I found the problem: that file 
> contains occurrences of "<" and that causes the error; after replacing 
> them with "&lt;" the PDF is displayed correctly.
>
> [...]
>
> mutool version 1.21.0
>

Thanks.  So this looks like a mutool bug, which generates incorrect SGV 
files, right?

bug#60308: 30.0.50; Can't read some PDF files any more

[Stephen Berman]

On Fri, 06 Jan 2023 11:12:19 +0000 Gregory Heytings <gregory@heytings.org> wrote:

>>
>> Attached (gzipped).  In the mean time I found the problem: that file
>> contains occurrences of "<" and that causes the error; after replacing them
>> with "&lt;" the PDF is displayed correctly.
>>
>> [...]
>>
>> mutool version 1.21.0
>>
>
> Thanks.  So this looks like a mutool bug, which generates incorrect SGV files,
> right?

Yep.  I just converted the PDF to SVG with mutool 1.19.0 and the
resulting image displays correctly and there is no "<" in the file.

Steve Berman

bug#60308: 30.0.50; Can't read some PDF files any more

[Eli Zaretskii]

> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: Eli Zaretskii <eliz@gnu.org>,  60308@debbugs.gnu.org,
>   yantar92@posteo.net,  bugs@gnu.support
> Date: Fri, 06 Jan 2023 12:44:16 +0100
> 
> On Fri, 06 Jan 2023 11:12:19 +0000 Gregory Heytings <gregory@heytings.org> wrote:
> 
> >>
> >> Attached (gzipped).  In the mean time I found the problem: that file
> >> contains occurrences of "<" and that causes the error; after replacing them
> >> with "&lt;" the PDF is displayed correctly.
> >>
> >> [...]
> >>
> >> mutool version 1.21.0
> >>
> >
> > Thanks.  So this looks like a mutool bug, which generates incorrect SGV files,
> > right?
> 
> Yep.  I just converted the PDF to SVG with mutool 1.19.0 and the
> resulting image displays correctly and there is no "<" in the file.

xmllint clearly says the file is invalid, due to those "<" characters.

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

>> Thanks.  So this looks like a mutool bug, which generates incorrect SGV 
>> files, right?
>
> Yep.  I just converted the PDF to SVG with mutool 1.19.0 and the 
> resulting image displays correctly and there is no "<" in the file.
>

Okay, so this bug should be reported to mupdf instead, and this one can be 
closed.

FTR, I tried to open that SVG file with GIMP and ImageMagick, and both 
failed.

bug#60308: 30.0.50; Can't read some PDF files any more

[Jean Louis]

* Eli Zaretskii <eliz@gnu.org> [2023-01-06 09:40]:
> Thanks.
> 
> So maybe the problem is updates to libraries/executables we use for
> viewing PDF?  AFAIR, this is DocView, and it use Ghostscript and
> libpng?  Maybe both Jean and Ihor had their systems updated
> recently?

I use Parabola GNU/Linux-libre.

After viewing PDF, I could see background process of mutool which was
making CPU busy for no apparent reason. Maybe it is related, I can't
know.

I can also observe that viewing DVI files with xdvi is terribly slow,
I can't know why, maybe it is related, maybe not.


--
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/

bug#60308: 30.0.50; Can't read some PDF files any more

[Jean Louis]

* Gregory Heytings <gregory@heytings.org> [2023-01-06 13:24]:
> 
> > 
> > Thanks.  Can you please also share the "/tmp/docview1000/FR
> > 205.pdf-7039e6f9886aceec549c36d51591d258/page-1.svg" file?
> > 
> 
> And also the output of "mutool -v" (IOW, the version of mupdf that is
> installed on your computer)?

Mine is: mutool version 1.21.0

-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/

bug#60308: 30.0.50; Can't read some PDF files any more

[Eli Zaretskii]

> Date: Fri, 06 Jan 2023 12:22:44 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: Eli Zaretskii <eliz@gnu.org>, 60308@debbugs.gnu.org, yantar92@posteo.net, 
>     bugs@gnu.support
> 
> 
> >> Thanks.  So this looks like a mutool bug, which generates incorrect SGV 
> >> files, right?
> >
> > Yep.  I just converted the PDF to SVG with mutool 1.19.0 and the 
> > resulting image displays correctly and there is no "<" in the file.
> >
> 
> Okay, so this bug should be reported to mupdf instead

They already released version 1.21.1, maybe it fixes this problem?

> and this one can be closed.

Right, done.

bug#60308: 30.0.50; Can't read some PDF files any more

[Stephen Berman]

On Fri, 06 Jan 2023 14:55:56 +0200 Eli Zaretskii <eliz@gnu.org> wrote:

>> Date: Fri, 06 Jan 2023 12:22:44 +0000
>> From: Gregory Heytings <gregory@heytings.org>
>> cc: Eli Zaretskii <eliz@gnu.org>, 60308@debbugs.gnu.org, yantar92@posteo.net,
>>     bugs@gnu.support
>>
>>
>> >> Thanks.  So this looks like a mutool bug, which generates incorrect SGV
>> >> files, right?
>> >
>> > Yep.  I just converted the PDF to SVG with mutool 1.19.0 and the
>> > resulting image displays correctly and there is no "<" in the file.
>> >
>>
>> Okay, so this bug should be reported to mupdf instead
>
> They already released version 1.21.1, maybe it fixes this problem?

FTR, I just updated my mupdf to 1.21.1 and unfortunately the problem
remains as before.  I'll try to file a bug report with mupdf.

Steve Berman

bug#60308: 30.0.50; Can't read some PDF files any more

[Manuel Giraud]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Stephen Berman <stephen.berman@gmx.net> writes:

[...]

> FTR, I just updated my mupdf to 1.21.1 and unfortunately the problem
> remains as before.  I'll try to file a bug report with mupdf.

Hi,

Here a first patch that prevent producing SVG when mutool has a
version > 1.20.  Feel free to comment and fix.

Best regards,

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Prevent-DocView-to-produce-SVG-with-mutool-for-versi.patch --]
[-- Type: text/x-patch, Size: 1459 bytes --]

From 21c0e276189438ef04500697ef22ce663f650b3b Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Sat, 7 Jan 2023 16:40:58 +0100
Subject: [PATCH] Prevent DocView to produce SVG with mutool for version > 1.20
 (bug#60308)

* lisp/doc-view.el (doc-view-mutool-version): New variable
containing the mutool version string.
(doc-view-mupdf-use-svg): If the mutool version is higher than
1.20 do not use SVG output.
---
 lisp/doc-view.el | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 7c272f52fb3..3253387e01e 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -209,7 +209,19 @@ doc-view-pdf->png-converter-function
           function)
   :version "24.4")
 
-(defcustom doc-view-mupdf-use-svg (image-type-available-p 'svg)
+(defvar doc-view-mutool-version
+  (let ((mutool (executable-find "mutool")))
+    (if mutool
+        (with-temp-buffer
+          (call-process mutool nil t nil "-v")
+          (goto-char (point-min))
+          (re-search-forward "^mutool version \\([^ ]+\\)\n")
+          (match-string 1))
+      "")))
+
+(defcustom doc-view-mupdf-use-svg (and (image-type-available-p 'svg)
+                                       (string-version-lessp doc-view-mutool-version
+                                                             "1.20"))
   "Whether to use svg images for PDF files."
   :type 'boolean
   :version "29.1")
-- 
2.39.0


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

>
> Here a first patch that prevent producing SVG when mutool has a version > 1.20.  Feel free to comment and fix.
>

I just tried, and most PDF files are processed without problems with 
mutool 1.21.  So I'm not sure we should install such a workaround in 
Emacs, for a bug that happens in some cases for some specific versions 
(1.20 and 1.21) of a specific external program.

Those who have these versions of that program can (temporarily) add

(setq doc-view-mupdf-use-svg nil)

to their init file, or toggle that value to open problematic files.

bug#60308: 30.0.50; Can't read some PDF files any more

[Eli Zaretskii]

> Date: Sat, 07 Jan 2023 18:25:58 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: Stephen Berman <stephen.berman@gmx.net>, Eli Zaretskii <eliz@gnu.org>, 
>     60308@debbugs.gnu.org, yantar92@posteo.net, bugs@gnu.support
> 
> 
> >
> > Here a first patch that prevent producing SVG when mutool has a version > 1.20.  Feel free to comment and fix.
> >
> 
> I just tried, and most PDF files are processed without problems with 
> mutool 1.21.

That's not what Stephen says, he tried 1.21.1.

> So I'm not sure we should install such a workaround in Emacs, for a
> bug that happens in some cases for some specific versions (1.20 and
> 1.21) of a specific external program.
> 
> Those who have these versions of that program can (temporarily) add
> 
> (setq doc-view-mupdf-use-svg nil)
> 
> to their init file, or toggle that value to open problematic files.

We can, of course, have an entry in etc/PROBLEMS, if that's the best
we can do.  But I wonder why you see something different from what
others see.

bug#60308: 30.0.50; Can't read some PDF files any more

[Manuel Giraud]

Gregory Heytings <gregory@heytings.org> writes:

>>
>> Here a first patch that prevent producing SVG when mutool has a
>> version > 1.20.  Feel free to comment and fix.
>>
>
> I just tried, and most PDF files are processed without problems with
> mutool 1.21.

It happens when a document contains a '<' character so it can be rare
for someone.

> So I'm not sure we should install such a workaround in Emacs, for a
> bug that happens in some cases for some specific versions (1.20 and
> 1.21) of a specific external program.

You are right that it should be a temporary bug in mupdf.  But I was
more worry of random page not rendering as it was before with DocView.
-- 
Manuel Giraud

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

>> I just tried, and most PDF files are processed without problems with 
>> mutool 1.21.
>
> That's not what Stephen says, he tried 1.21.1.
>

Sorry, I meant 1.21.1.

>
> We can, of course, have an entry in etc/PROBLEMS, if that's the best we 
> can do.  But I wonder why you see something different from what others 
> see.
>

I see the same problem with the Jean's file, but I tried a random sample 
of about 20 PDF files and only a couple failed to be rendered correctly.

Perhaps we could add a command to toggle the rendering mode?

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

>> I just tried, and most PDF files are processed without problems with 
>> mutool 1.21.
>
> It happens when a document contains a '<' character so it can be rare 
> for someone.
>

More precisely: it happens for pages with a '<' character.  Other pages of 
the document are rendered correctly.

bug#60308: 30.0.50; Can't read some PDF files any more

[Eli Zaretskii]

> Date: Sat, 07 Jan 2023 18:59:27 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: Eli Zaretskii <eliz@gnu.org>, Stephen Berman <stephen.berman@gmx.net>, 
>     yantar92@posteo.net, 60308@debbugs.gnu.org, bugs@gnu.support
> 
> 
> >> I just tried, and most PDF files are processed without problems with 
> >> mutool 1.21.
> >
> > It happens when a document contains a '<' character so it can be rare 
> > for someone.
> >
> 
> More precisely: it happens for pages with a '<' character.  Other pages of 
> the document are rendered correctly.

If it's rare, maybe a PROBLEMS entry is good enough.

bug#60308: 30.0.50; Can't read some PDF files any more

[Manuel Giraud]

Gregory Heytings <gregory@heytings.org> writes:

[...]

>> It happens when a document contains a '<' character so it can be
>> rare for someone.
>>
>
> More precisely: it happens for pages with a '<' character.  Other
> pages of the document are rendered correctly.

Yes you're right.
-- 
Manuel Giraud

bug#60308: 30.0.50; Can't read some PDF files any more

[Manuel Giraud]

Eli Zaretskii <eliz@gnu.org> writes:

[...]

>> More precisely: it happens for pages with a '<' character.  Other pages of 
>> the document are rendered correctly.
>
> If it's rare, maybe a PROBLEMS entry is good enough.

I guess I'm not lucky because most of the document I read have some
pages with a '<' character 😅

Anyway, I'm fine with an etc/PROBLEMS entry.  For the moment, I'll set
doc-view-mupdf-use-svg to nil and try to see with Stephen how to have it
handled upstream.
-- 
Manuel Giraud

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

A bug report, with a corrective patch, has been submitted to Debian:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028156

bug#60308: 30.0.50; Can't read some PDF files any more

[Manuel Giraud]

Gregory Heytings <gregory@heytings.org> writes:

> A bug report, with a corrective patch, has been submitted to Debian:

Thanks.  I'm not using Debian so I hope it will make it upstream.  Could
I try to submit it to mupdf?
-- 
Manuel Giraud

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

>> A bug report, with a corrective patch, has been submitted to Debian:
>
> Thanks.  I'm not using Debian so I hope it will make it upstream. 
> Could I try to submit it to mupdf?
>

Sure.  Perhaps add a link to the Debian bug report, and mention in the 
Debian bug thread that you reported it upstream.

bug#60308: 30.0.50; Can't read some PDF files any more

[Manuel Giraud]

Gregory Heytings <gregory@heytings.org> writes:

[...]

> Sure.  Perhaps add a link to the Debian bug report, and mention in the
> Debian bug thread that you reported it upstream.

Hi Gregory,

It seems that your patch was merged upstream:
https://bugs.ghostscript.com/show_bug.cgi?id=706320

So I think that we could left `doc-view-mupdf-use-svg' as it is and just
have an entry in etc/PROBLEMS.

Thanks,
-- 
Manuel Giraud

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]


>
> It seems that your patch was merged upstream: 
> https://bugs.ghostscript.com/show_bug.cgi?id=706320
>

Great, that was fast! 😃

>
> So I think that we could left `doc-view-mupdf-use-svg' as it is and just 
> have an entry in etc/PROBLEMS.
>

Agreed, just mentioning that some specific versions of mupdf have a bug 
should be enough.  It would be even better if DocView could automatically 
fall back to generating a PNG file, but that seems rather complex to do.

bug#60308: 30.0.50; Can't read some PDF files any more

[Eli Zaretskii]

> Date: Wed, 11 Jan 2023 16:26:26 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: 60308@debbugs.gnu.org, bugs@gnu.support, yantar92@posteo.net, 
>     Eli Zaretskii <eliz@gnu.org>, stephen.berman@gmx.net
> 
> > So I think that we could left `doc-view-mupdf-use-svg' as it is and just 
> > have an entry in etc/PROBLEMS.
> 
> Agreed, just mentioning that some specific versions of mupdf have a bug 
> should be enough.

How do we do that? I don't see in that bug report anything that says
which version will have that fixed.  What did I miss?

bug#60308: 30.0.50; Can't read some PDF files any more

[Gregory Heytings]

>> Agreed, just mentioning that some specific versions of mupdf have a bug 
>> should be enough.
>
> How do we do that? I don't see in that bug report anything that says 
> which version will have that fixed.  What did I miss?
>

Versions 1.19 and 1.20 are not affected by that bug, currently only 
version 1.21 is (1.21.0 was released two months ago, 1.21.1 one month 
ago).

According to https://mupdf.com/releases/history.html they release a new 
version every six months or so, and a minor version when necessary.  So I 
would guess that this will be fixed either in version 1.21.2, or in 
version 1.22 in a few months.

bug#60308: 30.0.50; Can't read some PDF files any more

[Eli Zaretskii]

> Date: Wed, 11 Jan 2023 19:33:54 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: 60308@debbugs.gnu.org, stephen.berman@gmx.net, yantar92@posteo.net, 
>     bugs@gnu.support, manuel@ledu-giraud.fr
> 
> 
> >> Agreed, just mentioning that some specific versions of mupdf have a bug 
> >> should be enough.
> >
> > How do we do that? I don't see in that bug report anything that says 
> > which version will have that fixed.  What did I miss?
> >
> 
> Versions 1.19 and 1.20 are not affected by that bug, currently only 
> version 1.21 is (1.21.0 was released two months ago, 1.21.1 one month 
> ago).
> 
> According to https://mupdf.com/releases/history.html they release a new 
> version every six months or so, and a minor version when necessary.  So I 
> would guess that this will be fixed either in version 1.21.2, or in 
> version 1.22 in a few months.

OK, I've now added a PROBLEMS entry about this.  We can update it with
a non-buggy version when we know it.

And with that, I'm closing the bug.

Thanks.