From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61350: Eglot over Tramp freezes with large project Date: Wed, 15 Mar 2023 19:44:25 +0000 Message-ID: <878rfx6bqe.fsf@gmail.com> References: <87y1ootw2t.fsf@gmail.com> <87a60ovi90.fsf@gmx.de> <31964054.380679.1678194256931@office.mailbox.org> <87r0u0u0rl.fsf@gmx.de> <87mt4otyy1.fsf@gmx.de> <87pm9fk6ht.fsf@gmx.de> <87mt4jzf8q.fsf@gmail.com> <87fsabh2z2.fsf@gmx.de> <87edpvxu7w.fsf@gmail.com> <87bkkzgyb8.fsf@gmx.de> <87lek2x09t.fsf@gmail.com> <875yb646d1.fsf@gmx.de> <87fsa7mw9x.fsf@gmx.de> <87fsa7l6o6.fsf@gmx.de> <87a60fl4p7.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18681"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Thomas Koch , Michael Albinus , 61350@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 15 20:43:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcX1w-0004cv-R2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Mar 2023 20:43:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcX1b-0005WL-Sg; Wed, 15 Mar 2023 15:43:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcX1a-0005W9-Cz for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 15:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcX1a-0005Qv-4x for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 15:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pcX1Z-00083K-K3 for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 15:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Mar 2023 19:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61350 X-GNU-PR-Package: emacs Original-Received: via spool by 61350-submit@debbugs.gnu.org id=B61350.167890935430918 (code B ref 61350); Wed, 15 Mar 2023 19:43:01 +0000 Original-Received: (at 61350) by debbugs.gnu.org; 15 Mar 2023 19:42:34 +0000 Original-Received: from localhost ([127.0.0.1]:40589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcX18-00082c-0y for submit@debbugs.gnu.org; Wed, 15 Mar 2023 15:42:34 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:36698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcX15-00082M-He for 61350@debbugs.gnu.org; Wed, 15 Mar 2023 15:42:32 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id j19-20020a05600c191300b003eb3e1eb0caso1760135wmq.1 for <61350@debbugs.gnu.org>; Wed, 15 Mar 2023 12:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678909345; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y8F7PtEdS7jSrKiU/ZqEd5Yjcd/g/sKYizbo2Jz7qek=; b=nfHquEAkLBhwq0wXxz8wnfTIGvsAwW2ILC1qKY+qo/cm5+y7KhQV9qdT8VUJHMAywZ tEKZDzpq9bu4lGjENio5kt389CXg20EHvAS8oTLTIZZLyn0HoWo9pqh0hNdSgDJyVVgP QbBFcmE1/rtmnTArHGyBHI4Ss+1GjVjPXH+x0NdzEYAmTp3LOQ57O+98PX0OZNVNgPnc AHK1Dt9OLqrz2ICXFE9qvx6SG4AUlpd4PijjZfMshro1F8SIbnix4SAUTKJalpZ00G29 wE1TbeVQA5sceh4j9s5YkHv++LutKth4KuJ5mSnVp9ZKODzyaeFteN0F1uPC/SLBSX11 BwKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678909345; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Y8F7PtEdS7jSrKiU/ZqEd5Yjcd/g/sKYizbo2Jz7qek=; b=mqMFnswfTKbdqkWPxh80+GnQt6XlEtq1ErS/7CXagtZL8w3tIc4PRFrGKZRISiBOWG 24j5j4qW82nJZBiA6g9Da5YJCl+/LctLBT6+mbSzbaCA9zH+eKkS/v1vb+Vuh6C7nQTL 1/iTAoMo4yyn3xScuhei28cDdwBJUeZm98myuhd3xWPbtoqY87kiKZzuIE7a9CPkcmcg eXAsq2NzfJNK4GDs/wM3XsE3iEjXAd5Y2Y3Y4fjmL1oXffYINQCPijQgfuAFrp7O8Hln dCc8eG07Q4pKSaw7a72SsK+EoKtPYFZlM+GRInduUEKUviMlQkZ04hl4TgpZlDvfczpW pgVA== X-Gm-Message-State: AO0yUKXy1H081UaJ8S2wx4bosaoiZ7B6lpZcoeVb8EaLrW8j87Ak9ESJ R8O8RGnNC7FKEi3jpOAddu8QPtVVpTU= X-Google-Smtp-Source: AK7set+6GJvEoNCXiLMSs2O+5bC+aDfbowiCKwDV6g2E0cL03J4cpSA9xgRedIA9IXmt7r2A7gSMmQ== X-Received: by 2002:a05:600c:1c95:b0:3eb:2b69:c3c6 with SMTP id k21-20020a05600c1c9500b003eb2b69c3c6mr18975710wms.1.1678909345271; Wed, 15 Mar 2023 12:42:25 -0700 (PDT) Original-Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id f6-20020a1c6a06000000b003ed2fb86f85sm2762997wmc.47.2023.03.15.12.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 12:42:24 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 15 Mar 2023 14:30:24 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257981 Archived-At: Stefan Monnier writes: >> We could start by understanding exactly what is triggering this reentran= cy. >> AFAIU, we don't. If have a recipe to trigger is consistently, now we sh= ould >> work backwards from there. > > I think we understand some of the problems well enough to think > about solutions. Does that "some" include _this_ problem? Let's take this one for example. make -C test filenotify-tests SELECTOR=3Dfile-notify-test04-autorevert Michael reports that this reports "Forbidden reentrant call of Tramp" on EMBA. I've confirmed it fails locally with a different error: (file-error "=E2=80=98tramp_stat_file_attributes /tmp/file-notify-testNk= Tum7/file-notify-testhEtklA=E2=80=99 does not return a valid Lisp expressio= n: =E2=80=98=E2=80=99") Good enough, a failure is a failure is a failure. We know this was introduced by the recent changes 54ef338ba3670415cf47fabc33a92d4904707c7e. But we don't know a lot of other stuff * Why the difference between Local and EMBA? * How is this test supposed to work? * Can we split the test to be shorter, as currently it takes between 25 second and 120 seconds to run? * What exactly breaks here? The test fails consistently enough, that we should be able to log/instrument/debug. IMHO, we can be answering this in parallel with -- but ideally before -- a deeper review of Emacs's process machinery. We could also ask other questions, of course, like: could Tramp use a process filter? IMO these are very powerful tools and bring a substantial degree of freedom of implementation. Currently Tramp relies on accept-p-o and then searches the process buffer for regexps. To me, that just seems more difficult and error-prone than process filters. But even my own questions I would defer until after we have understood this particular failure of file-notify-test04-autorevert on master. Jo=C3=A3o